Application\Bundle\DefaultBundle\Service\EventService

Complexity

Total Complexity

16

Size/Duplication

Total Lines	119
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	getEventPages()	0	42	10
A	getEventPagesArr()	0	9	2
A	getEventMenuPages()	0	12	3
A	__construct()	0	6	1

<?php

namespace Application\Bundle\DefaultBundle\Service;

use Application\Bundle\DefaultBundle\Repository\TicketCostRepository;
use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Persistence\ObjectRepository;
use Stfalcon\Bundle\EventBundle\Entity\Event;
use Stfalcon\Bundle\EventBundle\Entity\EventGroup;
use Stfalcon\Bundle\EventBundle\Entity\EventPage;
use Stfalcon\Bundle\EventBundle\Repository\EventRepository;
use Stfalcon\Bundle\EventBundle\Repository\ReviewRepository;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Symfony\Component\Security\Core\Authorization\AuthorizationChecker;
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;

/**
 * Class EventService.
 */
class EventService
{
    /** @var EventRepository */
    private $eventRepository;

    /** @var TicketCostRepository */
    private $ticketCostRepository;

    /** @var ReviewRepository */
    private $reviewRepository;

    /** @var AuthorizationChecker */
    private $authorizationChecker;

    /**
     * EventService constructor.
     *
     * @param ObjectRepository              $eventRepository
     * @param ObjectRepository              $ticketCostRepository
     * @param ObjectRepository              $reviewRepository
     * @param AuthorizationCheckerInterface $authorizationChecker
     */
    public function __construct(ObjectRepository $eventRepository, ObjectRepository $ticketCostRepository, ObjectRepository $reviewRepository, AuthorizationCheckerInterface $authorizationChecker)
    {
        $this->eventRepository = $eventRepository;

$eventRepository is of type Doctrine\Common\Persistence\ObjectRepository, but the property $eventRepository was declared to be of type Stfalcon\Bundle\EventBundle\Repository\EventRepository. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        $this->ticketCostRepository = $ticketCostRepository;

$ticketCostRepository is of type Doctrine\Common\Persistence\ObjectRepository, but the property $ticketCostRepository was declared to be of type Application\Bundle\DefaultBundle\Repository\TicketCostRepository. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        $this->reviewRepository = $reviewRepository;

$reviewRepository is of type Doctrine\Common\Persistence\ObjectRepository, but the property $reviewRepository was declared to be of type Stfalcon\Bundle\EventBundle\Repository\ReviewRepository. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        $this->authorizationChecker = $authorizationChecker;

$authorizationChecker is of type Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface, but the property $authorizationChecker was declared to be of type Symfony\Component\Security\Core\Authorization\AuthorizationChecker. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

    }

    /**
     * @param Event $event
     * @param null  $reviewSlug

Are you sure the doc-type for parameter $reviewSlug is correct as it would always require null to be passed?

     *
     * @return array
     */
    public function getEventPages(Event $event, $reviewSlug = null)
    {
        if ($event->isAdminOnly() && !$this->authorizationChecker->isGranted('ROLE_ADMIN')) {
            throw new NotFoundHttpException(sprintf('Unable to find event by slug: %s', $event->getSlug()));
        }
        $review = null;
        if ($reviewSlug) {

$reviewSlug is of type null, thus it always evaluated to false.

            $review = $this->reviewRepository->findOneBy(['slug' => $reviewSlug]);

            if (!$review) {
                throw new NotFoundHttpException('Unable to find Review entity.');
            }
        }

        /** @var ArrayCollection $pages */
        $pages = $this->getEventMenuPages($event);

        /** @var EventPage $page */
        $programPage = null;
        $venuePage = null;
        foreach ($pages as $key => $page) {
            if ('program' === $page->getSlug()) {
                $programPage = $page;
                unset($pages[$key]);
            } elseif ('venue' === $page->getSlug()) {
                $venuePage = $page;
                unset($pages[$key]);
            }
        }

        $eventCurrentAmount = $this->ticketCostRepository->getEventCurrentCost($event);

        $futureEvent = !$event->isActiveAndFuture() && $event->getGroup() instanceof EventGroup ? $this->eventRepository->findFutureEventFromSameGroup($event->getGroup()) : null;

        return [
            'event' => $event,
            'programPage' => $programPage,
            'venuePage' => $venuePage,
            'pages' => $pages,
            'review' => $review,
            'eventCurrentAmount' => $eventCurrentAmount,
            'futureEvent' => $futureEvent,
        ];
    }

    /**
     * Return array of event with pages.
     *
     * @param string      $eventSlug
     * @param string|null $reviewSlug
     *
     * @return array
     */
    public function getEventPagesArr($eventSlug, $reviewSlug = null)
    {
        /** @var Event $event */
        $event = $this->eventRepository->findOneBy(['slug' => $eventSlug]);
        if (!$event instanceof Event) {

$event is always a sub-type of Stfalcon\Bundle\EventBundle\Entity\Event.

            throw new NotFoundHttpException(sprintf('Unable to find event by slug: %s', $eventSlug));
        }

        return $this->getEventPages($event, $reviewSlug);

It seems like $reviewSlug can also be of type string; however, parameter $reviewSlug of Application\Bundle\DefaultBundle\Service\EventService::getEventPages() does only seem to accept null, maybe add an additional type check?

    }

    /**
     * Get event pages that may show.
     *
     * @param Event $event
     *
     * @return array
     */
    public function getEventMenuPages(Event $event)
    {
        /** TODO замінити на репозіторій */
        $pages = [];
        /** @var EventPage $page */
        foreach ($event->getPages() as $page) {
            if ($page->isShowInMenu()) {
                $pages[] = $page;
            }
        }

        return $pages;
    }
}