MageScan\Request

Complexity

Total Complexity

17

Size/Duplication

Total Lines	140
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	8
Bugs	0	Features	1

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	12	2
A	getUrl()	0	4	1
A	get()	0	4	2
A	getMany()	0	8	2
A	post()	0	4	1
A	parseHeader()	0	13	3
B	findMatchInResponse()	0	12	6

<?php
/**
 * Mage Scan
 *
 * PHP version 5
 *
 * @category  MageScan
 * @package   MageScan
 * @author    Steve Robbins <steve@steverobbins.com>
 * @copyright 2015 Steve Robbins
 * @license   http://creativecommons.org/licenses/by/4.0/ CC BY 4.0
 * @link      https://github.com/steverobbins/magescan
 */

namespace MageScan;

use GuzzleHttp\Client;
use GuzzleHttp\Promise;

/**
 * Make a cURL request to a url
 *
 * @category  MageScan
 * @package   MageScan
 * @author    Steve Robbins <steve@steverobbins.com>
 * @copyright 2015 Steve Robbins
 * @license   http://creativecommons.org/licenses/by/4.0/ CC BY 4.0
 * @link      https://github.com/steverobbins/magescan
 */
class Request
{
    const REQUEST_TIMEOUT = 15.0;

    /**
     * If true, SSL does not have to be verified
     *
     * @var boolean
     */
    protected $insecure = false;

    /**
     * The base URL of the Magento application
     *
     * @var string
     */
    protected $url;

    /**
     * Client cache
     *
     * @var GuzzleHttp\Client
     */
    protected $client;

    /**
     * Initialize request object
     *
     * @param string  $baseUri
     * @param boolean $verify
     */
    public function __construct($baseUri = false, $verify = true)
    {
        $this->url = $baseUri;

It seems like $baseUri can also be of type false. However, the property $url is declared as type string. Maybe add an additional type check?

        $params = [
            'verify'   => $verify,
            'http_errors' => false
        ];
        if ($this->url !== false) {
            $params['base_uri'] = $this->url;
        }
        $this->client = new Client($params);

It seems like new \GuzzleHttp\Client($params) of type object<GuzzleHttp\Client> is incompatible with the declared type object<MageScan\GuzzleHttp\Client> of property $client.

    }

    /**
     * Get the base url of this request
     *
     * @return string
     */
    public function getUrl()
    {
        return $this->url;
    }

    /**
     * Get a path
     *
     * @param string|boolean $path
     * @param array          $params
     *
     * @return GuzzleHttp\Psr7\Response
     */
    public function get($path = false, array $params = [])
    {
        return $this->client->get($path ? '/' . $path : null, $params);
    }

    /**
     * Get many paths asyncronously
     *
     * @param string[] $paths
     * @param array    $params
     *
     * @return GuzzleHttp\Psr7\Response[]
     */
    public function getMany($paths, array $params = [])
    {
        $promises = [];
        foreach ($paths as $path) {
            $promises[$path] = $this->client->getAsync('/' . $path, $params);
        }
        return Promise\unwrap($promises);
    }

    /**
     * Post to a path
     *
     * @param string $path
     * @param array  $params
     *
     * @return GuzzleHttp\Psr7\Response
     */
    public function post($path, array $params = [])
    {
        return $this->client->post('/' . $path, $params);
    }

    /**
     * Manipulate header data into a parsable format
     *
     * @param string $rawData
     *
     * @return array
     */
    public function parseHeader($rawData)
    {
        $data = [];
        foreach (explode("\n", trim($rawData)) as $line) {
            $bits = explode(': ', $line);
            if (count($bits) > 1) {
                $key = $bits[0];
                unset($bits[0]);
                $data[$key] = trim(implode(': ', $bits));
            }
        }
        return $data;
    }

    /**
     * Parse out the count from the response
     *
     * @param string  $response
     * @param string  $pattern
     * @param boolean $returnAll
     *
     * @return string|array|boolean
     */
    public function findMatchInResponse($response, $pattern, $returnAll = false)
    {
        if (empty($response)) {
            return false;
        }
        if (preg_match($pattern, $response, $match)
            && (isset($match[1]) || $returnAll)
        ) {
            return $returnAll ? $match : $match[1];
        }
        return false;
    }
}