Stevenmaguire\OAuth2\Client\Tool\ProviderRedirectTrait

Complexity

Total Complexity

9

Size/Duplication

Total Lines	77
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getRedirectLimit()	0	4	1
B	sendRequest()	0	33	6
A	setRedirectLimit()	0	10	2

<?php

namespace Stevenmaguire\OAuth2\Client\Tool;

use GuzzleHttp\Exception\BadResponseException;
use GuzzleHttp\Psr7\Uri;
use InvalidArgumentException;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;

trait ProviderRedirectTrait
{
    /**
     * Maximum number of times to follow provider initiated redirects
     *
     * @var integer
     */
    protected $redirectLimit = 2;

    /**
     * Retrieves current redirect limit.
     *
     * @return integer
     */
    public function getRedirectLimit()
    {
        return $this->redirectLimit;
    }

    /**
     * Sends a request instance and returns a response instance.
     *
     * @param  RequestInterface $request
     * @return ResponseInterface
     */
    protected function sendRequest(RequestInterface $request)
    {
        $attempts = 0;

        $requestOptions = [
            'allow_redirects' => false
        ];

        $isRedirect = function (ResponseInterface $response) {
            $statusCode = $response->getStatusCode();

            return $statusCode > 300 && $statusCode < 400 && $response->hasHeader('Location');
        };

        try {
            while ($attempts < $this->redirectLimit) {
                $attempts++;
                $response = $this->getHttpClient()->send($request, $requestOptions);

It seems like getHttpClient() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                $statusCode = $response->getStatusCode();

$statusCode is not used, you could remove the assignment.

                if ($isRedirect($response)) {
                    $redirectUrl = new Uri($response->getHeader('Location')[0]);
                    $request = $request->withUri($redirectUrl);
                } else {
                    break;
                }
            }
        } catch (BadResponseException $e) {
            $response = $e->getResponse();
        }

        return $response;

The variable $response does not seem to be defined for all execution paths leading up to this point.

    }

    /**
     * Updates the redirect limit.
     *
     * @param integer $limit
     * @return League\OAuth2\Client\Provider\AbstractProvider
     * @throws InvalidArgumentException
     */
    public function setRedirectLimit($limit)
    {
        if (!is_numeric($limit)) {
            throw new InvalidArgumentException('setRedirectLimit function only accepts numeric values.');
        }

        $this->redirectLimit = $limit;

It seems like $limit can also be of type double or string. However, the property $redirectLimit is declared as type integer. Maybe add an additional type check?

        return $this;
    }
}