Microsoft::checkResponse() - Code Metrics - Inspection of "Fix for Resource Owner Details URL and parsing" - stevenmaguire/oauth2-microsoft - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#21)

unknown

created 2020-05-14 12:59 UTC

Microsoft::checkResponse() A

↳ Parent: Microsoft

Complexity

Conditions	3
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	8
cts	8
cp	1
rs	9.9332
c	0
b	0
f	0
cc	3
nc	2
nop	2
crap	3

<?php namespace Stevenmaguire\OAuth2\Client\Provider;

use GuzzleHttp\Psr7\Uri;
use League\OAuth2\Client\Provider\AbstractProvider;
use League\OAuth2\Client\Provider\Exception\IdentityProviderException;
use League\OAuth2\Client\Token\AccessToken;
use League\OAuth2\Client\Tool\BearerAuthorizationTrait;
use Psr\Http\Message\ResponseInterface;

class Microsoft extends AbstractProvider
{
    use BearerAuthorizationTrait;

    /**
     * Default scopes
     *
     * @var array
     */
    public $defaultScopes = ['wl.basic', 'wl.emails'];

    /**
     * Base url for authorization.
     *
     * @var string
     */
    protected $urlAuthorize = 'https://login.live.com/oauth20_authorize.srf';

    /**
     * Base url for access token.
     *
     * @var string
     */
    protected $urlAccessToken = 'https://login.live.com/oauth20_token.srf';

    /**
     * Base url for resource owner.
     *
     * @var string
     */
    protected $urlResourceOwnerDetails = 'https://graph.microsoft.com/v1.0/me';

    /**
     * Get authorization url to begin OAuth flow
     *
     * @return string
     */
    public function getBaseAuthorizationUrl()
    {
        return $this->urlAuthorize;
    }

    /**
     * Get access token url to retrieve token
     *
     * @return string
     */
    public function getBaseAccessTokenUrl(array $params)
    {
        return $this->urlAccessToken;
    }

    /**
     * Get default scopes
     *
     * @return array
     */
    protected function getDefaultScopes()
    {
        return $this->defaultScopes;
    }

    /**
     * Check a provider response for errors.
     *
     * @throws IdentityProviderException
     * @param  ResponseInterface $response
     * @return void
     */
    protected function checkResponse(ResponseInterface $response, $data)
    {
        if (isset($data['error'])) {
            throw new IdentityProviderException(
                (isset($data['error']['message']) ? $data['error']['message'] : $response->getReasonPhrase()),
                $response->getStatusCode(),
                $response
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            );
        }
    }

    /**
     * Generate a user object from a successful user details request.
     *
     * @param array $response
     * @param AccessToken $token
     * @return MicrosoftResourceOwner
     */
    protected function createResourceOwner(array $response, AccessToken $token)
    {
        return new MicrosoftResourceOwner($response);
    }

    /**
     * Get provider url to fetch user details
     *
     * @param  AccessToken $token
     *
     * @return string
     */
    public function getResourceOwnerDetailsUrl(AccessToken $token)
    {
        $uri = new Uri($this->urlResourceOwnerDetails);

        return (string) Uri::withQueryValue($uri, 'access_token', (string) $token);
    }
}


1		<?php namespace Stevenmaguire\OAuth2\Client\Provider;
2
3		use GuzzleHttp\Psr7\Uri;
4		use League\OAuth2\Client\Provider\AbstractProvider;
5		use League\OAuth2\Client\Provider\Exception\IdentityProviderException;
6		use League\OAuth2\Client\Token\AccessToken;
7		use League\OAuth2\Client\Tool\BearerAuthorizationTrait;
8		use Psr\Http\Message\ResponseInterface;
9
10		class Microsoft extends AbstractProvider
11		{
12		use BearerAuthorizationTrait;
13
14		/**
15		* Default scopes
16		*
17		* @var array
18		*/
19		public $defaultScopes = ['wl.basic', 'wl.emails'];
20
21		/**
22		* Base url for authorization.
23		*
24		* @var string
25		*/
26		protected $urlAuthorize = 'https://login.live.com/oauth20_authorize.srf';
27
28		/**
29		* Base url for access token.
30		*
31		* @var string
32		*/
33		protected $urlAccessToken = 'https://login.live.com/oauth20_token.srf';
34
35		/**
36		* Base url for resource owner.
37		*
38		* @var string
39		*/
40		protected $urlResourceOwnerDetails = 'https://graph.microsoft.com/v1.0/me';
41
42		/**
43		* Get authorization url to begin OAuth flow
44		*
45		* @return string
46		*/
47	12	public function getBaseAuthorizationUrl()
48		{
49	12	return $this->urlAuthorize;
50		}
51
52		/**
53		* Get access token url to retrieve token
54		*
55		* @return string
56		*/
57	15	public function getBaseAccessTokenUrl(array $params)
58		{
59	15	return $this->urlAccessToken;
60		}
61
62		/**
63		* Get default scopes
64		*
65		* @return array
66		*/
67	9	protected function getDefaultScopes()
68		{
69	9	return $this->defaultScopes;
70		}
71
72		/**
73		* Check a provider response for errors.
74		*
75		* @throws IdentityProviderException
76		* @param ResponseInterface $response
77		* @return void
78		*/
79	9	protected function checkResponse(ResponseInterface $response, $data)
80		{
81	9	if (isset($data['error'])) {
82	3	throw new IdentityProviderException(
83	3	(isset($data['error']['message']) ? $data['error']['message'] : $response->getReasonPhrase()),
84	3	$response->getStatusCode(),
85	2	$response
		0 ignored issues – show Documentation introduced 2017-01-26 01:58 UTC by Report Bug Copy Issue Report `$response` is of type `object<Psr\Http\Message\ResponseInterface>`, but the function expects a `array\|string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
86	1	);
87		}
88	6	}
89
90		/**
91		* Generate a user object from a successful user details request.
92		*
93		* @param array $response
94		* @param AccessToken $token
95		* @return MicrosoftResourceOwner
96		*/
97		protected function createResourceOwner(array $response, AccessToken $token)
98		{
99		return new MicrosoftResourceOwner($response);
100		}
101
102		/**
103		* Get provider url to fetch user details
104		*
105		* @param AccessToken $token
106		*
107		* @return string
108		*/
109	6	public function getResourceOwnerDetailsUrl(AccessToken $token)
110		{
111	6	$uri = new Uri($this->urlResourceOwnerDetails);
112
113	6	return (string) Uri::withQueryValue($uri, 'access_token', (string) $token);
114		}
115		}
116

stevenmaguire / oauth2-microsoft

Pull Request — master (#21)

Microsoft::checkResponse() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like