Issues in DollarExpansion.php (master) - Issues in master - stenin-nikita/PHP-Yacc - Measure and Improve Code Quality continuously with Scrutinizer

Issues (49)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Yacc/Macro/DollarExpansion.php (6 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * This file is part of PHP-Yacc package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace PhpYacc\Yacc\Macro;

use PhpYacc\Exception\ParseException;
use PhpYacc\Grammar\Context;
use PhpYacc\Yacc\MacroAbstract;
use PhpYacc\Yacc\Token;

/**
 * Class DollarExpansion.
 */
class DollarExpansion extends MacroAbstract
{
    const SEMVAL_LHS_TYPED = 1;
    const SEMVAL_LHS_UNTYPED = 2;
    const SEMVAL_RHS_TYPED = 3;
    const SEMVAL_RHS_UNTYPED = 4;

    /**
     * @param Context   $ctx
     * @param array     $symbols
     * @param \Iterator $tokens
     * @param int       $n
     * @param array     $attribute
     *
     * @throws ParseException
     * @throws \PhpYacc\Exception\LogicException
     *
     * @return \Generator
     */
    public function apply(Context $ctx, array $symbols, \Iterator $tokens, int $n, array $attribute): \Generator
    {
        $type = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        for ($tokens->rewind(); $tokens->valid(); $tokens->next()) {
            /** @var Token $token */
            $token = $tokens->current();
            switch ($token->getType()) {
                case Token::T_NAME:
                    $type = null;
                    $v = -1;

                    for ($i = 0; $i <= $n; $i++) {
                        if ('$'.$symbols[$i]->name === $token->getValue()) {
                            if ($v < 0) {
                                $v = $i;
                            } else {
                                throw new ParseException("Ambiguous semantic value reference for $token");
                            }
                        }
                    }

                    if ($v < 0) {
                        for ($i = 0; $i <= $n; $i++) {
                            if ($attribute[$i] === $token->getValue()) {
                                $v = $i;
                                break;
                            }
                        }

                        if ($token->getValue() === $attribute[$n + 1]) {
                            $v = 0;
                        }
                    }

                    if ($v >= 0) {
                        $token = new Token(
                            $v === 0 ? Token::T_DOLLAR : 0,
                            $token->getValue(),
                            $token->getLine(),
                            $token->getFilename()
                        );
                        goto semval;
                    }

                    break;

                case Token::T_DOLLAR:
                    $type = null;
                    $token = self::next($tokens);
                    if ($token->getValue()[0] === '<') {
                        $token = self::next($tokens);
                        if ($token->getType() !== Token::T_NAME) {
                            throw ParseException::unexpected($token, Token::T_NAME);
                        }
                        $type = $ctx->intern($token->getValue());
                        $dump = self::next($tokens);
                        if ($dump->getValue()[0] !== '>') {
                            throw ParseException::unexpected($dump, '>');
                        }
                        $token = self::next($tokens);
                    }

                    if ($token->getType() === Token::T_DOLLAR) {
                        $v = 0;
                    } elseif ($token->getValue()[0] === '-') {
                        $token = self::next($tokens);
                        if ($token->getType() !== Token::T_NUMBER) {
                            throw ParseException::unexpected($token, Token::T_NUMBER);
                        }
                        $v = -1 * ((int) $token->getValue());
                    } else {
                        if ($token->getType() !== Token::T_NUMBER) {
                            throw new \RuntimeException('Number expected');
                        }
                        $v = (int) $token->getValue();
                        if ($v > $n) {
                            throw new \RuntimeException('N is too big');
                        }
                    }
semval:
                    if ($type === null) {
                        $type = $symbols[$v]->type;
                    }

                    if ($type === null /* && $ctx->unioned */ && false) {

                        throw new ParseException('Type not defined for '.$symbols[$v]->name);
                    }

                    foreach ($this->parseDollar($ctx, $token, $v, $n, $type ? $type->name : null) as $token) {
                        yield $token;
                    }

                    continue 2;
            }

            yield $token;
        }
    }

    /**
     * @param Context     $ctx
     * @param Token       $token
     * @param int         $nth
     * @param int         $len
     * @param string|null $type
     *
     * @return array
     */
    protected function parseDollar(Context $ctx, Token $token, int $nth, int $len, string $type = null): array
    {
        if ($token->getValue() === '$') {
            if ($type) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                $mp = $ctx->macros[self::SEMVAL_LHS_TYPED];
            } else {
                $mp = $ctx->macros[self::SEMVAL_LHS_UNTYPED];
            }
        } else {

            if ($type) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                $mp = $ctx->macros[self::SEMVAL_RHS_TYPED];
            } else {
                $mp = $ctx->macros[self::SEMVAL_RHS_UNTYPED];
            }
        }

        $result = '';
        for ($i = 0; $i < \mb_strlen($mp); $i++) {
            if ($mp[$i] === '%') {
                $i++;
                switch ($mp[$i]) {
                    case 'n':
                        $result .= \sprintf('%d', $nth);
                        break;
                    case 'l':
                        $result .= \sprintf('%d', $len);
                        break;
                    case 't':
                        $result .= $type;
                        break;
                    default:
                        $result .= $mp[$i];
                }
            } else {
                $result .= $mp[$i];
            }
        }

        return $this->parse($result, $token->getLine(), $token->getFilename());
    }
}


1		<?php
2		/**
3		* This file is part of PHP-Yacc package.
4		*
5		* For the full copyright and license information, please view the LICENSE
6		* file that was distributed with this source code.
7		*/
8		declare(strict_types=1);
9
10		namespace PhpYacc\Yacc\Macro;
11
12		use PhpYacc\Exception\ParseException;
13		use PhpYacc\Grammar\Context;
14		use PhpYacc\Yacc\MacroAbstract;
15		use PhpYacc\Yacc\Token;
16
17		/**
18		* Class DollarExpansion.
19		*/
20		class DollarExpansion extends MacroAbstract
21		{
22		const SEMVAL_LHS_TYPED = 1;
23		const SEMVAL_LHS_UNTYPED = 2;
24		const SEMVAL_RHS_TYPED = 3;
25		const SEMVAL_RHS_UNTYPED = 4;
26
27		/**
28		* @param Context $ctx
29		* @param array $symbols
30		* @param \Iterator $tokens
31		* @param int $n
32		* @param array $attribute
33		*
34		* @throws ParseException
35		* @throws \PhpYacc\Exception\LogicException
36		*
37		* @return \Generator
38		*/
39		public function apply(Context $ctx, array $symbols, \Iterator $tokens, int $n, array $attribute): \Generator
40		{
41		$type = null;
		0 ignored issues – show Unused Code introduced 2017-12-27 06:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$type` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
42		for ($tokens->rewind(); $tokens->valid(); $tokens->next()) {
43		/** @var Token $token */
44		$token = $tokens->current();
45		switch ($token->getType()) {
46		case Token::T_NAME:
47		$type = null;
48		$v = -1;
49
50		for ($i = 0; $i <= $n; $i++) {
51		if ('$'.$symbols[$i]->name === $token->getValue()) {
52		if ($v < 0) {
53		$v = $i;
54		} else {
55		throw new ParseException("Ambiguous semantic value reference for $token");
56		}
57		}
58		}
59
60		if ($v < 0) {
61		for ($i = 0; $i <= $n; $i++) {
62		if ($attribute[$i] === $token->getValue()) {
63		$v = $i;
64		break;
65		}
66		}
67
68		if ($token->getValue() === $attribute[$n + 1]) {
69		$v = 0;
70		}
71		}
72
73		if ($v >= 0) {
74		$token = new Token(
75		$v === 0 ? Token::T_DOLLAR : 0,
76		$token->getValue(),
77		$token->getLine(),
78		$token->getFilename()
79		);
80		goto semval;
81		}
82
83		break;
84
85		case Token::T_DOLLAR:
86		$type = null;
87		$token = self::next($tokens);
88		if ($token->getValue()[0] === '<') {
89		$token = self::next($tokens);
90		if ($token->getType() !== Token::T_NAME) {
91		throw ParseException::unexpected($token, Token::T_NAME);
92		}
93		$type = $ctx->intern($token->getValue());
94		$dump = self::next($tokens);
95		if ($dump->getValue()[0] !== '>') {
96		throw ParseException::unexpected($dump, '>');
97		}
98		$token = self::next($tokens);
99		}
100
101		if ($token->getType() === Token::T_DOLLAR) {
102		$v = 0;
103		} elseif ($token->getValue()[0] === '-') {
104		$token = self::next($tokens);
105		if ($token->getType() !== Token::T_NUMBER) {
106		throw ParseException::unexpected($token, Token::T_NUMBER);
107		}
108		$v = -1 * ((int) $token->getValue());
109		} else {
110		if ($token->getType() !== Token::T_NUMBER) {
111		throw new \RuntimeException('Number expected');
112		}
113		$v = (int) $token->getValue();
114		if ($v > $n) {
115		throw new \RuntimeException('N is too big');
116		}
117		}
118		semval:
119		if ($type === null) {
120		$type = $symbols[$v]->type;
121		}
122
123		if ($type === null /* && $ctx->unioned */ && false) {
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-12-27 06:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
124		throw new ParseException('Type not defined for '.$symbols[$v]->name);
125		}
126
127		foreach ($this->parseDollar($ctx, $token, $v, $n, $type ? $type->name : null) as $token) {
128		yield $token;
129		}
130
131		continue 2;
132		}
133
134		yield $token;
135		}
136		}
137
138		/**
139		* @param Context $ctx
140		* @param Token $token
141		* @param int $nth
142		* @param int $len
143		* @param string\|null $type
144		*
145		* @return array
146		*/
147		protected function parseDollar(Context $ctx, Token $token, int $nth, int $len, string $type = null): array
148		{
149		if ($token->getValue() === '$') {
150	View Code Duplication	if ($type) {
		0 ignored issues – show Bug Best Practice introduced 2017-12-27 06:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$type` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history... Duplication introduced 2017-12-27 06:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
151		$mp = $ctx->macros[self::SEMVAL_LHS_TYPED];
152		} else {
153		$mp = $ctx->macros[self::SEMVAL_LHS_UNTYPED];
154		}
155	View Code Duplication	} else {
		0 ignored issues – show Duplication introduced 2017-12-27 06:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
156		if ($type) {
		0 ignored issues – show Bug Best Practice introduced 2017-12-27 06:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$type` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
157		$mp = $ctx->macros[self::SEMVAL_RHS_TYPED];
158		} else {
159		$mp = $ctx->macros[self::SEMVAL_RHS_UNTYPED];
160		}
161		}
162
163		$result = '';
164		for ($i = 0; $i < \mb_strlen($mp); $i++) {
165		if ($mp[$i] === '%') {
166		$i++;
167		switch ($mp[$i]) {
168		case 'n':
169		$result .= \sprintf('%d', $nth);
170		break;
171		case 'l':
172		$result .= \sprintf('%d', $len);
173		break;
174		case 't':
175		$result .= $type;
176		break;
177		default:
178		$result .= $mp[$i];
179		}
180		} else {
181		$result .= $mp[$i];
182		}
183		}
184
185		return $this->parse($result, $token->getLine(), $token->getFilename());
186		}
187		}
188

stenin-nikita / PHP-Yacc

Issues (49)

Security Analysis no request data

src/Yacc/Macro/DollarExpansion.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like