PhpYacc\Lalr\Conflict

Complexity

Total Complexity

6

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	isShiftReduce()	0	4	1
A	isReduceReduce()	0	4	1
A	symbol()	0	4	1
A	next()	0	4	1
A	setNext()	0	4	1

<?php
/**
 * This file is part of PHP-Yacc package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace PhpYacc\Lalr;

use PhpYacc\Grammar\Symbol;

/**
 * Class Conflict.
 */
abstract class Conflict
{
    /**
     * @var null|Conflict
     */
    protected $next;

    /**
     * @var Symbol
     */
    protected $symbol;

    /**
     * Conflict constructor.
     *
     * @param Symbol        $symbol
     * @param Conflict|null $next
     */
    protected function __construct(Symbol $symbol, self $next = null)
    {
        $this->next = $next;

It seems like $next can also be of type object<self>. However, the property $next is declared as type null|object<PhpYacc\Lalr\Conflict>. Maybe add an additional type check?

        $this->symbol = $symbol;
    }

    /**
     * @return bool
     */
    public function isShiftReduce(): bool
    {
        return false;
    }

    /**
     * @return bool
     */
    public function isReduceReduce(): bool
    {
        return false;
    }

    /**
     * @return Symbol
     */
    public function symbol(): Symbol
    {
        return $this->symbol;
    }

    /**
     * @return null|Conflict
     */
    public function next()
    {
        return $this->next;
    }

    /**
     * @param Conflict|null $next
     */
    public function setNext(self $next = null)
    {
        $this->next = $next;

It seems like $next can also be of type object<self>. However, the property $next is declared as type null|object<PhpYacc\Lalr\Conflict>. Maybe add an additional type check?

    }
}