EcbClient::getExchangeRates() - Code Metrics - Inspection of "Update EcbClient.php" - steffenbrand/curr-curr - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ce7cc4...e46035 )

by Steffen

created 2016-11-04 11:59 UTC

EcbClient::getExchangeRates() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	0

<?php

namespace SteffenBrand\CurrCurr\Client;

use Exception;
use GuzzleHttp\Client;
use SteffenBrand\CurrCurr\Exception\ExchangeRatesRequestFailedException;
use SteffenBrand\CurrCurr\Mapper\ExchangeRatesMapper;
use SteffenBrand\CurrCurr\Model\ExchangeRate;

class EcbClient implements EcbClientInterface
{

    /**
     * @const string
     */
    const HTTP_GET = 'GET';

    /**
     * @const string
     */
    const DEFAULT_EXCHANGE_RATES_URL = 'https://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml';

    /**
     * @var Client
     */
    private $client;

    /**
     * @var string
     */
    private $exchangeRatesUrl;

    /**
     * @param string $exchangeRatesUrl
     */
    public function __construct(string $exchangeRatesUrl = null)
    {
        if (null === $exchangeRatesUrl) {
            $this->exchangeRatesUrl = self::DEFAULT_EXCHANGE_RATES_URL
        } else {

            $this->exchangeRatesUrl = $exchangeRatesUrl;   
        }
        $this->client = new Client();
    }

    /**
     * @throws ExchangeRatesRequestFailedException
     * @return ExchangeRate[]
     */
    public function getExchangeRates(): array
    {
        try {
            $response = $this->client->request(self::HTTP_GET, $this->exchangeRatesUrl);
        } catch (Exception $e) {
            throw new ExchangeRatesRequestFailedException($e);
        }

        $mapper = new ExchangeRatesMapper();
        return $mapper->map($response);
    }

}


1			<?php
2
3			namespace SteffenBrand\CurrCurr\Client;
4
5			use Exception;
6			use GuzzleHttp\Client;
7			use SteffenBrand\CurrCurr\Exception\ExchangeRatesRequestFailedException;
8			use SteffenBrand\CurrCurr\Mapper\ExchangeRatesMapper;
9			use SteffenBrand\CurrCurr\Model\ExchangeRate;
10
11			class EcbClient implements EcbClientInterface
12			{
13
14			/**
15			* @const string
16			*/
17			const HTTP_GET = 'GET';
18
19			/**
20			* @const string
21			*/
22			const DEFAULT_EXCHANGE_RATES_URL = 'https://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml';
23
24			/**
25			* @var Client
26			*/
27			private $client;
28
29			/**
30			* @var string
31			*/
32			private $exchangeRatesUrl;
33
34			/**
35			* @param string $exchangeRatesUrl
36			*/
37			public function __construct(string $exchangeRatesUrl = null)
38			{
39			if (null === $exchangeRatesUrl) {
40			$this->exchangeRatesUrl = self::DEFAULT_EXCHANGE_RATES_URL
41			} else {
			0 ignored issues – show Bug introduced 2016-11-04 12:02 UTC by Report Bug Copy Issue Report This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected '}' Loading history...
42			$this->exchangeRatesUrl = $exchangeRatesUrl;
43			}
44			$this->client = new Client();
45			}
46
47			/**
48			* @throws ExchangeRatesRequestFailedException
49			* @return ExchangeRate[]
50			*/
51			public function getExchangeRates(): array
52			{
53			try {
54			$response = $this->client->request(self::HTTP_GET, $this->exchangeRatesUrl);
55			} catch (Exception $e) {
56			throw new ExchangeRatesRequestFailedException($e);
57			}
58
59			$mapper = new ExchangeRatesMapper();
60			return $mapper->map($response);
61			}
62
63			}
64

steffenbrand / curr-curr

GitHub Access Token became invalid

Push — master ( ce7cc4...e46035 )

EcbClient::getExchangeRates() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like