SluggableTraitTest::testSetterDoesntCastNullToEmptyString() - Code Metrics - stefanotorresi/thorr-persistence - Measure and Improve Code Quality continuously with Scrutinizer

testSetterDoesntCastNullToEmptyString() A
last analyzed 2016-10-29 13:07 UTC

↳ Parent: SluggableTraitTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
c	0
b	0
f	0
rs	9.4285
cc	1
eloc	7
nc	1
nop	0

<?php
/**
 * @author Stefano Torresi (http://stefanotorresi.it)
 * @license See the file LICENSE.txt for copying permission.
 * ************************************************
 */

namespace Thorr\Persistence\Test\Entity;

use PHPUnit_Framework_MockObject_MockObject as MockObject;
use PHPUnit_Framework_TestCase as TestCase;
use Thorr\Persistence\Entity\SluggableTrait;

class SluggableTraitTest extends TestCase
{
    public function testSetterDoesntCastNullToEmptyString()
    {
        /** @var SluggableTrait|MockObject $sluggable */
        $sluggable = $this->getMockForTrait(SluggableTrait::class);

        $this->assertNull($sluggable->getSlug());

        $sluggable->setSlug(false);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertSame('', $sluggable->getSlug());

        $sluggable->setSlug(null);
        $this->assertNull($sluggable->getSlug());
    }
}


1			<?php
2			/**
3			* @author Stefano Torresi (http://stefanotorresi.it)
4			* @license See the file LICENSE.txt for copying permission.
5			* ************************************************
6			*/
7
8			namespace Thorr\Persistence\Test\Entity;
9
10			use PHPUnit_Framework_MockObject_MockObject as MockObject;
11			use PHPUnit_Framework_TestCase as TestCase;
12			use Thorr\Persistence\Entity\SluggableTrait;
13
14			class SluggableTraitTest extends TestCase
15			{
16			public function testSetterDoesntCastNullToEmptyString()
17			{
18			/** @var SluggableTrait\|MockObject $sluggable */
19			$sluggable = $this->getMockForTrait(SluggableTrait::class);
20
21			$this->assertNull($sluggable->getSlug());
22
23			$sluggable->setSlug(false);
			0 ignored issues – show Documentation introduced 2016-01-18 20:19 UTC by Report Bug Copy Issue Report `false` is of type `boolean`, but the function expects a `string\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
24			$this->assertSame('', $sluggable->getSlug());
25
26			$sluggable->setSlug(null);
27			$this->assertNull($sluggable->getSlug());
28			}
29			}
30

stefanotorresi / thorr-persistence

testSetterDoesntCastNullToEmptyString() A last analyzed 2016-10-29 13:07 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

testSetterDoesntCastNullToEmptyString() A
last analyzed 2016-10-29 13:07 UTC