Thorr\Persistence\Validator\EntityExistsValidator

Complexity

Total Complexity

3

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	isValid()	0	12	3

<?php
/**
 * @author Stefano Torresi (http://stefanotorresi.it)
 * @license See the file LICENSE.txt for copying permission.
 * ************************************************
 */

namespace Thorr\Persistence\Validator;

class EntityExistsValidator extends AbstractEntityValidator
{
    const ERROR_ENTITY_NOT_EXISTS = 'entityNotExists';

    /**
     * @var array Message templates
     */
    protected $messageTemplates = [
        self::ERROR_ENTITY_NOT_EXISTS => 'Entity not found',
    ];

    /**
     * {@inheritdoc}
     */
    public function isValid($value)
    {
        $result = $this->findEntity($value);

        if ($result && ! in_array($result, $this->excluded)) {

The expression $result of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return true;
        }

        $this->error(static::ERROR_ENTITY_NOT_EXISTS);

        return false;
    }
}