cmd.NewResultViewCommand - Code Metrics - Inspection of "Adding result.view command" - stefanoj3/dirstalk - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( bd2e0b...bf7a11 )

by Stefano

created 2019-08-18 08:44 UTC

cmd.NewResultViewCommand A

↳ Parent: pkg/cmd/result_view.go

Complexity

Conditions

Size

Total Lines	24
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	17
nop	1
dl	0
loc	24
rs	9.55
c	0
b	0
f	0

package cmd

import (
	"io"

	"github.com/pkg/errors"
	"github.com/spf13/cobra"
	"github.com/stefanoj3/dirstalk/pkg/result"
	"github.com/stefanoj3/dirstalk/pkg/scan/summarizer/tree"
)

func NewResultViewCommand(out io.Writer) (*cobra.Command, error) {

	cmd := &cobra.Command{
		Use:   "result.view",
		Short: "Read a scan output file and render the folder tree",
		RunE:  buildResultViewCmd(out),
	}

	cmd.Flags().StringP(
		flagResultFile,
		flagResultFileShort,
		"",
		"result file to read",
	)
	err := cmd.MarkFlagFilename(flagResultFile)
	if err != nil {
		return nil, err
	}

	err = cmd.MarkFlagRequired(flagResultFile)
	if err != nil {
		return nil, err
	}

	return cmd, nil
}

func buildResultViewCmd(out io.Writer) func(cmd *cobra.Command, args []string) error {
	return func(cmd *cobra.Command, args []string) error {
		resultFilePath := cmd.Flag(flagResultFile).Value.String()

		results, err := result.LoadResultsFromFile(resultFilePath)
		if err != nil {
			return errors.Wrapf(err, "failed to load results from %s", resultFilePath)
		}

		tree.NewResultTreePrinter().Print(results, out)

		return nil
	}
}


1			package cmd
2
3			import (
4			"io"
5
6			"github.com/pkg/errors"
7			"github.com/spf13/cobra"
8			"github.com/stefanoj3/dirstalk/pkg/result"
9			"github.com/stefanoj3/dirstalk/pkg/scan/summarizer/tree"
10			)
11
12			func NewResultViewCommand(out io.Writer) (*cobra.Command, error) {
			0 ignored issues – show introduced 2019-08-17 06:15 UTC by Report Bug Copy Issue Report exported function NewResultViewCommand should have comment or be unexported Loading history...
13			cmd := &cobra.Command{
14			Use: "result.view",
15			Short: "Read a scan output file and render the folder tree",
16			RunE: buildResultViewCmd(out),
17			}
18
19			cmd.Flags().StringP(
20			flagResultFile,
21			flagResultFileShort,
22			"",
23			"result file to read",
24			)
25			err := cmd.MarkFlagFilename(flagResultFile)
26			if err != nil {
27			return nil, err
28			}
29
30			err = cmd.MarkFlagRequired(flagResultFile)
31			if err != nil {
32			return nil, err
33			}
34
35			return cmd, nil
36			}
37
38			func buildResultViewCmd(out io.Writer) func(cmd *cobra.Command, args []string) error {
39			return func(cmd *cobra.Command, args []string) error {
40			resultFilePath := cmd.Flag(flagResultFile).Value.String()
41
42			results, err := result.LoadResultsFromFile(resultFilePath)
43			if err != nil {
44			return errors.Wrapf(err, "failed to load results from %s", resultFilePath)
45			}
46
47			tree.NewResultTreePrinter().Print(results, out)
48
49			return nil
50			}
51			}
52

stefanoj3 / dirstalk

Push — master ( bd2e0b...bf7a11 )

cmd.NewResultViewCommand A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like