producer.*DictionaryProducer.Produce - Code Metrics - Inspection of "Refactoring target creation and result handling in..." - stefanoj3/dirstalk - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#52)

by Stefano

created 2019-07-09 15:14 UTC

producer.*DictionaryProducer.Produce A

↳ Parent: pkg/scan/producer/dictionary.go

Complexity

Conditions

Size

Total Lines	18
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	11
nop	0
dl	0
loc	18
rs	9.85
c	0
b	0
f	0

package producer

import (
	"github.com/stefanoj3/dirstalk/pkg/scan"
)

func NewDictionaryProducer(

	methods []string,
	dictionary []string,
	depth int,
) *DictionaryProducer {
	return &DictionaryProducer{
		methods:    methods,
		dictionary: dictionary,
		depth:      depth,
	}

}

type DictionaryProducer struct {

	methods    []string
	dictionary []string
	depth      int
}

func (p *DictionaryProducer) Produce() <-chan scan.Target {

	targets := make(chan scan.Target, 10)

	go func() {
		defer close(targets)

		for _, entry := range p.dictionary {
			for _, method := range p.methods {
				targets <- scan.Target{
					Path:   entry,
					Method: method,
					Depth:  p.depth,
				}
			}
		}
	}()

	return targets
}


1			package producer
2
3			import (
4			"github.com/stefanoj3/dirstalk/pkg/scan"
5			)
6
7			func NewDictionaryProducer(
			0 ignored issues – show introduced 2019-07-09 14:55 UTC by Report Bug Copy Issue Report exported function NewDictionaryProducer should have comment or be unexported Loading history...
8			methods []string,
9			dictionary []string,
10			depth int,
11			) *DictionaryProducer {
12			return &DictionaryProducer{
13			methods: methods,
14			dictionary: dictionary,
15			depth: depth,
16			}
17
18			}
19
20			type DictionaryProducer struct {
			0 ignored issues – show introduced 2019-07-09 14:55 UTC by Report Bug Copy Issue Report exported type DictionaryProducer should have comment or be unexported Loading history...
21			methods []string
22			dictionary []string
23			depth int
24			}
25
26			func (p *DictionaryProducer) Produce() <-chan scan.Target {
			0 ignored issues – show introduced 2019-07-09 14:55 UTC by Report Bug Copy Issue Report exported method DictionaryProducer.Produce should have comment or be unexported Loading history...
27			targets := make(chan scan.Target, 10)
28
29			go func() {
30			defer close(targets)
31
32			for _, entry := range p.dictionary {
33			for _, method := range p.methods {
34			targets <- scan.Target{
35			Path: entry,
36			Method: method,
37			Depth: p.depth,
38			}
39			}
40			}
41			}()
42
43			return targets
44			}
45

stefanoj3 / dirstalk

Pull Request — master (#52)

producer.*DictionaryProducer.Produce A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like