UniqueObjectValidator::compare() - Code Metrics - Inspection of "Add UniqueObject validator" - steevanb/symfony-validator-constraints - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 575d8d...afd64c )

by Steevan

created 2016-08-23 14:49 UTC

UniqueObjectValidator::compare() C

↳ Parent: UniqueObjectValidator

Complexity

Conditions	11
Paths	11

Size

Total Lines	43
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	43
rs	5.2653
cc	11
eloc	29
nc	11
nop	2

How to fix Complexity

<?php

namespace steevanb\SymfonyValidatorConstraints\Constraints;

use Symfony\Component\Validator\Constraint;
use Symfony\Component\Validator\ConstraintValidator;

class UniqueObjectValidator extends ConstraintValidator
{
    /** @var array */
    protected $traversablesValues = [];

    /**
     * @param mixed $traversable
     * @param UniqueObject $constraint
     */
    public function validate($traversable, Constraint $constraint)
    {
        $this
            ->assertIsTraversable($traversable)
            ->defineTraversablesValues($traversable, $constraint);


        foreach ($traversable as $data) {
            $this->compare($data, $constraint);

        }
    }

    /**
     * @param mixed $data
     * @throws \Exception
     * @return $this
     */
    protected function assertIsTraversable($data)
    {
        if (is_array($data) === false && $data instanceof \Traversable === false) {
            throw new \Exception(gettype($data) . ' is not iterable.');
        }

        return $this;
    }

    /**
     * @param array|\Traversable $traversable
     * @param UniqueObject $uniqueObject
     * @return $this
     */
    protected function defineTraversablesValues($traversable, UniqueObject $uniqueObject)
    {
        foreach ($traversable as $data) {
            $traversableHash = spl_object_hash($data);
            $this->traversablesValues[$traversableHash] = ['properties' => [], 'getters' => []];

            foreach ($uniqueObject->getProperties() as $property) {
                $this->traversablesValues[$traversableHash]['properties'][$property] =
                    $this->getTraversableValue($data->$property);
            }

            foreach ($uniqueObject->getGetters() as $getter) {
                $this->traversablesValues[$traversableHash]['getters'][$getter] =
                    $this->getTraversableValue($data->$getter());
            }
        }

        return $this;
    }

    /**
     * @param mixed $value
     * @return string
     */
    protected function getTraversableValue($value)
    {
        return (is_object($value)) ? spl_object_hash($value) : $value;
    }

    /**
     * @param mixed $data
     * @param UniqueObject $uniqueObject
     */
    protected function compare($data, UniqueObject $uniqueObject)
    {
        static $alreadyTested = [];
        if (in_array($uniqueObject->getUniqid(), $alreadyTested)) {
            return;
        }

        $dataHash = spl_object_hash($data);
        $dataValues = $this->traversablesValues[$dataHash];
        foreach ($this->traversablesValues as $objectHash => $values) {
            if (
                $objectHash === $dataHash
                || (
                    count($values['properties']) !== count($dataValues['properties'])
                    || count($values['getters']) !== count($dataValues['getters'])
                )
            ) {
                continue;
            }

            $compare = true;
            foreach (['properties', 'getters'] as $type) {
                foreach ($dataValues[$type] as $name => $value) {
                    if (
                        array_key_exists($name, $dataValues[$type])
                        && $this->compareValues($dataValues[$type][$name], $value, $uniqueObject->getStrict()) === false
                    ) {
                        $compare = false;
                        break 2;
                    }
                }
            }
            if ($compare) {
                $this
                    ->context
                    ->buildViolation($uniqueObject->getMessage())
                    ->atPath($this->context->getPropertyName())
                    ->addViolation();
                $alreadyTested[] = $uniqueObject->getUniqid();
                break;
            }
        }
    }

    /**
     * @param mixed $value1
     * @param mixed $value2
     * @param bool $strict
     * @return bool
     */
    protected function compareValues($value1, $value2, $strict)
    {
        return ($strict) ? $value1 === $value2 : $value1 == $value2;
    }
}


1			<?php
2
3			namespace steevanb\SymfonyValidatorConstraints\Constraints;
4
5			use Symfony\Component\Validator\Constraint;
6			use Symfony\Component\Validator\ConstraintValidator;
7
8			class UniqueObjectValidator extends ConstraintValidator
9			{
10			/** @var array */
11			protected $traversablesValues = [];
12
13			/**
14			* @param mixed $traversable
15			* @param UniqueObject $constraint
16			*/
17			public function validate($traversable, Constraint $constraint)
18			{
19			$this
20			->assertIsTraversable($traversable)
21			->defineTraversablesValues($traversable, $constraint);
			1 ignored issue – show Compatibility introduced 2016-08-23 14:54 UTC by Report Bug Copy Issue Report `$constraint` of type `object<Symfony\Component\Validator\Constraint>` is not a sub-type of `object<steevanb\SymfonyV...nstraints\UniqueObject>`. It seems like you assume a child class of the class `Symfony\Component\Validator\Constraint` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
22
23			foreach ($traversable as $data) {
24			$this->compare($data, $constraint);
			1 ignored issue – show Compatibility introduced 2016-08-23 14:54 UTC by Report Bug Copy Issue Report `$constraint` of type `object<Symfony\Component\Validator\Constraint>` is not a sub-type of `object<steevanb\SymfonyV...nstraints\UniqueObject>`. It seems like you assume a child class of the class `Symfony\Component\Validator\Constraint` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
25			}
26			}
27
28			/**
29			* @param mixed $data
30			* @throws \Exception
31			* @return $this
32			*/
33			protected function assertIsTraversable($data)
34			{
35			if (is_array($data) === false && $data instanceof \Traversable === false) {
36			throw new \Exception(gettype($data) . ' is not iterable.');
37			}
38
39			return $this;
40			}
41
42			/**
43			* @param array\|\Traversable $traversable
44			* @param UniqueObject $uniqueObject
45			* @return $this
46			*/
47			protected function defineTraversablesValues($traversable, UniqueObject $uniqueObject)
48			{
49			foreach ($traversable as $data) {
50			$traversableHash = spl_object_hash($data);
51			$this->traversablesValues[$traversableHash] = ['properties' => [], 'getters' => []];
52
53			foreach ($uniqueObject->getProperties() as $property) {
54			$this->traversablesValues[$traversableHash]['properties'][$property] =
55			$this->getTraversableValue($data->$property);
56			}
57
58			foreach ($uniqueObject->getGetters() as $getter) {
59			$this->traversablesValues[$traversableHash]['getters'][$getter] =
60			$this->getTraversableValue($data->$getter());
61			}
62			}
63
64			return $this;
65			}
66
67			/**
68			* @param mixed $value
69			* @return string
70			*/
71			protected function getTraversableValue($value)
72			{
73			return (is_object($value)) ? spl_object_hash($value) : $value;
74			}
75
76			/**
77			* @param mixed $data
78			* @param UniqueObject $uniqueObject
79			*/
80			protected function compare($data, UniqueObject $uniqueObject)
81			{
82			static $alreadyTested = [];
83			if (in_array($uniqueObject->getUniqid(), $alreadyTested)) {
84			return;
85			}
86
87			$dataHash = spl_object_hash($data);
88			$dataValues = $this->traversablesValues[$dataHash];
89			foreach ($this->traversablesValues as $objectHash => $values) {
90			if (
91			$objectHash === $dataHash
92			\|\| (
93			count($values['properties']) !== count($dataValues['properties'])
94			\|\| count($values['getters']) !== count($dataValues['getters'])
95			)
96			) {
97			continue;
98			}
99
100			$compare = true;
101			foreach (['properties', 'getters'] as $type) {
102			foreach ($dataValues[$type] as $name => $value) {
103			if (
104			array_key_exists($name, $dataValues[$type])
105			&& $this->compareValues($dataValues[$type][$name], $value, $uniqueObject->getStrict()) === false
106			) {
107			$compare = false;
108			break 2;
109			}
110			}
111			}
112			if ($compare) {
113			$this
114			->context
115			->buildViolation($uniqueObject->getMessage())
116			->atPath($this->context->getPropertyName())
117			->addViolation();
118			$alreadyTested[] = $uniqueObject->getUniqid();
119			break;
120			}
121			}
122			}
123
124			/**
125			* @param mixed $value1
126			* @param mixed $value2
127			* @param bool $strict
128			* @return bool
129			*/
130			protected function compareValues($value1, $value2, $strict)
131			{
132			return ($strict) ? $value1 === $value2 : $value1 == $value2;
133			}
134			}
135

steevanb / symfony-validator-constraints

Push — master ( 575d8d...afd64c )

UniqueObjectValidator::compare() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like