OptionsResolver::setAllowedTypesAndValues() - Code Metrics - Inspection of "Add OptionsResolver::allowUnknownKeys" - steevanb/symfony-options-resolver - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#4)

by Steevan

created 2019-12-06 11:12 UTC

OptionsResolver::setAllowedTypesAndValues() A

↳ Parent: OptionsResolver

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.9
c	0
b	0
f	0
cc	2
nc	2
nop	3

<?php

declare(strict_types=1);

namespace steevanb\SymfonyOptionsResolver;

use Symfony\Component\OptionsResolver\OptionsResolver as SymfonyOptionsResolver;

class OptionsResolver extends SymfonyOptionsResolver
{
    /** @var bool */
    protected $allowUnknownKeys = false;

    public function configureOption(string $name, array $allowedTypes, $default, array $allowedValues = null): self
    {
        $this
            ->setAllowedTypesAndValues($name, $allowedTypes, $allowedValues)
            ->setDefault($name, $default);

        return $this;
    }

    public function configureRequiredOption(string $name, array $allowedTypes, array $allowedValues = null): self
    {
        $this
            ->setAllowedTypesAndValues($name, $allowedTypes, $allowedValues)
            ->setRequired($name);

        return $this;
    }

    public function setAllowUnknownKeys(bool $allow): self
    {
        $this->allowUnknownKeys = $allow;

        return $this;
    }

    public function resolve(array $options = [])
    {
        if ($this->allowUnknownKeys) {
            $this->setDefined(array_keys($options));
        }

        return parent::resolve($options);
    }

    protected function setAllowedTypesAndValues(string $name, array $allowedTypes, array $allowedValues = null): self
    {
        $this
            ->setDefined($name)
            ->setAllowedTypes($name, $allowedTypes);
        if (is_array($allowedValues)) {
            $this->setAllowedValues($name, $allowedValues);
        }

        return $this;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace steevanb\SymfonyOptionsResolver;
6
7			use Symfony\Component\OptionsResolver\OptionsResolver as SymfonyOptionsResolver;
8
9			class OptionsResolver extends SymfonyOptionsResolver
10			{
11			/** @var bool */
12			protected $allowUnknownKeys = false;
13
14			public function configureOption(string $name, array $allowedTypes, $default, array $allowedValues = null): self
15			{
16			$this
17			->setAllowedTypesAndValues($name, $allowedTypes, $allowedValues)
18			->setDefault($name, $default);
19
20			return $this;
21			}
22
23			public function configureRequiredOption(string $name, array $allowedTypes, array $allowedValues = null): self
24			{
25			$this
26			->setAllowedTypesAndValues($name, $allowedTypes, $allowedValues)
27			->setRequired($name);
28
29			return $this;
30			}
31
32			public function setAllowUnknownKeys(bool $allow): self
33			{
34			$this->allowUnknownKeys = $allow;
35
36			return $this;
37			}
38
39			public function resolve(array $options = [])
40			{
41			if ($this->allowUnknownKeys) {
42			$this->setDefined(array_keys($options));
43			}
44
45			return parent::resolve($options);
46			}
47
48			protected function setAllowedTypesAndValues(string $name, array $allowedTypes, array $allowedValues = null): self
49			{
50			$this
51			->setDefined($name)
52			->setAllowedTypes($name, $allowedTypes);
53			if (is_array($allowedValues)) {
54			$this->setAllowedValues($name, $allowedValues);
55			}
56
57			return $this;
58			}
59			}
60

steevanb / symfony-options-resolver

Pull Request — master (#4)

OptionsResolver::setAllowedTypesAndValues() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like