StarCitizen\StarCitizens

Complexity

Total Complexity

19

Size/Duplication

Total Lines	158
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

89.66%

Importance

Changes	1
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
C	__call()	0	26	8
A	find()	0	15	1
A	getParams()	0	15	2
A	checkResponse()	0	12	3
A	setupClient()	0	6	2
A	fillModel()	0	11	2

<?php

namespace StarCitizen;

use StarCitizen\Models\Model;
use StarCitizen\Client\StarCitizensClient;

/**
 * Class StarCitizens
 * @package StarCitizen
 *
 * @method accounts($id, $profileType = false, $cache = false, $raw = false)
 * @method organisations($id, $profileType = false, $cache = false, $raw = false)
 */
final class StarCitizens
{
    /**
     * @var bool|StarCitizensClient
     */
    private static $client = false;

    private $systems = [
        "accounts" => [
            "base_action" => "full_profile",
            "actions" => [
                "full_profile" => '\Profile',
                "threads" => ['\Thread', '', 'thread_id'],
                "posts" => ['\Post', 'post', 'post_id'],
            ]
        ]
    ];

    /**
     * StarCitizens constructor.
     */
    public function __construct()
    {
        static::setupClient();

Since StarCitizen\StarCitizens is declared final, using late-static binding will have no effect. You might want to replace static with self instead.

    }

    /**
     * @param $name
     * @param $arguments
     * @return bool|mixed
     * @throws \Exception
     */
    function __call($name, $arguments)

It is generally recommended to explicitly declare the visibility for methods.

    {
        if (array_key_exists($name, $this->systems)) {
            $argumentCount = count($arguments);
            if ($argumentCount == 0)
                throw new \InvalidArgumentException("Requires an argument");

            if ($argumentCount > 0 && $argumentCount< 2)
                return $this->find($arguments[0], $name, $this->systems[$name]['base_action']);

            if ($argumentCount == 2) {
                list($id, $profileType) = $arguments;
                if ($profileType == false)
                    $profileType = $this->systems[$name]['base_action'];
                return $this->find($id, $name, $profileType);
            }
            if ($argumentCount == 4 ) {
                list($id, $profileType, $cache, $raw) = $arguments;
                return $this->find($id, $name, $profileType, $cache, $raw);
            } else {
                throw new \InvalidArgumentException("Invalid arguments");
            }
        }

        throw new \Exception("Method not found");
    }

    /**
     * Find an entity
     *
     * @param $id
     * @param $system
     * @param $profileType
     * @param bool $cache
     * @param bool $raw
     * @return bool|mixed
     */
    private function find($id, $system, $profileType, $cache = false, $raw = false)
    {
        var_dump($this->getParams($id, $system, $profileType, $cache));

var_dump($this->getParams($id, $system, $profileType, $cache)); looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data.

        $response = json_decode(
            self::$client
                ->getResult(
                    $this->getParams($id, $system, $profileType, $cache)
                )
                ->getBody()
                ->getContents(),
            true
        );

        return $this->checkResponse($response, $this->systems[$system]['actions'][$profileType], $raw);
    }

    /**
     * @param $id
     * @param $system
     * @param $profileType
     * @param $cache
     * @return array
     */
    private function getParams($id, $system, $profileType, $cache)
    {
        $cache = ($cache === true) ? "cache" : "live";

        return [
            'api_source' => $cache,
            'system' => $system,
            'action' => $profileType,
            'target_id' => $id,
            'expedite' => '0',
            'format' => 'json',
            'start_page' => '1',
            'end_page' => '5'
        ];
    }

    /**
     * @param $response
     * @param $profileType
     * @param $raw
     *
     * @return bool|mixed
     */
    private function checkResponse($response, $profileType, $raw)
    {
        if ($response['request_stats']['query_status'] == "success") {
            if ($raw === true) {
                return $response;
            } else {
                return $this->fillModel($profileType, $response['data']);
            }
        }

        return false;
    }

    /**
     * Setup the client
     */
    private static function setupClient()
    {
        if (static::$client === false) {

Since StarCitizen\StarCitizens is declared final, using late-static binding will have no effect. You might want to replace static with self instead.

            static::$client = new StarCitizensClient();

Since StarCitizen\StarCitizens is declared final, using late-static binding will have no effect. You might want to replace static with self instead.

        }
    }

    /**
     * Fills our model in with the provided data
     *
     * @param $model
     * @param $fillData
     *
     * @return Model
     */
    private function fillModel($model, $fillData)
    {
        if (is_array($model)) {
            list($className, $dataRoot, $idName) =$model;
            $object = new \ReflectionClass('StarCitizen\Models\Store');
            return $object->newInstance($fillData, $className, $dataRoot, $idName);
        } else {
            $object = new \ReflectionClass('StarCitizen\Models' . $model);
            return $object->newInstance($fillData);
        }
    }
}