Organisation::members() - Code Metrics - Inspection of "Added members. Had to add a small adjustment for t..." - stedop/starcitizens - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4c7769...90a6b5 )

by Stephen

created 2015-12-15 18:29 UTC

Organisation::members() A

↳ Parent: Organisation

Complexity

Conditions	3
Paths	3

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
dl	0
loc	10
ccs	6
cts	6
cp	1
rs	9.4286
c	1
b	0
f	1
cc	3
eloc	6
nc	3
nop	0
crap	3

<?php
namespace StarCitizen\Models;
use StarCitizen\Organisations\Organisations;

/**
 * Class Organization
 *
 * @package StarCitizen\Models;
 */
class Organisation extends BaseModel
{
    /**
     * Org vars
     */
    public $sid;
    public $title;
    public $logo;
    public $member_count;
    public $recruiting;
    public $archetype;
    public $commitment;
    public $roleplay;
    public $lang;
    public $primary_focus;
    public $primary_image;
    public $secondary_focus;
    public $secondary_image;
    public $banner;
    public $headline;
    public $history;
    public $manifesto;
    public $charter;
    public $cover_image;
    public $cover_video;
    public $date_added;
    public $last_scrape_date;

    /**
     * @var array
     */
    protected $magicProperties = [
        'members'
    ];

    private $members;

    /**
     * Organisation constructor.
     *
     * @param $orgData
     */
    public function __construct($orgData)
    {
        foreach ($orgData as $key => $value) {
            $this->$key = $value;
        }
    }

    /**
     * @return null|Store
     */
    final protected function members()
    {
        if ($this->members === null) {
            $members = Organisations::findMembers($this->sid);
            if ($members instanceof Store)
                $this->members = $members;
        }

        return $this->members;
    }
}

1		<?php
2		namespace StarCitizen\Models;
3		use StarCitizen\Organisations\Organisations;
4
5		/**
6		* Class Organization
7		*
8		* @package StarCitizen\Models;
9		*/
10		class Organisation extends BaseModel
11		{
12		/**
13		* Org vars
14		*/
15		public $sid;
16		public $title;
17		public $logo;
18		public $member_count;
19		public $recruiting;
20		public $archetype;
21		public $commitment;
22		public $roleplay;
23		public $lang;
24		public $primary_focus;
25		public $primary_image;
26		public $secondary_focus;
27		public $secondary_image;
28		public $banner;
29		public $headline;
30		public $history;
31		public $manifesto;
32		public $charter;
33		public $cover_image;
34		public $cover_video;
35		public $date_added;
36		public $last_scrape_date;
37
38		/**
39		* @var array
40		*/
41		protected $magicProperties = [
42		'members'
43		];
44
45		private $members;
46
47		/**
48		* Organisation constructor.
49		*
50		* @param $orgData
51		*/
52	3	public function __construct($orgData)
53		{
54	3	foreach ($orgData as $key => $value) {
55	3	$this->$key = $value;
56		}
57	3	}
58
59		/**
60		* @return null\|Store
61		*/
62	2	final protected function members()
63		{
64	2	if ($this->members === null) {
65	2	$members = Organisations::findMembers($this->sid);
66	2	if ($members instanceof Store)
67	2	$this->members = $members;
68		}
69
70	2	return $this->members;
71		}
72		}

stedop / starcitizens

Push — master ( 4c7769...90a6b5 )

Organisation::members() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like