Issues in LogsActivity.php (master) - Issues in master - stechstudio/laravel-storage-connect - Measure and Improve Code Quality continuously with Scrutinizer

Issues (78)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Subscribers/LogsActivity.php (1 issue)

Labels

Documentation 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace STS\StorageConnect\Subscribers;

use STS\StorageConnect\Events\CloudStorageDisabled;
use STS\StorageConnect\Events\CloudStorageEnabled;
use STS\StorageConnect\Events\CloudStorageSetup;
use Log;
use STS\StorageConnect\Events\UploadFailed;
use STS\StorageConnect\Events\UploadInProgress;
use STS\StorageConnect\Events\UploadRetrying;
use STS\StorageConnect\Events\UploadStarted;
use STS\StorageConnect\Events\UploadSucceeded;

/**
 * Class LogsActivity
 * @package STS\StorageConnect\Subscribers
 */
class LogsActivity
{
    /**
     * @param $dispatcher
     */
    public function subscribe($dispatcher)
    {
        $dispatcher->listen(CloudStorageSetup::class, function (CloudStorageSetup $event) {
            $this->info("New cloud storage connection", $event->storage);
        });

        $dispatcher->listen(UploadSucceeded::class, function (UploadSucceeded $event) {
            $this->info("File uploaded to cloud storage", $event->storage, [
                'source'      => $event->sourcePath,
                'destination' => $event->destinationPath
            ]);
        });

        $dispatcher->listen(UploadRetrying::class, function (UploadRetrying $event) {
            $this->warning($event->message, $event->storage, [
                'source'  => $event->sourcePath
            ]);
        });

        $dispatcher->listen(UploadFailed::class, function (UploadFailed $event) {
            $this->error($event->message, $event->storage, [
                'source'  => $event->sourcePath
            ]);
        });

        $dispatcher->listen(UploadStarted::class, function (UploadStarted $event) {
            $this->info("Async upload started", $event->storage, [
                'source'  => $event->sourcePath
            ]);
        });

        $dispatcher->listen(UploadInProgress::class, function (UploadInProgress $event) {
            $this->info("Async upload in progress", $event->storage, [
                'source'  => $event->sourcePath
            ]);
        });

        $dispatcher->listen(CloudStorageDisabled::class, function (CloudStorageDisabled $event) {
            $this->warning("Connection disabled", $event->storage, [
                'reason'  => $event->storage->reason
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ]);
        });

        $dispatcher->listen(CloudStorageEnabled::class, function (CloudStorageEnabled $event) {
            $this->info("Connection enabled", $event->storage);
        });
    }

    /**
     * @param $message
     * @param $storage
     * @param array $context
     */
    protected function info($message, $storage, array $context = [])
    {
        Log::info($message, $this->getContext($storage, $context));
    }

    /**
     * @param $message
     * @param $storage
     * @param array $context
     */
    protected function warning($message, $storage, array $context = [])
    {
        Log::warning($message, $this->getContext($storage, $context));
    }

    /**
     * @param $message
     * @param $storage
     * @param array $context
     */
    protected function error($message, $storage, array $context = [])
    {
        Log::error($message, $this->getContext($storage, $context));
    }

    /**
     * @param $storage
     * @param array $context
     *
     * @return array
     */
    protected function getContext($storage, array $context = [])
    {
        return array_merge($context, [
            'storage' => $storage->id,
            'driver'  => $storage->driver,
            'owner'   => $storage->owner_description,
        ]);
    }
}


1			<?php
2			namespace STS\StorageConnect\Subscribers;
3
4			use STS\StorageConnect\Events\CloudStorageDisabled;
5			use STS\StorageConnect\Events\CloudStorageEnabled;
6			use STS\StorageConnect\Events\CloudStorageSetup;
7			use Log;
8			use STS\StorageConnect\Events\UploadFailed;
9			use STS\StorageConnect\Events\UploadInProgress;
10			use STS\StorageConnect\Events\UploadRetrying;
11			use STS\StorageConnect\Events\UploadStarted;
12			use STS\StorageConnect\Events\UploadSucceeded;
13
14			/**
15			* Class LogsActivity
16			* @package STS\StorageConnect\Subscribers
17			*/
18			class LogsActivity
19			{
20			/**
21			* @param $dispatcher
22			*/
23			public function subscribe($dispatcher)
24			{
25			$dispatcher->listen(CloudStorageSetup::class, function (CloudStorageSetup $event) {
26			$this->info("New cloud storage connection", $event->storage);
27			});
28
29			$dispatcher->listen(UploadSucceeded::class, function (UploadSucceeded $event) {
30			$this->info("File uploaded to cloud storage", $event->storage, [
31			'source' => $event->sourcePath,
32			'destination' => $event->destinationPath
33			]);
34			});
35
36			$dispatcher->listen(UploadRetrying::class, function (UploadRetrying $event) {
37			$this->warning($event->message, $event->storage, [
38			'source' => $event->sourcePath
39			]);
40			});
41
42			$dispatcher->listen(UploadFailed::class, function (UploadFailed $event) {
43			$this->error($event->message, $event->storage, [
44			'source' => $event->sourcePath
45			]);
46			});
47
48			$dispatcher->listen(UploadStarted::class, function (UploadStarted $event) {
49			$this->info("Async upload started", $event->storage, [
50			'source' => $event->sourcePath
51			]);
52			});
53
54			$dispatcher->listen(UploadInProgress::class, function (UploadInProgress $event) {
55			$this->info("Async upload in progress", $event->storage, [
56			'source' => $event->sourcePath
57			]);
58			});
59
60			$dispatcher->listen(CloudStorageDisabled::class, function (CloudStorageDisabled $event) {
61			$this->warning("Connection disabled", $event->storage, [
62			'reason' => $event->storage->reason
			0 ignored issues – show Documentation introduced 2018-09-19 12:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `reason` does not exist on `object<STS\StorageConnect\Models\CloudStorage>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
63			]);
64			});
65
66			$dispatcher->listen(CloudStorageEnabled::class, function (CloudStorageEnabled $event) {
67			$this->info("Connection enabled", $event->storage);
68			});
69			}
70
71			/**
72			* @param $message
73			* @param $storage
74			* @param array $context
75			*/
76			protected function info($message, $storage, array $context = [])
77			{
78			Log::info($message, $this->getContext($storage, $context));
79			}
80
81			/**
82			* @param $message
83			* @param $storage
84			* @param array $context
85			*/
86			protected function warning($message, $storage, array $context = [])
87			{
88			Log::warning($message, $this->getContext($storage, $context));
89			}
90
91			/**
92			* @param $message
93			* @param $storage
94			* @param array $context
95			*/
96			protected function error($message, $storage, array $context = [])
97			{
98			Log::error($message, $this->getContext($storage, $context));
99			}
100
101			/**
102			* @param $storage
103			* @param array $context
104			*
105			* @return array
106			*/
107			protected function getContext($storage, array $context = [])
108			{
109			return array_merge($context, [
110			'storage' => $storage->id,
111			'driver' => $storage->driver,
112			'owner' => $storage->owner_description,
113			]);
114			}
115			}
116

stechstudio / laravel-storage-connect

Issues (78)

Security Analysis not enabled

src/Subscribers/LogsActivity.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like