UploadsFiles::upload() - Code Metrics - Inspection of "work on async uploads with queued status checks. b..." - stechstudio/laravel-storage-connect - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d5f261...ed671f )

by Joseph

created 2018-09-30 00:25 UTC

UploadsFiles::upload() A

↳ Parent: UploadsFiles

Complexity

Conditions	3
Paths	5

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	20
rs	9.6
c	0
b	0
f	0
nc	5
cc	3
nop	4

<?php

namespace STS\StorageConnect\Models\Concerns;

use Carbon\Carbon;
use Illuminate\Database\Eloquent\Model;
use STS\StorageConnect\Contracts\UploadTarget;
use STS\StorageConnect\Events\UploadFailed;
use STS\StorageConnect\Events\UploadInProgress;
use STS\StorageConnect\Events\UploadRetrying;
use STS\StorageConnect\Events\UploadStarted;
use STS\StorageConnect\Events\UploadSucceeded;
use STS\StorageConnect\Exceptions\UploadException;
use STS\StorageConnect\Jobs\CheckUploadStatus;
use STS\StorageConnect\Jobs\UploadFile;
use STS\StorageConnect\UploadRequest;
use STS\StorageConnect\UploadResponse;

/**
 * @property Carbon uploaded_at
 */
trait UploadsFiles
{
    /**
     * @param      $source
     * @param      $destinationPath
     * @param bool $shouldQueue
     * @param null $queueJob
     *
     * @return UploadResponse|bool
     */
    public function upload( $source, $destinationPath = null, $shouldQueue = true, $queueJob = null )
    {
        $this->verify();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        if ($shouldQueue) {
            return dispatch(new UploadFile($source, $destinationPath, $this));
        }

        $request = new UploadRequest($source, $destinationPath);

        try {
            return $this->handleUpload($request);
        } catch (UploadException $exception) {
            $this->handleUploadError($exception, $queueJob);

            return false;
        } finally {
            $this->ping();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
    }

    /**
     * @param UploadRequest $request
     *
     * @return UploadResponse
     */
    protected function handleUpload( UploadRequest $request )
    {
        return $this->processResponse($this->adapter()->upload($request));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param UploadResponse $response
     */
    public function checkUploadStatus( UploadResponse $response )
    {
        $this->processResponse($this->adapter()->checkUploadStatus($response));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param UploadResponse $response
     *
     * @return UploadResponse
     */
    protected function processResponse( UploadResponse $response )
    {
        if ($response->isAsync()) {
            dispatch(new CheckUploadStatus($this, $response));

            if ($response->getStatusChecks() == 0) {
                event(new UploadStarted($this, $response));
            } else {
                event(new UploadInProgress($this, $response));
            }
        } else {
            $this->uploaded_at = Carbon::now();
            $this->save();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

            event(new UploadSucceeded($this, $response));
        }

        return $response;
    }

    /**
     * @param UploadException $exception
     * @param null            $job
     *
     * @return mixed
     */
    protected function handleUploadError( UploadException $exception, $job = null )
    {
        $exception->setStorage($this);

        if ($exception->shouldRetry() && $job) {
            event(new UploadRetrying($this, $exception));

            $job->release();

            return;
        }

        if ($exception->shouldDisable()) {
            $this->disable($exception->getReason());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }

        if ($job) {
            $job->fail($exception);
        }

        event(new UploadFailed($this, $exception));
    }
}

1			<?php
2
3			namespace STS\StorageConnect\Models\Concerns;
4
5			use Carbon\Carbon;
6			use Illuminate\Database\Eloquent\Model;
7			use STS\StorageConnect\Contracts\UploadTarget;
8			use STS\StorageConnect\Events\UploadFailed;
9			use STS\StorageConnect\Events\UploadInProgress;
10			use STS\StorageConnect\Events\UploadRetrying;
11			use STS\StorageConnect\Events\UploadStarted;
12			use STS\StorageConnect\Events\UploadSucceeded;
13			use STS\StorageConnect\Exceptions\UploadException;
14			use STS\StorageConnect\Jobs\CheckUploadStatus;
15			use STS\StorageConnect\Jobs\UploadFile;
16			use STS\StorageConnect\UploadRequest;
17			use STS\StorageConnect\UploadResponse;
18
19			/**
20			* @property Carbon uploaded_at
21			*/
22			trait UploadsFiles
23			{
24			/**
25			* @param $source
26			* @param $destinationPath
27			* @param bool $shouldQueue
28			* @param null $queueJob
29			*
30			* @return UploadResponse\|bool
31			*/
32			public function upload( $source, $destinationPath = null, $shouldQueue = true, $queueJob = null )
33			{
34			$this->verify();
			0 ignored issues – show Bug introduced 2018-09-25 18:52 UTC by Report Bug Copy Issue Report It seems like `verify()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
35
36			if ($shouldQueue) {
37			return dispatch(new UploadFile($source, $destinationPath, $this));
38			}
39
40			$request = new UploadRequest($source, $destinationPath);
41
42			try {
43			return $this->handleUpload($request);
44			} catch (UploadException $exception) {
45			$this->handleUploadError($exception, $queueJob);
46
47			return false;
48			} finally {
49			$this->ping();
			0 ignored issues – show Bug introduced 2018-09-30 00:26 UTC by Report Bug Copy Issue Report It seems like `ping()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
50			}
51			}
52
53			/**
54			* @param UploadRequest $request
55			*
56			* @return UploadResponse
57			*/
58			protected function handleUpload( UploadRequest $request )
59			{
60			return $this->processResponse($this->adapter()->upload($request));
			0 ignored issues – show Bug introduced 2018-09-30 00:26 UTC by Report Bug Copy Issue Report It seems like `adapter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
61			}
62
63			/**
64			* @param UploadResponse $response
65			*/
66			public function checkUploadStatus( UploadResponse $response )
67			{
68			$this->processResponse($this->adapter()->checkUploadStatus($response));
			0 ignored issues – show Bug introduced 2018-09-30 00:26 UTC by Report Bug Copy Issue Report It seems like `adapter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
69			}
70
71			/**
72			* @param UploadResponse $response
73			*
74			* @return UploadResponse
75			*/
76			protected function processResponse( UploadResponse $response )
77			{
78			if ($response->isAsync()) {
79			dispatch(new CheckUploadStatus($this, $response));
80
81			if ($response->getStatusChecks() == 0) {
82			event(new UploadStarted($this, $response));
83			} else {
84			event(new UploadInProgress($this, $response));
85			}
86			} else {
87			$this->uploaded_at = Carbon::now();
88			$this->save();
			0 ignored issues – show Bug introduced 2018-09-30 00:26 UTC by Report Bug Copy Issue Report It seems like `save()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
89
90			event(new UploadSucceeded($this, $response));
91			}
92
93			return $response;
94			}
95
96			/**
97			* @param UploadException $exception
98			* @param null $job
99			*
100			* @return mixed
101			*/
102			protected function handleUploadError( UploadException $exception, $job = null )
103			{
104			$exception->setStorage($this);
105
106			if ($exception->shouldRetry() && $job) {
107			event(new UploadRetrying($this, $exception));
108
109			$job->release();
110
111			return;
112			}
113
114			if ($exception->shouldDisable()) {
115			$this->disable($exception->getReason());
			0 ignored issues – show Bug introduced 2018-09-25 18:52 UTC by Report Bug Copy Issue Report It seems like `disable()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
116			}
117
118			if ($job) {
119			$job->fail($exception);
120			}
121
122			event(new UploadFailed($this, $exception));
123			}
124			}

stechstudio / laravel-storage-connect

Push — master ( d5f261...ed671f )

UploadsFiles::upload() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like