Issues in ParseRulesBuilder.php (main) - Issues in main - steam-market-providers/parser-manager - Measure and Improve Code Quality continuously with Scrutinizer

Issues (24)

src/Builder/ParseRulesBuilder.php (2 issues)

Labels

Severity

Critical 1
Minor 1

<?php

namespace SteamMarketProviders\ParserManager\Builder;

use Closure;

class ParseRulesBuilder
{
    private \stdClass $rules;

    public function __construct()
    {
        $this->rules = new \stdClass();
    }

    public function wrapper(string $name, string $value, Closure $wrapper)
    {
        $old = clone $this->rules;


        $this->rules->$name = $value;
        call_user_func($wrapper, $this);

        return $this;
    }

    public function item(string $name, string $value)
    {
        $this->rules->$name = $value;
        return $this;
    }

    public function print()
    {
        var_dump($this->rules);

    }
}


1			<?php
2
3			namespace SteamMarketProviders\ParserManager\Builder;
4
5			use Closure;
6
7			class ParseRulesBuilder
8			{
9			private \stdClass $rules;
10
11			public function __construct()
12			{
13			$this->rules = new \stdClass();
14			}
15
16			public function wrapper(string $name, string $value, Closure $wrapper)
17			{
18			$old = clone $this->rules;
			0 ignored issues – show Unused Code introduced 2022-07-09 19:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this The assignment to `$old` is dead and can be removed. Loading history...
19
20			$this->rules->$name = $value;
21			call_user_func($wrapper, $this);
22
23			return $this;
24			}
25
26			public function item(string $name, string $value)
27			{
28			$this->rules->$name = $value;
29			return $this;
30			}
31
32			public function print()
33			{
34			var_dump($this->rules);
			0 ignored issues – show Security Debugging Code introduced 2022-07-09 19:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this `var_dump($this->rules)` looks like debug code. Are you sure you do not want to remove it? Loading history...
35			}
36			}
37

steam-market-providers / parser-manager

Issues (24)

src/Builder/ParseRulesBuilder.php (2 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like