anonymous//tests/SteamParserFactoryTest.php$0 - Code Metrics - Inspection of "Update project" - steam-market-providers/parser-manager - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( 66f102...e7c7b0 )

by Yevhenii

created 2022-07-13 08:38 UTC

anonymous//tests/SteamParserFactoryTest.php$0 A

↳ Parent: SteamParserFactoryTest::setUp()

Complexity

Total Complexity

Size/Duplication

Total Lines	16
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	16
c	1
b	0
f	0
rs	10
wmc	2

<?php

declare(strict_types=1);

namespace SteamMarketProviders\ParserManager\Tests;

use PHPUnit\Framework\TestCase;
use SteamMarketProviders\ParserManager\Builder\ParseRulesBuilder;
use SteamMarketProviders\ParserManager\Contract\UrlBuilderInterface;
use SteamMarketProviders\ParserManager\Parser\AbstractProvider;
use SteamMarketProviders\ParserManager\Parser\SteamParser;
use SteamMarketProviders\ParserManager\SteamParserFactory;

class SteamParserFactoryTest extends TestCase
{
    private AbstractProvider $abstractProvider;

    /**
     * @return void
     */
    public function setUp(): void
    {
        $this->abstractProvider = new class extends AbstractProvider {

            /**
             * @param int $page
             * @return UrlBuilderInterface
             */
            protected function createUrl(int $page): UrlBuilderInterface
            {
                // TODO: Implement createUrl() method.
            }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}

            /**
             * @return ParseRulesBuilder
             */
            protected function createParseRules(): ParseRulesBuilder
            {
                // TODO: Implement createParseRules() method.
            }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
        };
    }

    public function testSuccessCreating(): void
    {
         $result = SteamParserFactory::create($this->abstractProvider);
         $this->assertInstanceOf(SteamParser::class, $result);
    }
}

1			<?php
2
3			declare(strict_types=1);
4
5			namespace SteamMarketProviders\ParserManager\Tests;
6
7			use PHPUnit\Framework\TestCase;
8			use SteamMarketProviders\ParserManager\Builder\ParseRulesBuilder;
9			use SteamMarketProviders\ParserManager\Contract\UrlBuilderInterface;
10			use SteamMarketProviders\ParserManager\Parser\AbstractProvider;
11			use SteamMarketProviders\ParserManager\Parser\SteamParser;
12			use SteamMarketProviders\ParserManager\SteamParserFactory;
13
14			class SteamParserFactoryTest extends TestCase
15			{
16			private AbstractProvider $abstractProvider;
17
18			/**
19			* @return void
20			*/
21			public function setUp(): void
22			{
23			$this->abstractProvider = new class extends AbstractProvider {
24
25			/**
26			* @param int $page
27			* @return UrlBuilderInterface
28			*/
29			protected function createUrl(int $page): UrlBuilderInterface
30			{
31			// TODO: Implement createUrl() method.
32			}
			0 ignored issues – show Bug Best Practice introduced 2022-07-13 08:40 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `SteamMarketProviders\Par...act\UrlBuilderInterface`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
33
34			/**
35			* @return ParseRulesBuilder
36			*/
37			protected function createParseRules(): ParseRulesBuilder
38			{
39			// TODO: Implement createParseRules() method.
40			}
			0 ignored issues – show Bug Best Practice introduced 2022-07-13 08:40 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `SteamMarketProviders\Par...ilder\ParseRulesBuilder`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
41			};
42			}
43
44			public function testSuccessCreating(): void
45			{
46			$result = SteamParserFactory::create($this->abstractProvider);
47			$this->assertInstanceOf(SteamParser::class, $result);
48			}
49			}

steam-market-providers / parser-manager

Push — main ( 66f102...e7c7b0 )

anonymous//tests/SteamParserFactoryTest.php$0 A

Complexity

Size/Duplication

Importance

Duplication Side-by-Side

Filter issues like