SteamMarketProviders\ParserManager\Http\Http

Complexity

Total Complexity

12

Size/Duplication

Total Lines	87
Duplicated Lines	0 %

Test Coverage

Coverage

62.07%

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	setUrl()	0	11	2
A	getUrl()	0	3	1
A	__construct()	0	4	2
A	sendRequest()	0	22	5
A	getStrategy()	0	3	1
A	setStrategy()	0	5	1

<?php

declare(strict_types=1);

namespace SteamMarketProviders\ParserManager\Http;

use Exception;
use stdClass;
use SteamMarketProviders\ParserManager\Contract\Http\HttpExceptionInterface;
use SteamMarketProviders\ParserManager\Contract\StrategyInterface;
use SteamMarketProviders\ParserManager\Exception\Http\URLNotSetException;

The type SteamMarketProviders\ParserManager\Exception\Http\URLNotSetException was not found. Maybe you did not declare it correctly or list all dependencies?

use SteamMarketProviders\ParserManager\Exception\HttpException;
use SteamMarketProviders\ParserManager\Exception\InvalidArgumentException;
use SteamMarketProviders\ParserManager\Http\Strategy\GuzzleStrategy;

final class Http
{
    private string $url;

    /**
     * @param StrategyInterface|null $strategy
     */
    public function __construct(private null|StrategyInterface $strategy = null)
    {
        if (!$this->strategy) {
            $this->strategy = new GuzzleStrategy();
        }
    }

    /**
     * @param string $url
     * @return $this
     * @throws InvalidArgumentException
     */
    public function setUrl(string $url): Http
    {
        if (!filter_var($url, FILTER_VALIDATE_URL)) {
            throw new InvalidArgumentException(
                sprintf('The url: "%s" is not in a valid format', $url)
            );
        }

        $this->url = $url;

        return $this;
    }

    /**
     * @return string
     */
    public function getUrl(): string
    {
        return $this->url;
    }

    /**
     * @param StrategyInterface $strategy
     * @return $this
     */
    public function setStrategy(StrategyInterface $strategy): Http
    {
        $this->strategy = $strategy;

        return $this;
    }

    /**
     * @return StrategyInterface
     */
    public function getStrategy(): StrategyInterface
    {
        return $this->strategy;

The expression return $this->strategy could return the type null which is incompatible with the type-hinted return SteamMarketProviders\ParserManager\Contract\StrategyInterface. Consider adding an additional type-check to rule them out.

    }

    /**
     * @return stdClass
     * @throws HttpException
     * @throws HttpExceptionInterface
     * @throws URLNotSetException
     */
    public function sendRequest(): stdClass
    {
        try {
            $response = $this->strategy->sendRequest($this->url);

The method sendRequest() does not exist on null.

            $code = $response->getStatus();
            if ($code !== 200) {
                throw new HttpException("");
            }

            $response = json_decode($response->getBody());

It seems like $response->getBody() can also be of type callable and resource; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

            if (!$response->success) {
                throw new HttpException("");
            }
        } catch (HttpExceptionInterface $httpException) {
            throw new $httpException();
        } catch (Exception $e) {
            throw new HttpException($e->getMessage());
        }

        return $response;
    }
}