SteamMarketProviders\ParserManager\Http\Options

Complexity

Total Complexity

7

Size/Duplication

Total Lines	84
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	setUserAgent()	0	5	1
A	getProxy()	0	3	1
A	getTimeout()	0	3	1
A	getUserAgent()	0	3	1
A	setProxy()	0	5	1
A	setFromOptions()	0	5	1
A	setTimeout()	0	5	1

<?php

declare(strict_types=1);

namespace SteamMarketProviders\ParserManager\Http;

class Options
{
    /**
     * @var string|null
     */
    private null|string $userAgent;

    /**
     * @var int
     */
    private int $timeout;

    /**
     * @var string|null
     */
    private null|string $proxy;

    /**
     * @param string $userAgent
     * @return $this
     */
    public function setUserAgent(string $userAgent): Options
    {
        $this->userAgent = $userAgent;

        return $this;
    }

    /**
     * @return string|null
     */
    public function getUserAgent(): null|string
    {
        return $this->userAgent;
    }

    /**
     * @param int $timeout
     * @return $this
     */
    public function setTimeout(int $timeout): Options
    {
        $this->timeout = $timeout;

        return $this;
    }

    /**
     * @return int
     */
    public function getTimeout(): int
    {
        return $this->timeout;
    }

    /**
     * @param string $proxy
     * @return $this
     */
    public function setProxy(string $proxy): Options
    {
        $this->proxy = $proxy;

        return $this;
    }

    /**
     * @return string
     */
    public function getProxy(): string
    {
        return $this->proxy;

The expression return $this->proxy could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }


    /**
     * @param Options $options
     * @return $this
     */
    public function setFromOptions(Options $options): Options
    {
        return $this->setUserAgent($options->getUserAgent())

It seems like $options->getUserAgent() can also be of type null; however, parameter $userAgent of SteamMarketProviders\ParserManager\Http\Options::setUserAgent() does only seem to accept string, maybe add an additional type check?

            ->setTimeout($options->getTimeout())
            ->setProxy($options->getProxy());
    }
}