Issues in customize.php (master) - Issues in master - staylor/WordPress - Measure and Improve Code Quality continuously with Scrutinizer

Issues (2010)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

wp-admin/customize.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Theme Customize Screen.
 *
 * @package WordPress
 * @subpackage Customize
 * @since 3.4.0
 */

define( 'IFRAME_REQUEST', true );

/** Load WordPress Administration Bootstrap */
require_once( dirname( __FILE__ ) . '/admin.php' );

if ( ! current_user_can( 'customize' ) ) {
	wp_die(
		'<h1>' . __( 'Cheatin&#8217; uh?' ) . '</h1>' .
		'<p>' . __( 'Sorry, you are not allowed to customize this site.' ) . '</p>',
		403
	);
}

wp_reset_vars( array( 'url', 'return', 'autofocus' ) );
if ( ! empty( $url ) ) {
	$wp_customize->set_preview_url( wp_unslash( $url ) );
}
if ( ! empty( $return ) ) {
	$wp_customize->set_return_url( wp_unslash( $return ) );
}
if ( ! empty( $autofocus ) && is_array( $autofocus ) ) {
	$wp_customize->set_autofocus( wp_unslash( $autofocus ) );
}

/**
 * @global WP_Scripts           $wp_scripts
 * @global WP_Customize_Manager $wp_customize
 */
global $wp_scripts, $wp_customize;

$registered = $wp_scripts->registered;
$wp_scripts = new WP_Scripts;
$wp_scripts->registered = $registered;

add_action( 'customize_controls_print_scripts',        'print_head_scripts', 20 );
add_action( 'customize_controls_print_footer_scripts', '_wp_footer_scripts'     );
add_action( 'customize_controls_print_styles',         'print_admin_styles', 20 );

/**
 * Fires when Customizer controls are initialized, before scripts are enqueued.
 *
 * @since 3.4.0
 */
do_action( 'customize_controls_init' );

wp_enqueue_script( 'customize-controls' );
wp_enqueue_style( 'customize-controls' );

/**
 * Enqueue Customizer control scripts.
 *
 * @since 3.4.0
 */
do_action( 'customize_controls_enqueue_scripts' );

// Let's roll.
@header('Content-Type: ' . get_option('html_type') . '; charset=' . get_option('blog_charset'));

wp_user_settings();
_wp_admin_html_begin();

$body_class = 'wp-core-ui wp-customizer js';

if ( wp_is_mobile() ) :
	$body_class .= ' mobile';

	?><meta name="viewport" id="viewport-meta" content="width=device-width, initial-scale=1.0, minimum-scale=0.5, maximum-scale=1.2" /><?php
endif;

if ( $wp_customize->is_ios() ) {
	$body_class .= ' ios';
}

if ( is_rtl() ) {
	$body_class .= ' rtl';
}
$body_class .= ' locale-' . sanitize_html_class( strtolower( str_replace( '_', '-', get_locale() ) ) );

$admin_title = sprintf( $wp_customize->get_document_title_template(), __( 'Loading&hellip;' ) );

?><title><?php echo $admin_title; ?></title>

<script type="text/javascript">
var ajaxurl = <?php echo wp_json_encode( admin_url( 'admin-ajax.php', 'relative' ) ); ?>;
</script>

<?php
/**
 * Fires when Customizer control styles are printed.
 *
 * @since 3.4.0
 */
do_action( 'customize_controls_print_styles' );

/**
 * Fires when Customizer control scripts are printed.
 *
 * @since 3.4.0
 */
do_action( 'customize_controls_print_scripts' );
?>
</head>
<body class="<?php echo esc_attr( $body_class ); ?>">
<div class="wp-full-overlay expanded">
	<form id="customize-controls" class="wrap wp-full-overlay-sidebar">
		<div id="customize-header-actions" class="wp-full-overlay-header">
			<?php
			$save_text = $wp_customize->is_theme_active() ? __( 'Save &amp; Publish' ) : __( 'Save &amp; Activate' );
			submit_button( $save_text, 'primary save', 'save', false );
			?>
			<span class="spinner"></span>
			<button type="button" class="customize-controls-preview-toggle">
				<span class="controls"><?php _e( 'Customize' ); ?></span>
				<span class="preview"><?php _e( 'Preview' ); ?></span>
			</button>
			<a class="customize-controls-close" href="<?php echo esc_url( $wp_customize->get_return_url() ); ?>">
				<span class="screen-reader-text"><?php _e( 'Close the Customizer and go back to the previous page' ); ?></span>
			</a>
		</div>

		<div id="widgets-right" class="wp-clearfix"><!-- For Widget Customizer, many widgets try to look for instances under div#widgets-right, so we have to add that ID to a container div in the Customizer for compat -->
		<div class="wp-full-overlay-sidebar-content" tabindex="-1">
			<div id="customize-info" class="accordion-section customize-info">
				<div class="accordion-section-title">
					<span class="preview-notice"><?php
						echo sprintf( __( 'You are customizing %s' ), '<strong class="panel-title site-title">' . get_bloginfo( 'name' ) . '</strong>' );
					?></span>
					<button type="button" class="customize-help-toggle dashicons dashicons-editor-help" aria-expanded="false"><span class="screen-reader-text"><?php _e( 'Help' ); ?></span></button>
				</div>
				<div class="customize-panel-description"><?php
					_e( 'The Customizer allows you to preview changes to your site before publishing them. You can also navigate to different pages on your site to preview them.' );
				?></div>
			</div>

			<div id="customize-theme-controls">
				<ul><?php // Panels and sections are managed here via JavaScript ?></ul>
			</div>
		</div>
		</div>

		<div id="customize-footer-actions" class="wp-full-overlay-footer">
			<?php $previewable_devices = $wp_customize->get_previewable_devices(); ?>
			<?php if ( ! empty( $previewable_devices ) ) : ?>
			<div class="devices">
				<?php foreach ( (array) $previewable_devices as $device => $settings ) : ?>
					<?php
					if ( empty( $settings['label'] ) ) {
						continue;
					}
					$active = ! empty( $settings['default'] );
					$class = 'preview-' . $device;
					if ( $active ) {
						$class .= ' active';
					}
					?>
					<button type="button" class="<?php echo esc_attr( $class ); ?>" aria-pressed="<?php echo esc_attr( $active ) ?>" data-device="<?php echo esc_attr( $device ); ?>">
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
						<span class="screen-reader-text"><?php echo esc_html( $settings['label'] ); ?></span>
					</button>
				<?php endforeach; ?>
			</div>
			<?php endif; ?>
			<button type="button" class="collapse-sidebar button-secondary" aria-expanded="true" aria-label="<?php esc_attr_e( 'Collapse Sidebar' ); ?>">
				<span class="collapse-sidebar-arrow"></span>
				<span class="collapse-sidebar-label"><?php _e( 'Collapse' ); ?></span>
			</button>
		</div>
	</form>
	<div id="customize-preview" class="wp-full-overlay-main"></div>
	<?php

	/**
	 * Prints templates, control scripts, and settings in the footer.
	 *
	 * @since 3.4.0
	 */
	do_action( 'customize_controls_print_footer_scripts' );
	?>
</div>
</body>
</html>


1			<?php
2			/**
3			* Theme Customize Screen.
4			*
5			* @package WordPress
6			* @subpackage Customize
7			* @since 3.4.0
8			*/
9
10			define( 'IFRAME_REQUEST', true );
11
12			/** Load WordPress Administration Bootstrap */
13			require_once( dirname( __FILE__ ) . '/admin.php' );
14
15			if ( ! current_user_can( 'customize' ) ) {
16			wp_die(
17			'<h1>' . __( 'Cheatin’ uh?' ) . '</h1>' .
18			'<p>' . __( 'Sorry, you are not allowed to customize this site.' ) . '</p>',
19			403
20			);
21			}
22
23			wp_reset_vars( array( 'url', 'return', 'autofocus' ) );
24			if ( ! empty( $url ) ) {
25			$wp_customize->set_preview_url( wp_unslash( $url ) );
26			}
27			if ( ! empty( $return ) ) {
28			$wp_customize->set_return_url( wp_unslash( $return ) );
29			}
30			if ( ! empty( $autofocus ) && is_array( $autofocus ) ) {
31			$wp_customize->set_autofocus( wp_unslash( $autofocus ) );
32			}
33
34			/**
35			* @global WP_Scripts $wp_scripts
36			* @global WP_Customize_Manager $wp_customize
37			*/
38			global $wp_scripts, $wp_customize;
39
40			$registered = $wp_scripts->registered;
41			$wp_scripts = new WP_Scripts;
42			$wp_scripts->registered = $registered;
43
44			add_action( 'customize_controls_print_scripts', 'print_head_scripts', 20 );
45			add_action( 'customize_controls_print_footer_scripts', '_wp_footer_scripts' );
46			add_action( 'customize_controls_print_styles', 'print_admin_styles', 20 );
47
48			/**
49			* Fires when Customizer controls are initialized, before scripts are enqueued.
50			*
51			* @since 3.4.0
52			*/
53			do_action( 'customize_controls_init' );
54
55			wp_enqueue_script( 'customize-controls' );
56			wp_enqueue_style( 'customize-controls' );
57
58			/**
59			* Enqueue Customizer control scripts.
60			*
61			* @since 3.4.0
62			*/
63			do_action( 'customize_controls_enqueue_scripts' );
64
65			// Let's roll.
66			@header('Content-Type: ' . get_option('html_type') . '; charset=' . get_option('blog_charset'));
67
68			wp_user_settings();
69			_wp_admin_html_begin();
70
71			$body_class = 'wp-core-ui wp-customizer js';
72
73			if ( wp_is_mobile() ) :
74			$body_class .= ' mobile';
75
76			?><meta name="viewport" id="viewport-meta" content="width=device-width, initial-scale=1.0, minimum-scale=0.5, maximum-scale=1.2" /><?php
77			endif;
78
79			if ( $wp_customize->is_ios() ) {
80			$body_class .= ' ios';
81			}
82
83			if ( is_rtl() ) {
84			$body_class .= ' rtl';
85			}
86			$body_class .= ' locale-' . sanitize_html_class( strtolower( str_replace( '_', '-', get_locale() ) ) );
87
88			$admin_title = sprintf( $wp_customize->get_document_title_template(), __( 'Loading…' ) );
89
90			?><title><?php echo $admin_title; ?></title>
91
92			<script type="text/javascript">
93			var ajaxurl = <?php echo wp_json_encode( admin_url( 'admin-ajax.php', 'relative' ) ); ?>;
94			</script>
95
96			<?php
97			/**
98			* Fires when Customizer control styles are printed.
99			*
100			* @since 3.4.0
101			*/
102			do_action( 'customize_controls_print_styles' );
103
104			/**
105			* Fires when Customizer control scripts are printed.
106			*
107			* @since 3.4.0
108			*/
109			do_action( 'customize_controls_print_scripts' );
110			?>
111			</head>
112			<body class="<?php echo esc_attr( $body_class ); ?>">
113			<div class="wp-full-overlay expanded">
114			<form id="customize-controls" class="wrap wp-full-overlay-sidebar">
115			<div id="customize-header-actions" class="wp-full-overlay-header">
116			<?php
117			$save_text = $wp_customize->is_theme_active() ? __( 'Save & Publish' ) : __( 'Save & Activate' );
118			submit_button( $save_text, 'primary save', 'save', false );
119			?>
120			<span class="spinner"></span>
121			<button type="button" class="customize-controls-preview-toggle">
122			<span class="controls"><?php _e( 'Customize' ); ?></span>
123			<span class="preview"><?php _e( 'Preview' ); ?></span>
124			</button>
125			<a class="customize-controls-close" href="<?php echo esc_url( $wp_customize->get_return_url() ); ?>">
126			<span class="screen-reader-text"><?php _e( 'Close the Customizer and go back to the previous page' ); ?></span>
127			</a>
128			</div>
129
130			<div id="widgets-right" class="wp-clearfix"><!-- For Widget Customizer, many widgets try to look for instances under div#widgets-right, so we have to add that ID to a container div in the Customizer for compat -->
131			<div class="wp-full-overlay-sidebar-content" tabindex="-1">
132			<div id="customize-info" class="accordion-section customize-info">
133			<div class="accordion-section-title">
134			<span class="preview-notice"><?php
135			echo sprintf( __( 'You are customizing %s' ), '<strong class="panel-title site-title">' . get_bloginfo( 'name' ) . '</strong>' );
136			?></span>
137			<button type="button" class="customize-help-toggle dashicons dashicons-editor-help" aria-expanded="false"><span class="screen-reader-text"><?php _e( 'Help' ); ?></span></button>
138			</div>
139			<div class="customize-panel-description"><?php
140			_e( 'The Customizer allows you to preview changes to your site before publishing them. You can also navigate to different pages on your site to preview them.' );
141			?></div>
142			</div>
143
144			<div id="customize-theme-controls">
145			<ul><?php // Panels and sections are managed here via JavaScript ?></ul>
146			</div>
147			</div>
148			</div>
149
150			<div id="customize-footer-actions" class="wp-full-overlay-footer">
151			<?php $previewable_devices = $wp_customize->get_previewable_devices(); ?>
152			<?php if ( ! empty( $previewable_devices ) ) : ?>
153			<div class="devices">
154			<?php foreach ( (array) $previewable_devices as $device => $settings ) : ?>
155			<?php
156			if ( empty( $settings['label'] ) ) {
157			continue;
158			}
159			$active = ! empty( $settings['default'] );
160			$class = 'preview-' . $device;
161			if ( $active ) {
162			$class .= ' active';
163			}
164			?>
165			<button type="button" class="<?php echo esc_attr( $class ); ?>" aria-pressed="<?php echo esc_attr( $active ) ?>" data-device="<?php echo esc_attr( $device ); ?>">
			0 ignored issues – show Documentation introduced 2016-08-19 16:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$active` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
166			<span class="screen-reader-text"><?php echo esc_html( $settings['label'] ); ?></span>
167			</button>
168			<?php endforeach; ?>
169			</div>
170			<?php endif; ?>
171			<button type="button" class="collapse-sidebar button-secondary" aria-expanded="true" aria-label="<?php esc_attr_e( 'Collapse Sidebar' ); ?>">
172			<span class="collapse-sidebar-arrow"></span>
173			<span class="collapse-sidebar-label"><?php _e( 'Collapse' ); ?></span>
174			</button>
175			</div>
176			</form>
177			<div id="customize-preview" class="wp-full-overlay-main"></div>
178			<?php
179
180			/**
181			* Prints templates, control scripts, and settings in the footer.
182			*
183			* @since 3.4.0
184			*/
185			do_action( 'customize_controls_print_footer_scripts' );
186			?>
187			</div>
188			</body>
189			</html>
190

staylor / WordPress

Issues (2010)

Security Analysis not enabled

wp-admin/customize.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like