Staudenmeir\LaravelUpsert\Query\Grammars\CompilesUpsertQueries

Complexity

Total Complexity

3

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	compileUpsert()	0	13	2
A	compileInsertIgnore()	0	3	1

<?php

namespace Staudenmeir\LaravelUpsert\Query\Grammars;

use Illuminate\Database\Query\Builder;

trait CompilesUpsertQueries
{
    /**
     * Compile an "upsert" statement into SQL.
     *
     * @param \Illuminate\Database\Query\Builder $query
     * @param array $values
     * @param array $target
     * @param array $update
     * @return string
     */
    public function compileUpsert(Builder $query, array $values, array $target, array $update)
    {
        $sql = $this->compileInsert($query, $values);

The method compileInsert() does not exist on Staudenmeir\LaravelUpsert\Query\Grammars\CompilesUpsertQueries. Did you maybe mean compileInsertIgnore()?

        $sql .= ' on conflict ('.$this->columnize($target).') do update set ';

It seems like columnize() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $columns = collect($update)->map(function ($value, $key) {
            return is_numeric($key)
                ? $this->wrap($value).' = '.$this->wrapValue('excluded').'.'.$this->wrap($value)

It seems like wrapValue() must be provided by classes using this trait. How about adding it as abstract method to this trait?

It seems like wrap() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                : $this->wrap($key).' = '.$this->parameter($value);

It seems like parameter() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        })->implode(', ');

        return $sql.$columns;
    }

    /**
     * Compile an "insert ignore" statement into SQL.
     *
     * @param \Illuminate\Database\Query\Builder $query
     * @param array $values
     * @param array $target
     * @return string
     */
    public function compileInsertIgnore(Builder $query, array $values, array $target)

The parameter $target is not used and could be removed.

    {
        return $this->compileInsert($query, $values).' on conflict do nothing';
    }
}