staudenmeir / laravel-migration-views

src/Schema/Builders/ManagesViews.php

<?php

namespace Staudenmeir\LaravelMigrationViews\Schema\Builders;

use Illuminate\Database\Eloquent\Builder as EloquentBuilder;
use Illuminate\Database\Query\Builder as QueryBuilder;
use Illuminate\Support\Str;

trait ManagesViews
{
    /**
     * Create a new view on the schema.
     *
     * @param string $name
     * @param \Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Query\Builder|string $query
     * @param array|null $columns
     * @param bool $orReplace
     * @param bool $materialized
     * @return void
     */
    public function createView($name, $query, ?array $columns = null, $orReplace = false, bool $materialized = false)
    {
        $query = $this->getQueryString($query);

        $this->connection->statement(
            $this->grammar->compileCreateView($name, $query, $columns, $orReplace, $materialized)
        );
    }

    /**
     * Create a new view on the schema or replace an existing one.
     *
     * @param string $name
     * @param \Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Query\Builder|string $query
     * @param array|null $columns
     * @return void
     */
    public function createOrReplaceView($name, $query, ?array $columns = null)
    {
        $this->createView($name, $query, $columns, true);
    }

    /**
     * Create a new materialized view on the schema.
     *
     * @param string $name
     * @param \Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Query\Builder|string $query
     * @param array|null $columns
     * @return void
     */
    public function createMaterializedView(string $name, EloquentBuilder|QueryBuilder $query, ?array $columns = null): void
    {
        $this->createView($name, $query, $columns, materialized: true);
    }

    /**
     * Convert the query and its bindings to an SQL string.
     *
     * @param \Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Query\Builder|string $query
     * @return string
     */
    protected function getQueryString($query)
    {
        if (is_string($query)) {
            return $query;
        }

        $bindings = $this->stringifyBindings(
            $query->getBindings()

It seems like $query->getBindings() can also be of type Illuminate\Database\Eloquent\Builder and Illuminate\Database\Query\Builder; however, parameter $bindings of Staudenmeir\LaravelMigrationViews\Schema\Builders\ManagesViews::stringifyBindings() does only seem to accept array, maybe add an additional type check?

        );

        return Str::replaceArray('?', $bindings, $query->toSql());

It seems like $query->toSql() can also be of type Illuminate\Database\Eloquent\Builder and Illuminate\Database\Query\Builder; however, parameter $subject of Illuminate\Support\Str::replaceArray() does only seem to accept string, maybe add an additional type check?

    }

    /**
     * Stringify the query bindings.
     *
     * @param array $bindings
     * @return array
     */
    protected function stringifyBindings(array $bindings)
    {
        $bindings = $this->connection->prepareBindings($bindings);

        foreach ($bindings as &$binding) {
            if (is_object($binding)) {
                $binding = (string) $binding;
            }

            if (is_string($binding)) {
                $binding = $this->connection->getPdo()->quote($binding);
            }
        }

        return $bindings;
    }

    /**
     * Rename a view on the schema.
     *
     * @param string $from
     * @param string $to
     * @return void
     */
    public function renameView($from, $to)
    {
        $this->rename($from, $to);

The method rename() does not exist on Staudenmeir\LaravelMigrationViews\Schema\Builders\ManagesViews. Did you maybe mean renameView()?

    }

    /**
     * Drop a view from the schema.
     *
     * @param string $name
     * @param bool $ifExists
     * @return void
     */
    public function dropView($name, $ifExists = false)
    {
        $this->connection->statement(
            $this->grammar->compileDropView($name, $ifExists)
        );
    }

    /**
     * Drop a view from the schema if it exists.
     *
     * @param string $name
     * @return void
     */
    public function dropViewIfExists($name)
    {
        $this->dropView($name, true);
    }

    /**
     * Get the column listing for a given view.
     *
     * @param string $name
     * @return array
     */
    public function getViewColumnListing($name)
    {
        return $this->getColumnListing($name);

It seems like getColumnListing() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * Refresh a materialized view on the schema.
     *
     * @param string $name
     * @return void
     */
    public function refreshMaterializedView(string $name): void
    {
        $this->connection->statement(
            $this->grammar->compileRefreshMaterializedView($name)
        );
    }
}