Staudenmeir\LaravelCte\Query\Grammars\Traits\CompilesSqlServerExpressions

Complexity

Total Complexity

5

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	compileSelect()	0	19	3
A	compileTableExpression()	0	3	1
A	recursiveKeyword()	0	3	1

<?php

namespace Staudenmeir\LaravelCte\Query\Grammars\Traits;

use Illuminate\Database\Query\Builder;

trait CompilesSqlServerExpressions
{
    use CompilesExpressions {
        compileSelect as compileSelectParent;
    }

    /**
     * Compile a select query into SQL.
     *
     * @param \Illuminate\Database\Query\Builder $query
     * @return string
     */
    public function compileSelect(Builder $query)
    {
        if (!$query->offset) {
            return $this->compileSelectParent($query);
        }

        if (is_null($query->columns)) {

The condition is_null($query->columns) is always false.

            $query->columns = ['*'];
        }

        $expressions = $query->expressions;

The property expressions does not seem to exist on Illuminate\Database\Query\Builder.

        $query->expressions = [];

        $components = $this->compileComponents($query);

It seems like compileComponents() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $query->expressions = $expressions;

        return $this->compileAnsiOffset($query, $components);

It seems like compileAnsiOffset() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * Compile a common table expression for a query.
     *
     * @param string $sql
     * @param \Illuminate\Database\Query\Builder $query
     * @return string
     */
    protected function compileTableExpression($sql, $query)
    {
        return $this->compileExpressions($query, $query->expressions).' '.parent::compileTableExpression($sql, $query);

The property expressions does not seem to exist on Illuminate\Database\Query\Builder.

    }

    /**
     * Get the "recursive" keyword.
     *
     * @param array $expressions
     * @return string
     */
    protected function recursiveKeyword(array $expressions)

The parameter $expressions is not used and could be removed.

    {
        return '';
    }
}