Staudenmeir\LaravelCte\Query\Grammars\Traits\CompilesMySqlExpressions

Complexity

Total Complexity

3

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	compileInsertUsing()	0	5	1
A	compileCycle()	0	9	2

<?php

namespace Staudenmeir\LaravelCte\Query\Grammars\Traits;

use Illuminate\Database\Query\Builder;

trait CompilesMySqlExpressions
{
    use CompilesExpressions;

    /**
     * Compile the cycle detection.
     *
     * @param \Illuminate\Database\Query\Builder $query
     * @param array $expression
     * @return string
     */
    public function compileCycle(Builder $query, array $expression)

The parameter $query is not used and could be removed.

    {
        if (!$expression['cycle']) {
            return '';
        }

        $columns = $this->columnize($expression['cycle']['columns']);

It seems like columnize() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return " cycle $columns restrict";
    }

    /**
     * Compile an insert statement using a subquery into SQL.
     *
     * @param \Illuminate\Database\Query\Builder $query
     * @param array $columns
     * @param string $sql
     * @return string
     */
    public function compileInsertUsing(Builder $query, array $columns, string $sql)
    {
        $insert = "insert into {$this->wrapTable($query->from)} ({$this->columnize($columns)}) ";

It seems like wrapTable() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $insert.$this->compileExpressions($query, $query->expressions).' '.$sql;

The property expressions does not seem to exist on Illuminate\Database\Query\Builder.

    }
}