Staudenmeir\LaravelCte\Query\Grammars\Traits\CompilesExpressions

Complexity

Total Complexity

22

Size/Duplication

Total Lines	194
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	compileRecursionLimit()	0	7	2
A	getBindingsForUpdate()	0	3	1
A	compileExpressions()	0	23	6
A	compileDelete()	0	7	1
A	__construct()	0	5	1
A	compileInsertUsing()	0	12	1
A	prepareBindingsForUpdate()	0	7	1
A	compileCycle()	0	11	2
A	recursiveKeyword()	0	3	2
A	compileUpdate()	0	7	1
A	compileSelect()	0	15	4

<?php

namespace Staudenmeir\LaravelCte\Query\Grammars\Traits;

use Illuminate\Database\Query\Builder;
use Illuminate\Support\Str;
use Staudenmeir\LaravelCte\Query\Builder as CteBuilder;

trait CompilesExpressions
{
    /**
     * Create a new grammar instance.
     */
    public function __construct()
    {
        array_unshift($this->selectComponents, 'expressions');

        $this->selectComponents[] = 'recursionLimit';

The property selectComponents does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    /**
     * Compile the common table expressions.
     *
     * @param \Illuminate\Database\Query\Builder $query
     * @param array $expressions
     * @return string
     */
    public function compileExpressions(Builder $query, array $expressions)
    {
        if (!$expressions) {

The expression $expressions of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return '';
        }

        $recursive = $this->recursiveKeyword($expressions);

        $statements = [];

        foreach ($expressions as $expression) {
            $columns = $expression['columns'] ? '('.$this->columnize($expression['columns']).') ' : '';

It seems like columnize() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $materialized = !is_null($expression['materialized'])
                ? ($expression['materialized'] ? 'materialized ' : 'not materialized ')
                : '';

            $cycle = $this->compileCycle($query, $expression);

            $statements[] = $this->wrapTable($expression['name']).' '.$columns.'as '.$materialized.'('.$expression['query'].")$cycle";

It seems like wrapTable() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        return 'with '.$recursive.implode(', ', $statements);
    }

    /**
     * Get the "recursive" keyword.
     *
     * @param array $expressions
     * @return string
     */
    protected function recursiveKeyword(array $expressions)
    {
        return collect($expressions)->where('recursive', true)->isNotEmpty() ? 'recursive ' : '';

$expressions of type array is incompatible with the type Illuminate\Contracts\Support\Arrayable expected by parameter $value of collect().

    }

    /**
     * Compile the recursion limit.
     *
     * @param \Illuminate\Database\Query\Builder $query
     * @param int|null $recursionLimit
     * @return string
     */
    public function compileRecursionLimit(Builder $query, $recursionLimit)

The parameter $query is not used and could be removed.

    {
        if (is_null($recursionLimit)) {
            return '';
        }

        return 'option (maxrecursion '.(int) $recursionLimit.')';
    }

    /**
     * Compile the cycle detection.
     *
     * @param \Illuminate\Database\Query\Builder $query
     * @param array $expression
     * @return string
     */
    public function compileCycle(Builder $query, array $expression)

The parameter $query is not used and could be removed.

    {
        if (!$expression['cycle']) {
            return '';
        }

        $columns = $this->columnize($expression['cycle']['columns']);
        $markColumn = $this->wrap($expression['cycle']['markColumn']);

It seems like wrap() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $pathColumn = $this->wrap($expression['cycle']['pathColumn']);

        return " cycle $columns set $markColumn using $pathColumn";
    }

    /**
     * Compile a select query into SQL.
     *
     * @param \Illuminate\Database\Query\Builder $query
     * @return string
     */
    public function compileSelect(Builder $query)
    {
        $sql = parent::compileSelect($query);

        if ($query instanceof CteBuilder) {
            if ($query->unionExpressions) {

The expression $query->unionExpressions of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                $sql = $this->compileExpressions($query, $query->unionExpressions) . " $sql";
            }

            if (!is_null($query->unionRecursionLimit)) {

The condition is_null($query->unionRecursionLimit) is always false.

                $sql .= ' ' . $this->compileRecursionLimit($query, $query->unionRecursionLimit);
            }
        }

        return $sql;
    }

    /**
     * Compile an insert statement using a subquery into SQL.
     *
     * @param \Illuminate\Database\Query\Builder $query
     * @param array $columns
     * @param string $sql
     * @return string
     */
    public function compileInsertUsing(Builder $query, array $columns, string $sql)
    {
        $expressions = $this->compileExpressions($query, $query->expressions);

The property expressions does not seem to exist on Illuminate\Database\Query\Builder.

        $recursionLimit = $this->compileRecursionLimit($query, $query->recursionLimit);

The property recursionLimit does not seem to exist on Illuminate\Database\Query\Builder.

        $compiled = parent::compileInsertUsing($query, $columns, $sql);

        return (string) Str::of($compiled)
            ->prepend($expressions, ' ')
            ->append(' ', $recursionLimit)
            ->trim();
    }

    /**
     * Compile an update statement into SQL.
     *
     * @param \Illuminate\Database\Query\Builder $query
     * @param array $values
     * @return string
     */
    public function compileUpdate(Builder $query, array $values)
    {
        $compiled = parent::compileUpdate($query, $values);

        return (string) Str::of($compiled)
            ->prepend($this->compileExpressions($query, $query->expressions), ' ')

The property expressions does not seem to exist on Illuminate\Database\Query\Builder.

            ->trim();
    }

    /**
     * Prepare the bindings for an update statement.
     *
     * @param array $bindings
     * @param array $values
     * @return array
     */
    public function prepareBindingsForUpdate(array $bindings, array $values)
    {
        $values = array_merge($bindings['expressions'], $values);

        unset($bindings['expressions']);

        return parent::prepareBindingsForUpdate($bindings, $values);
    }

    /**
     * Get the bindings for an update statement.
     *
     * @param \Illuminate\Database\Query\Builder $query
     * @param array $bindings
     * @param array $values
     * @return array
     */
    public function getBindingsForUpdate(Builder $query, array $bindings, array $values)

The parameter $query is not used and could be removed.

    {
        return $this->prepareBindingsForUpdate($bindings, $values);
    }

    /**
     * Compile a delete statement into SQL.
     *
     * @param \Illuminate\Database\Query\Builder $query
     * @return string
     */
    public function compileDelete(Builder $query)
    {
        $compiled = parent::compileDelete($query);

        return (string) Str::of($compiled)
            ->prepend($this->compileExpressions($query, $query->expressions), ' ')

The property expressions does not seem to exist on Illuminate\Database\Query\Builder.

            ->trim();
    }
}