Staudenmeir\LaravelAdjacencyList\Eloquent\Builder::getModels()

Complexity

Conditions	4
Paths	3

Size

Total Lines	29
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	16
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function getModels($columns = ['*'])
    {
        $items = $this->query->get($columns)->all();

        if ($this->getConnection() instanceof PostgresConnection) {

The method getConnection() does not exist on Staudenmeir\LaravelAdjacencyList\Eloquent\Builder. Since you implemented __call, consider adding a @method annotation.

            $path = $this->model->getPathName();

            if (isset($items[0]->$path)) {
                $this->replacePathSeparator(
                    $items,
                    $path,

It seems like $path can also be of type Illuminate\Database\Eloquent\Builder; however, parameter $path of Staudenmeir\LaravelAdjacencyList\Eloquent\Builder::replacePathSeparator() does only seem to accept string, maybe add an additional type check?

                    $this->model->getPathSeparator()

It seems like $this->model->getPathSeparator() can also be of type Illuminate\Database\Eloquent\Builder; however, parameter $separator of Staudenmeir\LaravelAdjacencyList\Eloquent\Builder::replacePathSeparator() does only seem to accept string, maybe add an additional type check?

                );

                foreach ($this->model->getCustomPaths() as $path) {
                    $this->replacePathSeparator(
                        $items,
                        $path['name'],
                        $path['separator']
                    );
                }
            }
        }

        $table = (new $this->model)->getTable();

        $models = $this->model->hydrate($items)->each->setTable($table);

        return $models->all();
    }