staudenmeir / eloquent-json-relations

src/Relations/Postgres/HasOneOrManyThrough.php

<?php

namespace Staudenmeir\EloquentJsonRelations\Relations\Postgres;

use Illuminate\Database\Eloquent\Builder;

trait HasOneOrManyThrough
{
    use IsPostgresRelation;

    /**
     * Set the join clause on the query.
     *
     * @param \Illuminate\Database\Eloquent\Builder|null $query
     * @return void
     */
    protected function performJoin(?Builder $query = null)
    {
        $query = $query ?: $this->query;

        $farKey = $this->jsonColumn($query, $this->throughParent, $this->getQualifiedFarKeyName(), $this->secondLocalKey);

It seems like getQualifiedFarKeyName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $query->join($this->throughParent->getTable(), $this->getQualifiedParentKeyName(), '=', $farKey);

It seems like getQualifiedParentKeyName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if ($this->throughParentSoftDeletes()) {

It seems like throughParentSoftDeletes() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $query->whereNull($this->throughParent->getQualifiedDeletedAtColumn());
        }
    }

    /**
     * Add the constraints for a relationship query.
     *
     * @param \Illuminate\Database\Eloquent\Builder $query
     * @param \Illuminate\Database\Eloquent\Builder $parentQuery
     * @param array|mixed $columns
     * @return \Illuminate\Database\Eloquent\Builder
     */
    public function getRelationExistenceQuery(Builder $query, Builder $parentQuery, $columns = ['*'])
    {
        if ($parentQuery->getQuery()->from === $query->getQuery()->from) {
            return $this->getRelationExistenceQueryForSelfRelation($query, $parentQuery, $columns);
        }

        if ($parentQuery->getQuery()->from === $this->throughParent->getTable()) {
            return $this->getRelationExistenceQueryForThroughSelfRelation($query, $parentQuery, $columns);
        }

        $this->performJoin($query);

        $firstKey = $this->jsonColumn($query, $this->farParent, $this->getQualifiedFirstKeyName(), $this->localKey);

It seems like getQualifiedFirstKeyName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $query->select($columns)->whereColumn(

The expression return $query->select($columns)->whereColumn($this->getQualifiedLocalKeyName(), '=', $firstKey) also could return the type Illuminate\Database\Query\Builder which is incompatible with the documented return type Illuminate\Database\Eloquent\Builder.

            $this->getQualifiedLocalKeyName(),

It seems like getQualifiedLocalKeyName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            '=',
            $firstKey

$firstKey of type Illuminate\Database\Query\Expression is incompatible with the type null|string expected by parameter $second of Illuminate\Database\Query\Builder::whereColumn().

        );
    }

    /**
     * Add the constraints for a relationship query on the same table.
     *
     * @param \Illuminate\Database\Eloquent\Builder $query
     * @param \Illuminate\Database\Eloquent\Builder $parentQuery
     * @param array|mixed $columns
     * @return \Illuminate\Database\Eloquent\Builder
     */
    public function getRelationExistenceQueryForSelfRelation(Builder $query, Builder $parentQuery, $columns = ['*'])
    {
        $query->from($query->getModel()->getTable().' as '.$hash = $this->getRelationCountHash());

It seems like getRelationCountHash() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $farKey = $this->jsonColumn($query, $this->throughParent, $hash.'.'.$this->secondKey, $this->secondLocalKey);

        $query->join($this->throughParent->getTable(), $this->getQualifiedParentKeyName(), '=', $farKey);

        $query->getModel()->setTable($hash);

        $firstKey = $this->jsonColumn($query, $this->farParent, $this->getQualifiedFirstKeyName(), $this->localKey);

        return $query->select($columns)->whereColumn(

The expression return $query->select($columns)->whereColumn($parentQuery->getQuery()->from . '.' . $this->localKey, '=', $firstKey) also could return the type Illuminate\Database\Query\Builder which is incompatible with the documented return type Illuminate\Database\Eloquent\Builder.

            $parentQuery->getQuery()->from.'.'.$this->localKey,

Are you sure $parentQuery->getQuery()->from of type Illuminate\Database\Query\Expression|string can be used in concatenation?

            '=',
            $firstKey

$firstKey of type Illuminate\Database\Query\Expression is incompatible with the type null|string expected by parameter $second of Illuminate\Database\Query\Builder::whereColumn().

        );
    }

    /**
     * Add the constraints for a relationship query on the same table as the through parent.
     *
     * @param \Illuminate\Database\Eloquent\Builder $query
     * @param \Illuminate\Database\Eloquent\Builder $parentQuery
     * @param array|mixed $columns
     * @return \Illuminate\Database\Eloquent\Builder
     */
    public function getRelationExistenceQueryForThroughSelfRelation(Builder $query, Builder $parentQuery, $columns = ['*'])
    {
        $table = $this->throughParent->getTable().' as '.$hash = $this->getRelationCountHash();

        $farKey = $this->jsonColumn($query, $this->throughParent, $this->getQualifiedFarKeyName(), $this->secondLocalKey);

        $query->join($table, $hash.'.'.$this->secondLocalKey, '=', $farKey);

        if ($this->throughParentSoftDeletes()) {
            $query->whereNull($hash.'.'.$this->throughParent->getDeletedAtColumn());
        }

        $firstKey = $this->jsonColumn($query, $this->farParent, $hash.'.'.$this->firstKey, $this->localKey);

        return $query->select($columns)->whereColumn(

The expression return $query->select($columns)->whereColumn($parentQuery->getQuery()->from . '.' . $this->localKey, '=', $firstKey) also could return the type Illuminate\Database\Query\Builder which is incompatible with the documented return type Illuminate\Database\Eloquent\Builder.

            $parentQuery->getQuery()->from.'.'.$this->localKey,

Are you sure $parentQuery->getQuery()->from of type Illuminate\Database\Query\Expression|string can be used in concatenation?

            '=',
            $firstKey

$firstKey of type Illuminate\Database\Query\Expression is incompatible with the type null|string expected by parameter $second of Illuminate\Database\Query\Builder::whereColumn().

        );
    }
}