staudenmeir / eloquent-json-relations

src/Relations/HasOneJson.php

<?php

namespace Staudenmeir\EloquentJsonRelations\Relations;

use Illuminate\Database\Eloquent\Collection;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\Concerns\SupportsDefaultModels;
use Illuminate\Database\Eloquent\Relations\HasOneOrMany;

class HasOneJson extends HasManyJson
{
    use SupportsDefaultModels;

    /** @inheritDoc */
    public function getResults()
    {
        if (is_null($this->getParentKey())) {
            return $this->getDefaultFor($this->parent);
        }

        return $this->first() ?: $this->getDefaultFor($this->parent);
    }

    /** @inheritDoc */
    public function initRelation(array $models, $relation)
    {
        foreach ($models as $model) {
            $model->setRelation($relation, $this->getDefaultFor($model));
        }

        return $models;
    }

    /** @inheritDoc */
    public function match(array $models, Collection $results, $relation)
    {
        return $this->matchOne($models, $results, $relation);
    }

    /** @inheritDoc */
    public function matchOne(array $models, Collection $results, $relation)
    {
        if ($this->hasCompositeKey()) {
            $this->matchWithCompositeKey($models, $results, $relation, 'one');
        } else {
            HasOneOrMany::matchOneOrMany($models, $results, $relation, 'one');
        }

        if ($this->key) {
            foreach ($models as $model) {
                $model->setRelation(
                    $relation,
                    $this->hydratePivotRelation(
                        new Collection(
                            array_filter([$model->$relation])

array_filter(array($model->$relation)) of type array is incompatible with the type Illuminate\Contracts\Support\Arrayable expected by parameter $items of Illuminate\Database\Eloquent\Collection::__construct().

                        ),
                        $model,
                        fn (Model $model) => $model->{$this->getPathName()}
                    )->first()
                );
            }
        }

        return $models;
    }

    /** @inheritDoc */
    public function newRelatedInstanceFor(Model $parent)

The parameter $parent is not used and could be removed.

    {
        return $this->related->newInstance();
    }
}