Staudenmeir\EloquentJsonRelations\Relations\Traits\Concatenation\IsConcatenableRelation

Complexity

Total Complexity

2

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	mergeWhereConstraints()	0	9	1
A	addEagerConstraintsToDeepRelationship()	0	5	1

<?php

namespace Staudenmeir\EloquentJsonRelations\Relations\Traits\Concatenation;

use Illuminate\Database\Eloquent\Builder;

trait IsConcatenableRelation
{
    /**
     * Set the constraints for an eager load of the deep relation.
     *
     * @param \Illuminate\Database\Eloquent\Builder $query
     * @param array $models
     * @return void
     */
    public function addEagerConstraintsToDeepRelationship(Builder $query, array $models): void
    {
        $this->addEagerConstraints($models);

The method addEagerConstraints() does not exist on Staudenmeir\EloquentJsonRelations\Relations\Traits\Concatenation\IsConcatenableRelation. Did you maybe mean addEagerConstraintsToDeepRelationship()?

        $this->mergeWhereConstraints($query, $this->query);
    }

    /**
     * Merge the where constraints from another query to the current query.
     *
     * @param \Illuminate\Database\Eloquent\Builder $query
     * @param \Illuminate\Database\Eloquent\Builder $from
     * @return \Illuminate\Database\Eloquent\Builder
     */
    public function mergeWhereConstraints(Builder $query, Builder $from): Builder
    {
        $whereBindings = $from->getQuery()->getRawBindings()['where'] ?? [];

        $wheres = $from->getQuery()->wheres;

        return $query->withoutGlobalScopes(

The expression return $query->withoutGlobalScopes($from->removedScopes())->mergeWheres($wheres, $whereBindings) could return the type Illuminate\Database\Query\Builder which is incompatible with the type-hinted return Illuminate\Database\Eloquent\Builder. Consider adding an additional type-check to rule them out.

            $from->removedScopes()
        )->mergeWheres($wheres, $whereBindings);
    }
}