Staudenmeir\EloquentHasManyDeep\Eloquent\Relations\Traits\HasEagerLoading

Complexity

Total Complexity

8

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	match()	0	15	4
A	addEagerConstraints()	0	17	4

<?php

namespace Staudenmeir\EloquentHasManyDeep\Eloquent\Relations\Traits;

use Illuminate\Database\Eloquent\Collection;

trait HasEagerLoading
{
    /**
     * Set the constraints for an eager load of the relation.
     *
     * @param array $models
     * @return void
     */
    public function addEagerConstraints(array $models)
    {
        if ($this->customEagerConstraintsCallback) {
            ($this->customEagerConstraintsCallback)($this->query, $models);
            return;
        }

        if ($this->hasLeadingCompositeKey()) {

It seems like hasLeadingCompositeKey() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $this->addEagerConstraintsWithCompositeKey($models);

The method addEagerConstraintsWithCompositeKey() does not exist on Staudenmeir\EloquentHasManyDeep\Eloquent\Relations\Traits\HasEagerLoading. Did you maybe mean addEagerConstraints()?

        } else {
            parent::addEagerConstraints($models);

            if (is_array($this->foreignKeys[0])) {
                $this->query->where(
                    $this->throughParent->qualifyColumn($this->foreignKeys[0][0]),
                    '=',
                    $this->farParent->getMorphClass()
                );
            }
        }
    }

    /**
     * Match the eagerly loaded results to their parents.
     *
     * @param array $models
     * @param \Illuminate\Database\Eloquent\Collection $results
     * @param string $relation
     * @return array
     */
    public function match(array $models, Collection $results, $relation)
    {
        if ($this->customEagerMatchingCallbacks) {
            foreach ($this->customEagerMatchingCallbacks as $callback) {
                $models = $callback($models, $results, $relation);
            }

            return $models;
        }

        if ($this->hasLeadingCompositeKey()) {
            return $this->matchWithCompositeKey($models, $results, $relation);

It seems like matchWithCompositeKey() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        return parent::match($models, $results, $relation);
    }
}