BuildsGroupLimitQueries::get() - Code Metrics - Inspection of "Refactor code for merge packages" - staudenmeir/eloquent-eager-limit - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 0d1e3a...a8104a )

by Jonas

created 2022-03-16 22:49 UTC

BuildsGroupLimitQueries::get() A

↳ Parent: BuildsGroupLimitQueries

Complexity

Conditions	3
Paths	3

Size

Total Lines	21
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	11
c	1
b	0
f	0
nc	3
nop	1
dl	0
loc	21
ccs	11
cts	11
cp	1
crap	3
rs	9.9

<?php

namespace Staudenmeir\EloquentEagerLimit\Traits;

trait BuildsGroupLimitQueries
{
    /**
     * The maximum number of records to return per group.
     *
     * @var array
     */
    public $groupLimit;

    /**
     * Add a "group limit" clause to the query.
     *
     * @param int $value
     * @param string $column
     * @return $this
     */
    public function groupLimit($value, $column)
    {
        if ($value >= 0) {
            $this->groupLimit = compact('value', 'column');
        }

        return $this;
    }

    /**
     * Execute the query as a "select" statement.
     *
     * @param array $columns
     * @return \Illuminate\Support\Collection
     */
    public function get($columns = ['*'])
    {
        $items = parent::get($columns);

        if (!$this->groupLimit) {

            return $items;
        }

        $column = last(explode('.', $this->groupLimit['column']));

        $keys = [
            'laravel_row',
            '@laravel_partition := '.$this->grammar->wrap($column),
            '@laravel_partition := '.$this->grammar->wrap('pivot_'.$column),
        ];

        foreach ($items as $item) {
            unset($item->{$keys[0]}, $item->{$keys[1]}, $item->{$keys[2]});
        }

        return $items;
    }
}


1		<?php
2
3		namespace Staudenmeir\EloquentEagerLimit\Traits;
4
5		trait BuildsGroupLimitQueries
6		{
7		/**
8		* The maximum number of records to return per group.
9		*
10		* @var array
11		*/
12		public $groupLimit;
13
14		/**
15		* Add a "group limit" clause to the query.
16		*
17		* @param int $value
18		* @param string $column
19		* @return $this
20		*/
21	116	public function groupLimit($value, $column)
22		{
23	116	if ($value >= 0) {
24	116	$this->groupLimit = compact('value', 'column');
25		}
26
27	116	return $this;
28		}
29
30		/**
31		* Execute the query as a "select" statement.
32		*
33		* @param array $columns
34		* @return \Illuminate\Support\Collection
35		*/
36	128	public function get($columns = ['*'])
37		{
38	128	$items = parent::get($columns);
39
40	128	if (!$this->groupLimit) {
		0 ignored issues – show Bug Best Practice introduced 2018-12-18 18:28 UTC by Report Bug Copy Issue Report The expression `$this->groupLimit` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
41	128	return $items;
42		}
43
44	96	$column = last(explode('.', $this->groupLimit['column']));
45
46	96	$keys = [
47		'laravel_row',
48	96	'@laravel_partition := '.$this->grammar->wrap($column),
49	96	'@laravel_partition := '.$this->grammar->wrap('pivot_'.$column),
50		];
51
52	96	foreach ($items as $item) {
53	96	unset($item->{$keys[0]}, $item->{$keys[1]}, $item->{$keys[2]});
54		}
55
56	96	return $items;
57		}
58		}
59

staudenmeir / eloquent-eager-limit

Push — master ( 0d1e3a...a8104a )

BuildsGroupLimitQueries::get() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like