Staudenmeir\EloquentEagerLimit\Relations\HasOneOrManyThrough

Complexity

Total Complexity

4

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Test Coverage

Coverage

88.89%

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	limit()	0	17	4

<?php

namespace Staudenmeir\EloquentEagerLimit\Relations;

use Illuminate\Database\Query\Grammars\MySqlGrammar;

trait HasOneOrManyThrough
{
    use HasLimit;

    /**
     * Set the "limit" value of the query.
     *
     * @param int $value
     * @return $this
     */
    public function limit($value)
    {
        if ($this->farParent->exists) {
            $this->query->limit($value);
        } else {
            $column = $this->getQualifiedFirstKeyName();

It seems like getQualifiedFirstKeyName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $grammar = $this->query->getQuery()->getGrammar();

            if ($grammar instanceof MySqlGrammar && $grammar->useLegacyGroupLimit($this->query->getQuery())) {
                $column = 'laravel_through_key';
            }

            $this->query->groupLimit($value, $column);
        }

        return $this;
    }
}