SymfonyRequestAdapter::getUri() - Code Metrics - Inspection of "Request agnostic" - starweb/starlit-request-authenticator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 1.0.x-dev (#4)

by Patrick

created 2019-03-14 09:56 UTC

SymfonyRequestAdapter::getUri() A

↳ Parent: SymfonyRequestAdapter

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	6
cts	6
cp	1
rs	9.9332
c	0
b	0
f	0
cc	2
nc	2
nop	0
crap	2

<?php declare(strict_types=1);

namespace Starlit\Request\Authenticator\Hmac\Adapter;

use Symfony\Component\HttpFoundation\Request;

class SymfonyRequestAdapter implements RequestAdapterInterface
{
    /**
     * @var Request
     */
    private $request;

    public function __construct(Request $request)

    {
        $this->request = $request;
    }

    public function getMethod(): string
    {
        return $this->request->getMethod();
    }

    /**
     * helper method to build a uri without reordering url parameters in a query string alphabetically
     * which the interal Request::getUri function does (called normalize)
     *
     * @see SymfonyRequest::getUri()
     * @see SymfonyRequest::getQueryString()
     * @see SymfonyRequest::normalizeQueryString()
     */
    public function getUri(): string
    {
        $queryString = $this->request->server->get('QUERY_STRING');
        if (!empty($queryString)) {
            $queryString = '?' . $queryString;
        }

        return $this->request->getSchemeAndHttpHost()
            . $this->request->getBaseUrl() . $this->request->getPathInfo() . $queryString;
    }

    public function getContent(): string
    {
        return $this->request->getContent();
    }

    public function getHeader(string $key): ?string
    {
        return $this->request->headers->get($key);
    }
}


1		<?php declare(strict_types=1);
2
3		namespace Starlit\Request\Authenticator\Hmac\Adapter;
4
5		use Symfony\Component\HttpFoundation\Request;
6
7		class SymfonyRequestAdapter implements RequestAdapterInterface
8		{
9		/**
10		* @var Request
11		*/
12		private $request;
13
14	1	public function __construct(Request $request)
		0 ignored issues – show Bug introduced 2019-03-12 09:25 UTC by Report Bug Copy Issue Report You have injected the Request via parameter `$request`. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via `getCurrentRequest()`. Loading history...
15		{
16	1	$this->request = $request;
17	1	}
18
19	1	public function getMethod(): string
20		{
21	1	return $this->request->getMethod();
22		}
23
24		/**
25		* helper method to build a uri without reordering url parameters in a query string alphabetically
26		* which the interal Request::getUri function does (called normalize)
27		*
28		* @see SymfonyRequest::getUri()
29		* @see SymfonyRequest::getQueryString()
30		* @see SymfonyRequest::normalizeQueryString()
31		*/
32	1	public function getUri(): string
33		{
34	1	$queryString = $this->request->server->get('QUERY_STRING');
35	1	if (!empty($queryString)) {
36	1	$queryString = '?' . $queryString;
37		}
38
39	1	return $this->request->getSchemeAndHttpHost()
40	1	. $this->request->getBaseUrl() . $this->request->getPathInfo() . $queryString;
41		}
42
43	1	public function getContent(): string
44		{
45	1	return $this->request->getContent();
46		}
47
48	1	public function getHeader(string $key): ?string
49		{
50	1	return $this->request->headers->get($key);
51		}
52		}
53

starweb / starlit-request-authenticator

Pull Request — 1.0.x-dev (#4)

SymfonyRequestAdapter::getUri() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like