Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like AbstractDbEntity often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use AbstractDbEntity, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
22 | abstract class AbstractDbEntity implements \Serializable |
||
23 | { |
||
24 | /** |
||
25 | * The database table name (meant to be overridden). |
||
26 | * |
||
27 | * @var string |
||
28 | */ |
||
29 | protected static $dbTableName; |
||
30 | |||
31 | /** |
||
32 | * Entity's database properties and their attributes (meant to be overridden). |
||
33 | * Example format: |
||
34 | * |
||
35 | * $dbProperties = [ |
||
36 | * 'productId' => ['type' => 'int'], |
||
37 | * 'otherId' => ['type' => 'int', 'required' => true, 'validate' => false], |
||
38 | * 'name' => ['type' => 'string', 'maxLength' => 10, 'required' => true, 'default' => 'Some name'], |
||
39 | * ]; |
||
40 | * |
||
41 | * 'type' => 'int' Corresponding PHP type (required). |
||
42 | * 'validate' => false Turn off data validation, for example on required key fields that are set internally. |
||
43 | * 'required' => true The value have to be set (not '', null, false) |
||
44 | * 'nonEmpty' => true The value should not be empty ('', 0, null) |
||
45 | * |
||
46 | * Properties correspond to database table's columns but words are |
||
47 | * camel cased instead of separated with underscore (_) as in the database. |
||
48 | * |
||
49 | * @var array |
||
50 | */ |
||
51 | protected static $dbProperties = []; |
||
52 | |||
53 | /** |
||
54 | * Object database field name that is used for primary key (meant to be overridden). |
||
55 | * Should be camel cased as it maps to the dbFields array. |
||
56 | * |
||
57 | * @var string|array |
||
58 | */ |
||
59 | protected static $primaryDbPropertyKey; |
||
60 | |||
61 | /** |
||
62 | * @var array |
||
63 | */ |
||
64 | private static $cachedDefaultDbData = []; |
||
65 | |||
66 | /** |
||
67 | * @var array |
||
68 | */ |
||
69 | private static $cachedDbPropertyNames; |
||
70 | |||
71 | /** |
||
72 | * @var array |
||
73 | */ |
||
74 | private static $cachedDbFieldNames; |
||
75 | |||
76 | /** |
||
77 | * @var array |
||
78 | */ |
||
79 | private static $typeDefaults = [ |
||
80 | 'string' => '', |
||
81 | 'int' => 0, |
||
82 | 'float' => 0.0, |
||
83 | 'bool' => false, |
||
84 | ]; |
||
85 | |||
86 | /** |
||
87 | * Database row data with field names and their values. |
||
88 | * |
||
89 | * @var array |
||
90 | */ |
||
91 | private $dbData = []; |
||
92 | |||
93 | /** |
||
94 | * Database fields that has had their value modified since init/load. |
||
95 | * |
||
96 | * @var array |
||
97 | */ |
||
98 | private $modifiedDbProperties = []; |
||
99 | |||
100 | /** |
||
101 | * @var bool |
||
102 | */ |
||
103 | private $deleteFromDbOnSave = false; |
||
104 | |||
105 | /** |
||
106 | * @var bool |
||
107 | */ |
||
108 | private $deleted = false; |
||
109 | |||
110 | /** |
||
111 | * @var bool |
||
112 | */ |
||
113 | private $forceDbInsertOnSave = false; |
||
114 | |||
115 | /** |
||
116 | * Constructor. |
||
117 | * |
||
118 | * @param mixed $primaryDbValueOrRowData |
||
119 | */ |
||
120 | 66 | public function __construct($primaryDbValueOrRowData = null) |
|
121 | { |
||
122 | 66 | self::checkStaticProperties(); |
|
123 | |||
124 | // Set default values |
||
125 | 65 | $this->dbData = $this->getDefaultDbData(); |
|
126 | |||
127 | // Override default values with provided values |
||
128 | 65 | if ($primaryDbValueOrRowData !== null) { |
|
129 | 13 | $this->setPrimaryDbValueOrRowData($primaryDbValueOrRowData); |
|
130 | } |
||
131 | 65 | } |
|
132 | |||
133 | /** |
||
134 | * Make sure that class has all necessary static properties set. |
||
135 | */ |
||
136 | 66 | private static function checkStaticProperties() |
|
137 | { |
||
138 | 66 | static $checkedClasses = []; |
|
139 | 66 | if (!in_array(static::class, $checkedClasses)) { |
|
140 | 7 | if (empty(static::$dbTableName) |
|
141 | 6 | || empty(static::$dbProperties) |
|
142 | 6 | || empty(static::$primaryDbPropertyKey) |
|
143 | 6 | || (is_scalar(static::$primaryDbPropertyKey) |
|
144 | 6 | && !isset(static::$dbProperties[static::$primaryDbPropertyKey]['type'])) |
|
145 | 6 | || (is_array(static::$primaryDbPropertyKey) |
|
146 | 7 | && !Arr::allIn(static::$primaryDbPropertyKey, array_keys(static::$dbProperties))) |
|
147 | ) { |
||
148 | 1 | throw new \LogicException("All db entity's static properties not set"); |
|
149 | } |
||
150 | 6 | $checkedClasses[] = static::class; |
|
151 | } |
||
152 | 65 | } |
|
153 | |||
154 | /** |
||
155 | * @param mixed $primaryDbValueOrRowData |
||
156 | */ |
||
157 | 13 | public function setPrimaryDbValueOrRowData($primaryDbValueOrRowData = null) |
|
158 | { |
||
159 | // Row data would ba an associative array (not sequential, that would indicate a multi column primary key) |
||
160 | 13 | if (is_array($primaryDbValueOrRowData) && !isset($primaryDbValueOrRowData[0])) { |
|
161 | 1 | $this->setDbDataFromRow($primaryDbValueOrRowData); |
|
162 | } else { |
||
163 | 12 | $this->setPrimaryDbValue($primaryDbValueOrRowData); |
|
164 | } |
||
165 | 13 | } |
|
166 | |||
167 | /** |
||
168 | * Get all default database values. |
||
169 | * |
||
170 | * @return array |
||
171 | */ |
||
172 | 65 | public function getDefaultDbData() |
|
173 | { |
||
174 | 65 | $class = get_called_class(); |
|
175 | 65 | if (!isset(self::$cachedDefaultDbData[$class])) { |
|
176 | 6 | self::$cachedDefaultDbData[$class] = []; |
|
177 | 6 | foreach (array_keys(static::$dbProperties) as $propertyName) { |
|
178 | 6 | self::$cachedDefaultDbData[$class][$propertyName] = $this->getDefaultDbPropertyValue($propertyName); |
|
179 | } |
||
180 | } |
||
181 | |||
182 | 65 | return self::$cachedDefaultDbData[$class]; |
|
183 | } |
||
184 | |||
185 | /** |
||
186 | * Get default db value (can be overridden if non static default values need to be used). |
||
187 | * |
||
188 | * @param string $propertyName |
||
189 | * @return mixed |
||
190 | */ |
||
191 | 6 | public function getDefaultDbPropertyValue($propertyName) |
|
192 | { |
||
193 | // A default value is set |
||
194 | 6 | if (array_key_exists('default', static::$dbProperties[$propertyName])) { |
|
195 | 4 | $defaultValue = static::$dbProperties[$propertyName]['default']; |
|
196 | // No default value set, use default for type |
||
197 | } else { |
||
198 | 6 | $defaultValue = self::$typeDefaults[static::$dbProperties[$propertyName]['type']]; |
|
199 | } |
||
200 | |||
201 | 6 | return $defaultValue; |
|
202 | } |
||
203 | |||
204 | /** |
||
205 | * @return mixed |
||
206 | */ |
||
207 | 21 | public function getPrimaryDbValue() |
|
208 | { |
||
209 | 21 | if (is_array(static::$primaryDbPropertyKey)) { |
|
210 | 3 | $primaryValues = []; |
|
211 | 3 | foreach (static::$primaryDbPropertyKey as $keyPart) { |
|
212 | 3 | $primaryValues[] = $this->dbData[$keyPart]; |
|
213 | } |
||
214 | |||
215 | 3 | return $primaryValues; |
|
216 | } |
||
217 | |||
218 | 18 | return $this->dbData[static::$primaryDbPropertyKey]; |
|
219 | } |
||
220 | |||
221 | /** |
||
222 | * @param mixed $primaryDbValue |
||
223 | */ |
||
224 | 17 | public function setPrimaryDbValue($primaryDbValue) |
|
225 | { |
||
226 | 17 | if (is_array(static::$primaryDbPropertyKey)) { |
|
227 | 3 | if (!is_array($primaryDbValue)) { |
|
228 | 1 | throw new \InvalidArgumentException("Primary db value should be an array"); |
|
229 | } |
||
230 | |||
231 | 2 | reset($primaryDbValue); |
|
232 | 2 | foreach (static::$primaryDbPropertyKey as $keyPart) { |
|
233 | 2 | $this->dbData[$keyPart] = current($primaryDbValue); |
|
234 | 2 | next($primaryDbValue); |
|
235 | } |
||
236 | } else { |
||
237 | 14 | $this->dbData[static::$primaryDbPropertyKey] = $primaryDbValue; |
|
238 | } |
||
239 | 16 | } |
|
240 | |||
241 | /** |
||
242 | * @return bool |
||
243 | */ |
||
244 | 9 | public function isNewDbEntity() |
|
255 | |||
256 | /** |
||
257 | * @return bool |
||
258 | */ |
||
259 | 8 | public function shouldInsertOnDbSave() |
|
264 | |||
265 | /** |
||
266 | * Set a row field value. |
||
267 | * |
||
268 | * @param string $property |
||
269 | * @param mixed $value |
||
270 | * @param bool $setAsModified |
||
271 | * @param bool $force |
||
272 | */ |
||
273 | 25 | protected function setDbValue($property, $value, $setAsModified = true, $force = false) |
|
274 | { |
||
275 | 25 | if (!isset(static::$dbProperties[$property])) { |
|
276 | 1 | throw new \InvalidArgumentException("No database entity property[{$property}] exists"); |
|
277 | } |
||
278 | |||
279 | // Don't set type if value is null and allowed (allowed currently indicated by default => null) |
||
280 | 24 | $nullIsAllowed = (array_key_exists('default', static::$dbProperties[$property]) |
|
281 | 24 | && static::$dbProperties[$property]['default'] === null); |
|
282 | 24 | if (!($value === null && $nullIsAllowed)) { |
|
283 | 24 | $type = static::$dbProperties[$property]['type']; |
|
284 | // Set null when empty and default is null |
||
285 | 24 | if ($value === '' && $nullIsAllowed) { |
|
286 | 1 | $value = null; |
|
|
|||
287 | } else { |
||
288 | 24 | settype($value, $type); |
|
289 | } |
||
290 | } |
||
291 | |||
292 | 24 | if ($this->dbData[$property] !== $value || $force) { |
|
293 | 22 | $this->dbData[$property] = $value; |
|
294 | |||
295 | 22 | if ($setAsModified && !$this->isDbPropertyModified($property)) { |
|
296 | 15 | $this->modifiedDbProperties[] = $property; |
|
297 | } |
||
298 | } |
||
299 | 24 | } |
|
300 | |||
301 | /** |
||
302 | * Get a database field value. |
||
303 | * |
||
304 | * @param string $property |
||
305 | * @return mixed |
||
306 | */ |
||
307 | 8 | protected function getDbValue($property) |
|
311 | |||
312 | /** |
||
313 | * Get raw (with underscore as word separator as it is formatted in database) |
||
314 | * field name from a object field property name (camelcased). |
||
315 | * |
||
316 | * @param string $propertyName |
||
317 | * @return string |
||
318 | */ |
||
319 | 18 | public static function getDbFieldName($propertyName) |
|
327 | |||
328 | /** |
||
329 | * Get object field property name (camelCased) from database field name (underscore separated). |
||
330 | * |
||
331 | * @param string $dbFieldName |
||
332 | * @return string |
||
333 | */ |
||
334 | 7 | public static function getDbPropertyName($dbFieldName) |
|
342 | |||
343 | /** |
||
344 | * @return bool |
||
345 | */ |
||
346 | 5 | public function hasModifiedDbProperties() |
|
350 | |||
351 | /** |
||
352 | * @param string $property |
||
353 | * @return bool |
||
354 | */ |
||
355 | 16 | public function isDbPropertyModified($property) |
|
359 | |||
360 | /** |
||
361 | * @return array |
||
362 | */ |
||
363 | 5 | public function getModifiedDbData() |
|
367 | |||
368 | /** |
||
369 | * @param string $property |
||
370 | */ |
||
371 | public function clearModifiedDbProperty($property) |
||
377 | |||
378 | /** |
||
379 | */ |
||
380 | 4 | public function clearModifiedDbProperties() |
|
384 | |||
385 | /** |
||
386 | * Magic method used to automate getters & setters for row data. |
||
387 | * |
||
388 | * @param string $name |
||
389 | * @param array $arguments |
||
390 | * @return mixed |
||
391 | */ |
||
392 | 19 | public function __call($name, array $arguments = []) |
|
409 | |||
410 | /** |
||
411 | * Set database fields' data. |
||
412 | * |
||
413 | * @param array $data |
||
414 | */ |
||
415 | 3 | public function setDbData(array $data) |
|
423 | |||
424 | /** |
||
425 | * Set db data from raw database row data with field names in database format. |
||
426 | * |
||
427 | * @param array $rowData |
||
428 | */ |
||
429 | 7 | public function setDbDataFromRow(array $rowData) |
|
449 | |||
450 | /** |
||
451 | * @return array |
||
452 | */ |
||
453 | 8 | public function getDbData() |
|
457 | |||
458 | /** |
||
459 | * @return array |
||
460 | */ |
||
461 | 2 | public function getDbDataWithoutPrimary() |
|
475 | |||
476 | /** |
||
477 | * @param bool $deleteFromDbOnSave |
||
478 | */ |
||
479 | 3 | public function setDeleteFromDbOnSave($deleteFromDbOnSave = true) |
|
483 | |||
484 | /** |
||
485 | * @return bool |
||
486 | */ |
||
487 | 10 | public function shouldBeDeletedFromDbOnSave() |
|
491 | |||
492 | /** |
||
493 | * @return bool |
||
494 | */ |
||
495 | 1 | public function isDeleted() |
|
499 | |||
500 | /** |
||
501 | * @param bool $deleted |
||
502 | */ |
||
503 | 3 | public function setDeleted($deleted = true) |
|
507 | |||
508 | /** |
||
509 | * @param bool $forceDbInsertOnSave |
||
510 | */ |
||
511 | 5 | public function setForceDbInsertOnSave($forceDbInsertOnSave) |
|
515 | |||
516 | /** |
||
517 | * @return bool |
||
518 | */ |
||
519 | 9 | public function shouldForceDbInsertOnSave() |
|
523 | |||
524 | /** |
||
525 | * @param string $propertyName |
||
526 | * @return int|null |
||
527 | */ |
||
528 | 6 | public static function getDbPropertyMaxLength($propertyName) |
|
534 | |||
535 | /** |
||
536 | * @param string $propertyName |
||
537 | * @return bool |
||
538 | */ |
||
539 | 2 | public static function getDbPropertyRequired($propertyName) |
|
545 | |||
546 | /** |
||
547 | * @param string $propertyName |
||
548 | * @return bool |
||
549 | */ |
||
550 | 3 | public static function getDbPropertyNonEmpty($propertyName) |
|
556 | |||
557 | /** |
||
558 | * Get validator for object's database data. |
||
559 | * |
||
560 | * @param ValidatorTranslatorInterface|SymfonyTranslatorInterface|null $translator |
||
561 | * @return Validator |
||
562 | */ |
||
563 | 3 | public function getDbDataValidator($translator = null) |
|
583 | |||
584 | /** |
||
585 | * Validate and (if no error messages) set database data. |
||
586 | * |
||
587 | * @param array $data The data (e.g. from a form post) to be validated and set |
||
588 | * @param ValidatorTranslatorInterface|SymfonyTranslatorInterface|null $translator |
||
589 | * @return array An array with all (if any) of error messages |
||
590 | */ |
||
591 | 2 | public function validateAndSetDbData(array $data, $translator = null) |
|
606 | |||
607 | /** |
||
608 | * @return string|array |
||
609 | */ |
||
610 | 17 | public static function getPrimaryDbPropertyKey() |
|
614 | |||
615 | /** |
||
616 | * @return string|array |
||
617 | */ |
||
618 | 9 | public static function getPrimaryDbFieldKey() |
|
633 | |||
634 | /** |
||
635 | * Return array with db property names. |
||
636 | * |
||
637 | * @param array $exclude |
||
638 | * @return array |
||
639 | */ |
||
640 | 1 | public static function getDbPropertyNames(array $exclude = []) |
|
646 | |||
647 | /** |
||
648 | * Return array with raw db field names. |
||
649 | * |
||
650 | * @param array $exclude |
||
651 | * @return array |
||
652 | */ |
||
653 | 3 | public static function getDbFieldNames(array $exclude = []) |
|
662 | |||
663 | |||
664 | /** |
||
665 | * Get raw database field names prefixed (id, name becomes t.id, t.name etc.). |
||
666 | * |
||
667 | * @param string $dbTableAlias |
||
668 | * @param array $exclude |
||
669 | * @return array |
||
670 | */ |
||
671 | 1 | public static function getPrefixedDbFieldNames($dbTableAlias, array $exclude = []) |
|
675 | |||
676 | /** |
||
677 | * Get database columns transformed from e.g. "productId, date" to "p.product_id AS p_product_id, p.date AS p_date". |
||
678 | * |
||
679 | * @param string $dbTableAlias |
||
680 | * @param array $exclude |
||
681 | * @return array |
||
682 | */ |
||
683 | 1 | public static function getAliasedDbFieldNames($dbTableAlias, array $exclude = []) |
|
694 | |||
695 | /** |
||
696 | * Filters a full db item array by it's table alias and the strips the table alias. |
||
697 | * |
||
698 | * @param array $rowData |
||
699 | * @param string $dbTableAlias |
||
700 | * @param bool $skipStrip For cases when you want to filter only (no stripping) |
||
701 | * @return array |
||
702 | */ |
||
703 | 1 | public static function filterStripDbRowData(array $rowData, $dbTableAlias, $skipStrip = false) |
|
717 | |||
718 | /** |
||
719 | * @return string |
||
720 | */ |
||
721 | 8 | public static function getDbTableName() |
|
725 | |||
726 | /** |
||
727 | * Method to handle the serialization of this object. |
||
728 | * |
||
729 | * Implementation of Serializable interface. If descendant private properties |
||
730 | * should be serialized, they need to be visible to this parent (i.e. not private). |
||
731 | * |
||
732 | * @return string |
||
733 | */ |
||
734 | 2 | public function serialize() |
|
738 | |||
739 | /** |
||
740 | * Method to handle the unserialization of this object. |
||
741 | * |
||
742 | * Implementation of Serializable interface. If descendant private properties |
||
743 | * should be unserialized, they need to be visible to this parent (i.e. not private). |
||
744 | * |
||
745 | * @param string $serializedObject |
||
746 | */ |
||
747 | 1 | public function unserialize($serializedObject) |
|
755 | |||
756 | /** |
||
757 | * Merges other object's modified database data into this object. |
||
758 | * |
||
759 | * @param AbstractDbEntity $otherEntity |
||
760 | */ |
||
761 | 1 | public function mergeWith(AbstractDbEntity $otherEntity) |
|
766 | } |
||
767 |