AbstractController::post() - Code Metrics - Inspection of "1.0.x dev" - starweb/starlit-app - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#14)

by Felix

created 2019-04-23 13:51 UTC

AbstractController::post() A

↳ Parent: AbstractController

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	4
cts	4
cp	1
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	2
crap	2

<?php declare(strict_types=1);
/**
 * Starlit App.
 *
 * @copyright Copyright (c) 2016 Starweb AB
 * @license   BSD 3-Clause
 */

namespace Starlit\App;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing;
use Starlit\Utils\Str;
use Starlit\Utils\Url;

abstract class AbstractController
{
    /**
     * @var BaseApp
     */
    protected $app;

    /**
     * @var Request
     */
    protected $request;

    /**
     * @var View
     */
    protected $view;

    /**
     * @var bool
     */
    protected $autoRenderView = true;

    /**
     * @var string
     */
    protected $autoRenderViewScript;

    final public function __construct(BaseApp $app, Request $request)

    {
        $this->app = $app;
        $this->request = $request;

        $this->view = $this->app->getNew(ViewInterface::class);
        $this->view->setRequest($this->request);

        $this->init();
    }

    /**
     * Initialization method meant to be overridden in descendant classes (optional).
     */
    protected function init()
    {
    }

    /**
     * Pre dispatch method meant to be overridden in descendant classes (optional).
     *
     * This method is called right before the actual action method is called/dispatched.
     * Override this instead of init() if access to dispatch properties is required (like
     * action name) or you need to return a response.
     *
     * @param string $action
     * @return Response|null
     */
    protected function preDispatch(string $action): ?Response

    {
        return null;
    }

    public function setAutoRenderView(bool $autoRenderView): void
    {
        $this->autoRenderView = $autoRenderView;
    }

    public function setAutoRenderViewScript(string $autoRenderViewScript): void
    {
        $this->autoRenderViewScript = $autoRenderViewScript;
    }

    /**
     * Dispatch the requested action
     *
     * @param string|null $action action id/name (lowercase, - word separation)
     * @param array       $actionArgs
     * @return Response
     * @throws Routing\Exception\ResourceNotFoundException
     */
    public function dispatch(string $action = null, array $actionArgs = []): Response
    {
        // If not special action is provided, try to get from request
        $router = $this->app->get(RouterInterface::class);
        $action = Str::camelToSeparator(
            $action ?: $router->getRequestAction($this->request),
            '-'
        );
        $actionMethod = $router->getActionMethod($action);
        $collectedArgs = $this->getCollectedDispatchArgs($actionMethod, $actionArgs);

        // Call pre dispatch method and return it's response if there is one (uncommon)
        $preDispatchResponse = $this->preDispatch($action);
        if ($preDispatchResponse instanceof Response) {
            return $preDispatchResponse;
        }

        // Call action method
        $actionResponse = \call_user_func_array([$this, $actionMethod], $collectedArgs);

        $this->postDispatch();

        return $this->getDispatchResponse($action, $actionResponse);
    }

    /**
     * @throws Routing\Exception\ResourceNotFoundException
     */
    protected function getCollectedDispatchArgs(string $actionMethod, array $actionArgs = []): array
    {
        // Check that method is a valid action method
        try {
            $reflectionMethod = new \ReflectionMethod($this, $actionMethod);
            if (!$reflectionMethod->isPublic() || $reflectionMethod->isConstructor()) {
                throw new Routing\Exception\ResourceNotFoundException(
                    "\"{$actionMethod}\" is not a valid action method."
                );
            }
        } catch (\ReflectionException $e) {
            throw new Routing\Exception\ResourceNotFoundException("\"{$actionMethod}\" action method does not exist.");
        }

        $params = $reflectionMethod->getParameters();
        $predefinedValues = \array_merge($this->request->attributes->all() ?? [], $actionArgs);

        try {
            $collectedArgs = $this->app->resolveParameters($params, $predefinedValues);
        } catch (\ReflectionException $e) {
            throw new \LogicException('Missing values for one or more action parameters');
        }

        return $collectedArgs;
    }

    /**
     * @param string $action
     * @param mixed $actionResponse
     * @return Response
     */
    protected function getDispatchResponse(string $action, $actionResponse): Response
    {
        if ($actionResponse instanceof Response) {
            return $actionResponse->prepare($this->request);
        } elseif ($actionResponse !== null) {
            return $this->app->get(Response::class)->setContent((string) $actionResponse)->prepare($this->request);
        } elseif ($this->autoRenderView) {
            $viewScript = $this->autoRenderViewScript ?: $this->getAutoRenderViewScriptName(
                $action,
                $this->app->get(RouterInterface::class)->getRequestController($this->request),
                $this->app->get(RouterInterface::class)->getRequestModule($this->request)
            );

            return $this->app->get(Response::class)->setContent($this->view->render($viewScript, true))
                ->prepare($this->request);
        } else {
            // Empty response if no other response is set
            return $this->app->get(Response::class)->setContent('')
                ->prepare($this->request);
        }
    }

    public function getAutoRenderViewScriptName(string $action, string $controller, string $module = null): string
    {
        $viewScriptName = \implode('/', \array_filter([$module, $controller, $action]));

        return $viewScriptName;
    }

    /**
     * Post dispatch method meant to be overridden in descendant classes (optional).
     * This method is called right after an action method has returned it's response,
     * but before the dispatch method returns the response.
     */
    protected function postDispatch(): void
    {
    }

    /**
     * Forwards request to another action and/or controller
     *
     * @param string      $action     Action name as lowercase separated string
     * @param string|null $controller Controller name as lowercase separated string
     * @param string|null $module     Module name as lowercase separated string
     * @param array       $actionArgs
     * @return Response
     */
    protected function forward(
        string $action,
        string $controller = null,
        string $module = null,
        array $actionArgs = []
    ): Response {
        // Forward inside same controller (easy)
        if (empty($controller)) {
            return $this->dispatch($action, $actionArgs);
        // Forward to another controller
        } else {
            $router = $this->app->get(RouterInterface::class);
            $controller = $controller ?: $router->getRequestController($this->request);
            $module = $module ?: $router->getRequestModule($this->request);

            $controllerClass = $router->getControllerClass($controller, $module);
            $actualController = new $controllerClass($this->app, $this->request);

            // Set new request properties
            $this->request->attributes->add(\compact('module', 'controller', 'action'));

            return $actualController->dispatch($action, $actionArgs);
        }
    }

    /**
     * Get current or a new url merged with provided parameters.
     *
     * @param string $relativeUrl
     * @param array  $parameters
     * @return string
     */
    protected function getUrl(string $relativeUrl = null, array $parameters = []): string
    {
        // Make an absolute url of a new one url, or use the current one if none is provided
        if ($relativeUrl !== null) {
            $url = $this->request->getSchemeAndHttpHost() . $relativeUrl;
        } else {
            $url = $this->request->getSchemeAndHttpHost() . $this->request->getRequestUri();
        }

        if ($parameters) {

            $mergedParameters = \array_merge($this->get(), $parameters);
            $url = (string) (new Url($url))->addQueryParameters($mergedParameters);
        }

        return $url;
    }

    /**
     * Shortcut method to access GET/query parameters.
     *
     * @param string $key
     * @param mixed  $default
     * @return string|array
     */
    protected function get(string $key = null, $default = null)
    {
        if ($key === null) {
            return $this->request->query->all();
        }

        return $this->request->query->get($key, $default);
    }

    /**
     * Shortcut method to access POST/request parameters.
     *
     * @param string $key
     * @param mixed  $default
     * @return string|array
     */
    protected function post(string $key = null, $default = null)
    {
        if ($key === null) {
            return $this->request->request->all();
        }

        return $this->request->request->get($key, $default);
    }
}


1		<?php declare(strict_types=1);
2		/**
3		* Starlit App.
4		*
5		* @copyright Copyright (c) 2016 Starweb AB
6		* @license BSD 3-Clause
7		*/
8
9		namespace Starlit\App;
10
11		use Symfony\Component\HttpFoundation\Request;
12		use Symfony\Component\HttpFoundation\Response;
13		use Symfony\Component\Routing;
14		use Starlit\Utils\Str;
15		use Starlit\Utils\Url;
16
17		abstract class AbstractController
18		{
19		/**
20		* @var BaseApp
21		*/
22		protected $app;
23
24		/**
25		* @var Request
26		*/
27		protected $request;
28
29		/**
30		* @var View
31		*/
32		protected $view;
33
34		/**
35		* @var bool
36		*/
37		protected $autoRenderView = true;
38
39		/**
40		* @var string
41		*/
42		protected $autoRenderViewScript;
43
44	29	final public function __construct(BaseApp $app, Request $request)
		0 ignored issues – show Bug introduced 2018-07-20 09:17 UTC by Report Bug Copy Issue Report You have injected the Request via parameter `$request`. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via `getCurrentRequest()`. Loading history...
45		{
46	29	$this->app = $app;
47	29	$this->request = $request;
48
49	29	$this->view = $this->app->getNew(ViewInterface::class);
50	29	$this->view->setRequest($this->request);
51
52	29	$this->init();
53	29	}
54
55		/**
56		* Initialization method meant to be overridden in descendant classes (optional).
57		*/
58	29	protected function init()
59		{
60	29	}
61
62		/**
63		* Pre dispatch method meant to be overridden in descendant classes (optional).
64		*
65		* This method is called right before the actual action method is called/dispatched.
66		* Override this instead of init() if access to dispatch properties is required (like
67		* action name) or you need to return a response.
68		*
69		* @param string $action
70		* @return Response\|null
71		*/
72	7	protected function preDispatch(string $action): ?Response
		0 ignored issues – show Unused Code introduced 2019-04-11 08:55 UTC by Report Bug Copy Issue Report The parameter `$action` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
73		{
74	7	return null;
75		}
76
77	2	public function setAutoRenderView(bool $autoRenderView): void
78		{
79	2	$this->autoRenderView = $autoRenderView;
80	2	}
81
82	1	public function setAutoRenderViewScript(string $autoRenderViewScript): void
83		{
84	1	$this->autoRenderViewScript = $autoRenderViewScript;
85	1	}
86
87		/**
88		* Dispatch the requested action
89		*
90		* @param string\|null $action action id/name (lowercase, - word separation)
91		* @param array $actionArgs
92		* @return Response
93		* @throws Routing\Exception\ResourceNotFoundException
94		*/
95	11	public function dispatch(string $action = null, array $actionArgs = []): Response
96		{
97		// If not special action is provided, try to get from request
98	11	$router = $this->app->get(RouterInterface::class);
99	11	$action = Str::camelToSeparator(
100	11	$action ?: $router->getRequestAction($this->request),
101	11	'-'
102		);
103	11	$actionMethod = $router->getActionMethod($action);
104	11	$collectedArgs = $this->getCollectedDispatchArgs($actionMethod, $actionArgs);
105
106		// Call pre dispatch method and return it's response if there is one (uncommon)
107	8	$preDispatchResponse = $this->preDispatch($action);
108	8	if ($preDispatchResponse instanceof Response) {
109	1	return $preDispatchResponse;
110		}
111
112		// Call action method
113	7	$actionResponse = \call_user_func_array([$this, $actionMethod], $collectedArgs);
114
115	7	$this->postDispatch();
116
117	7	return $this->getDispatchResponse($action, $actionResponse);
118		}
119
120		/**
121		* @throws Routing\Exception\ResourceNotFoundException
122		*/
123	11	protected function getCollectedDispatchArgs(string $actionMethod, array $actionArgs = []): array
124		{
125		// Check that method is a valid action method
126		try {
127	11	$reflectionMethod = new \ReflectionMethod($this, $actionMethod);
128	10	if (!$reflectionMethod->isPublic() \|\| $reflectionMethod->isConstructor()) {
129	1	throw new Routing\Exception\ResourceNotFoundException(
130	10	"\"{$actionMethod}\" is not a valid action method."
131		);
132		}
133	2	} catch (\ReflectionException $e) {
134	1	throw new Routing\Exception\ResourceNotFoundException("\"{$actionMethod}\" action method does not exist.");
135		}
136
137	9	$params = $reflectionMethod->getParameters();
138	9	$predefinedValues = \array_merge($this->request->attributes->all() ?? [], $actionArgs);
139
140		try {
141	9	$collectedArgs = $this->app->resolveParameters($params, $predefinedValues);
142	1	} catch (\ReflectionException $e) {
143	1	throw new \LogicException('Missing values for one or more action parameters');
144		}
145
146	8	return $collectedArgs;
147		}
148
149		/**
150		* @param string $action
151		* @param mixed $actionResponse
152		* @return Response
153		*/
154	7	protected function getDispatchResponse(string $action, $actionResponse): Response
155		{
156	7	if ($actionResponse instanceof Response) {
157	4	return $actionResponse->prepare($this->request);
158	3	} elseif ($actionResponse !== null) {
159	1	return $this->app->get(Response::class)->setContent((string) $actionResponse)->prepare($this->request);
160	2	} elseif ($this->autoRenderView) {
161	1	$viewScript = $this->autoRenderViewScript ?: $this->getAutoRenderViewScriptName(
162	1	$action,
163	1	$this->app->get(RouterInterface::class)->getRequestController($this->request),
164	1	$this->app->get(RouterInterface::class)->getRequestModule($this->request)
165		);
166
167	1	return $this->app->get(Response::class)->setContent($this->view->render($viewScript, true))
168	1	->prepare($this->request);
169		} else {
170		// Empty response if no other response is set
171	1	return $this->app->get(Response::class)->setContent('')
172	1	->prepare($this->request);
173		}
174		}
175
176	1	public function getAutoRenderViewScriptName(string $action, string $controller, string $module = null): string
177		{
178	1	$viewScriptName = \implode('/', \array_filter([$module, $controller, $action]));
179
180	1	return $viewScriptName;
181		}
182
183		/**
184		* Post dispatch method meant to be overridden in descendant classes (optional).
185		* This method is called right after an action method has returned it's response,
186		* but before the dispatch method returns the response.
187		*/
188	7	protected function postDispatch(): void
189		{
190	7	}
191
192		/**
193		* Forwards request to another action and/or controller
194		*
195		* @param string $action Action name as lowercase separated string
196		* @param string\|null $controller Controller name as lowercase separated string
197		* @param string\|null $module Module name as lowercase separated string
198		* @param array $actionArgs
199		* @return Response
200		*/
201	3	protected function forward(
202		string $action,
203		string $controller = null,
204		string $module = null,
205		array $actionArgs = []
206		): Response {
207		// Forward inside same controller (easy)
208	3	if (empty($controller)) {
209	1	return $this->dispatch($action, $actionArgs);
210		// Forward to another controller
211		} else {
212	2	$router = $this->app->get(RouterInterface::class);
213	2	$controller = $controller ?: $router->getRequestController($this->request);
214	2	$module = $module ?: $router->getRequestModule($this->request);
215
216	2	$controllerClass = $router->getControllerClass($controller, $module);
217	2	$actualController = new $controllerClass($this->app, $this->request);
218
219		// Set new request properties
220	2	$this->request->attributes->add(\compact('module', 'controller', 'action'));
221
222	2	return $actualController->dispatch($action, $actionArgs);
223		}
224		}
225
226		/**
227		* Get current or a new url merged with provided parameters.
228		*
229		* @param string $relativeUrl
230		* @param array $parameters
231		* @return string
232		*/
233	2	protected function getUrl(string $relativeUrl = null, array $parameters = []): string
234		{
235		// Make an absolute url of a new one url, or use the current one if none is provided
236	2	if ($relativeUrl !== null) {
237	1	$url = $this->request->getSchemeAndHttpHost() . $relativeUrl;
238		} else {
239	1	$url = $this->request->getSchemeAndHttpHost() . $this->request->getRequestUri();
240		}
241
242	2	if ($parameters) {
		0 ignored issues – show Bug Best Practice introduced 2016-04-04 09:15 UTC by Report Bug Copy Issue Report The expression `$parameters` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
243	1	$mergedParameters = \array_merge($this->get(), $parameters);
244	1	$url = (string) (new Url($url))->addQueryParameters($mergedParameters);
245		}
246
247	2	return $url;
248		}
249
250		/**
251		* Shortcut method to access GET/query parameters.
252		*
253		* @param string $key
254		* @param mixed $default
255		* @return string\|array
256		*/
257	2	protected function get(string $key = null, $default = null)
258		{
259	2	if ($key === null) {
260	2	return $this->request->query->all();
261		}
262
263	1	return $this->request->query->get($key, $default);
264		}
265
266		/**
267		* Shortcut method to access POST/request parameters.
268		*
269		* @param string $key
270		* @param mixed $default
271		* @return string\|array
272		*/
273	1	protected function post(string $key = null, $default = null)
274		{
275	1	if ($key === null) {
276	1	return $this->request->request->all();
277		}
278
279	1	return $this->request->request->get($key, $default);
280		}
281		}
282

starweb / starlit-app

GitHub Access Token became invalid

Pull Request — master (#14)

AbstractController::post() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like