Startwind\Inventorio\Collector\Network\NetworkTrafficCollector

Complexity

Total Complexity

9

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	collect()	0	4	1
B	calculateNetworkThroughput()	0	39	8

<?php

namespace Startwind\Inventorio\Collector\Network;

use Startwind\Inventorio\Collector\BasicCollector;
use Startwind\Inventorio\Exec\File;
use Startwind\Inventorio\Metrics\Memory\Memory;

class NetworkTrafficCollector extends BasicCollector
{
    protected string $identifier = "NetworkThroughput";

    private const MEMORY_KEY = 'net_traffic_history';

    public function collect(): array
    {
        return [
            'eth0' => $this->calculateNetworkThroughput('eth0')
        ];
    }

    function calculateNetworkThroughput($interface): float

It is generally recommended to explicitly declare the visibility for methods.

    {
        $memory = Memory::getInstance();

        $file = new File();

        if (!$file->fileExists('/proc/net/dev')) return 0;

        $lines = $file->getContents('/proc/net/dev', true);
        foreach ($lines as $line) {
            if (strpos($line, $interface . ':') !== false) {
                $parts = preg_split('/\s+/', trim($line));
                $rx = (int)$parts[1];
                $tx = (int)$parts[9];
                $total = $rx + $tx;
                break;
            }
        }

        if (!isset($total)) return 0;

        $history = $memory->getData(self::MEMORY_KEY) ?? [];
        $lastTotal = end($history);

It seems like $history can also be of type double; however, parameter $array of end() does only seem to accept array|object, maybe add an additional type check?

        if (!empty($history) && $total < $lastTotal) {

The variable $total does not seem to be defined for all execution paths leading up to this point.

            $memory->addData(self::MEMORY_KEY, $history);
            return 0;
        }

        if (!empty($history)) {
            $delta = $total - $lastTotal;
            $mb = round($delta / 1024 / 1024, 2);
        } else {
            $mb = 0;
        }

        $memory->addData(self::MEMORY_KEY, $total);

        return $mb;
    }
}