EventControllerTest - Code Metrics - Inspection of "Mise à jour des gabarits de tests." - starker-xp/lapero.net - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8c5aef...11380b )

by Guillaume

created 2017-05-23 23:51 UTC

EventControllerTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	407
Duplicated Lines	43 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
wmc	15
lcom	1
cbo	3
dl	175
loc	407
rs	10
c	0
b	0
f	0

14 Methods

Rating	Name	Duplication	Size	Complexity
B	testPostValide()	0	25	1
A	getCampagneId()	0	7	1
A	testPostInvalide()	21	21	1
B	testPutValide()	0	35	1
B	testPutInvalide()	0	27	1
B	testPutSansResultat()	25	25	1
B	testCGetValideAvecResultats()	25	25	2
A	testCGetValideSansResultat()	21	21	1
A	testCGetInvalide()	19	19	1
B	testGetValideAvecResultats()	0	28	1
A	testGetValideSansResultat()	22	22	1
A	testGetInvalide()	20	20	1
B	testDeleteValide()	0	28	1
A	testDeleteSansResultat()	22	22	1

How to fix Duplicated Code

<?php

namespace Starkerxp\CampagneBundle\Tests\Controller;

use Starkerxp\StructureBundle\Tests\WebTest;

class EventControllerTest extends WebTest
{

    /**
     * @group event
     * @group post
     * @group controller
     */
    public function testPostValide()
    {
        $this->loadFixtureFiles(
            [
                '@StarkerxpUtilisateurBundle/Tests/DataFixtures/UtilisateurManager/DefaultUtilisateur.yml',
                '@StarkerxpCampagneBundle/Tests/DataFixtures/CampagneManager/DefaultCampagne.yml',
            ]
        );
        $data = [
            //'nom'     => "Mon nom", //exemple

        ];
        $url = $this->generateUrl(
            'starkerxp_campagne.event.post',
            [
                "campagne_id" => $this->getCampagneId(),
            ]
        );
        $client = $this->getAuthClient();
        $client->request('POST', $url, $data);
        $response = $client->getResponse();
        $this->assertEquals(201, $response->getStatusCode());
        $manager = $this->getContainer()->get('starkerxp_campagne.manager.event');
        $events = $manager->findAll();
        $this->assertCount(1, $events);
    }

    protected function getCampagneId()
    {
        $repositoryCampagne = $this->getEntityManager()->getRepository("StarkerxpCampagneBundle:Campagne");
        $resultats = $repositoryCampagne->findAll();

        return $resultats[0]->getId();
    }

    /**
     * @group event
     * @group post
     * @group controller
     */
    public function testPostInvalide()

    {
        $this->loadFixtureFiles(
            [
                '@StarkerxpUtilisateurBundle/Tests/DataFixtures/UtilisateurManager/DefaultUtilisateur.yml',
                '@StarkerxpCampagneBundle/Tests/DataFixtures/CampagneManager/DefaultCampagne.yml',
            ]
        );
        $url = $this->generateUrl(
            'starkerxp_campagne.event.post',
            [
                "campagne_id" => $this->getCampagneId(),
            ]
        );
        $client = $this->getAuthClient();
        $client->request('POST', $url, []);
        $response = $client->getResponse();
        $this->assertEquals(400, $response->getStatusCode());
        $body = json_decode($response->getContent(), true)['payload'];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        //$this->assertArrayHasKey("nom", $body); // Exemple

    }

    /**
     * @group event
     * @group put
     * @group controller
     */
    public function testPutValide()
    {
        $this->loadFixtureFiles(
            [
                '@StarkerxpUtilisateurBundle/Tests/DataFixtures/UtilisateurManager/DefaultUtilisateur.yml',
                '@StarkerxpCampagneBundle/Tests/DataFixtures/CampagneManager/DefaultCampagne.yml',
                '@StarkerxpCampagneBundle/Tests/DataFixtures/EventManager/DefaultEvent.yml',
            ]
        );

        $manager = $this->getContainer()->get('starkerxp_campagne.manager.event');
        $listeEvents = $manager->getRepository()->findAll();
        $this->assertCount(1, $listeEvents);
        $eventDepart = $manager->toArray($listeEvents[0], [/*'nom'*/]);// Exemple
        $data = [
            //'nom'     => "Mon nom", //exemple

        ];
        $url = $this->generateUrl(
            'starkerxp_campagne.event.put',
            [
                "campagne_id" => $this->getCampagneId(),
                "id"    => $listeEvents[0]->getId(),
            ]
        );
        $client = $this->getAuthClient();
        $client->request('PUT', $url, $data);
        $response = $client->getResponse();
        $this->assertEquals(204, $response->getStatusCode());
        $manager->clear();
        $events = $manager->findAll();
        $this->assertCount(1, $events);
        $eventFinal = $manager->toArray($events[0], [/*'nom'*/]);// Exemple
        $this->assertNotEquals($eventDepart, $eventFinal);
        $this->assertEquals($data, $eventFinal);
    }

    /**
     * @group event
     * @group put
     * @group controller
     */
    public function testPutInvalide()
    {
        $this->loadFixtureFiles(
            [
                '@StarkerxpUtilisateurBundle/Tests/DataFixtures/UtilisateurManager/DefaultUtilisateur.yml',
                '@StarkerxpCampagneBundle/Tests/DataFixtures/CampagneManager/DefaultCampagne.yml',
                '@StarkerxpCampagneBundle/Tests/DataFixtures/EventManager/DefaultEvent.yml',
            ]
        );
        $manager = $this->getContainer()->get('starkerxp_campagne.manager.event');
        $listeEvents = $manager->getRepository()->findAll();
        $this->assertCount(1, $listeEvents);
        $url = $this->generateUrl(
            'starkerxp_campagne.event.put',
            [
                "campagne_id" => $this->getCampagneId(),
                "id"    => $listeEvents[0]->getId(),
            ]
        );
        $client = $this->getAuthClient();
        $client->request('PUT', $url, []);
        $response = $client->getResponse();
        $this->assertEquals(400, $response->getStatusCode());
        $body = json_decode($response->getContent(), true)['payload'];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        //$this->assertArrayHasKey("nom", $body); // Exemple


    }

    /**
     * @group event
     * @group put
     * @group controller
     */
    public function testPutSansResultat()

    {
        $this->loadFixtureFiles(
            [
                '@StarkerxpUtilisateurBundle/Tests/DataFixtures/UtilisateurManager/DefaultUtilisateur.yml',
                '@StarkerxpCampagneBundle/Tests/DataFixtures/CampagneManager/DefaultCampagne.yml',
            ]
        );
        $data = [
            //'nom'     => "Mon nom", //exemple

        ];
        $url = $this->generateUrl(
            'starkerxp_campagne.event.put',
            [
                "campagne_id" => $this->getCampagneId(),
                "id"    => 404,
            ]
        );
        $client = $this->getAuthClient();
        $client->request('PUT', $url, $data);
        $response = $client->getResponse();
        $this->assertEquals(404, $response->getStatusCode());
        $body = json_decode($response->getContent(), true);
        $this->assertNotEmpty($body);
    }

    /**
     * @group event
     * @group cget
     * @group controller
     */
    public function testCGetValideAvecResultats()

    {
        $this->loadFixtureFiles(
            [
                '@StarkerxpUtilisateurBundle/Tests/DataFixtures/UtilisateurManager/DefaultUtilisateur.yml',
                '@StarkerxpCampagneBundle/Tests/DataFixtures/CampagneManager/DefaultCampagne.yml',
                '@StarkerxpCampagneBundle/Tests/DataFixtures/EventManager/EventManager.yml',
            ]
        );
        $url = $this->generateUrl(
            'starkerxp_campagne.event.cget',
            [
                "campagne_id" => $this->getCampagneId(),
            ]
        );
        $client = $this->getAuthClient();
        $client->request('GET', $url, []);
        $response = $client->getResponse();
        $this->assertEquals(200, $response->getStatusCode());
        $body = json_decode($response->getContent(), true);
        $this->assertCount(10, $body);
        foreach ($body as $element) {

            //$this->assertArrayHasKey("nom", $body); // Exemple

        }
    }

    /**
     * @group event
     * @group cget
     * @group controller
     */
    public function testCGetValideSansResultat()

    {
        $this->loadFixtureFiles(
            [
                '@StarkerxpUtilisateurBundle/Tests/DataFixtures/UtilisateurManager/DefaultUtilisateur.yml',
                '@StarkerxpCampagneBundle/Tests/DataFixtures/CampagneManager/DefaultCampagne.yml',
            ]
        );
        $url = $this->generateUrl(
            'starkerxp_campagne.event.cget',
            [
                "campagne_id" => $this->getCampagneId(),
            ]
        );
        $client = $this->getAuthClient();
        $client->request('GET', $url, []);
        $response = $client->getResponse();
        $this->assertEquals(200, $response->getStatusCode());
        $body = json_decode($response->getContent(), true);
        $this->assertCount(0, $body);
    }

    /**
     * @group event
     * @group cget
     * @group controller
     */
    public function testCGetInvalide()

    {
        $this->loadFixtureFiles(
            [
                '@StarkerxpUtilisateurBundle/Tests/DataFixtures/UtilisateurManager/DefaultUtilisateur.yml',
                '@StarkerxpCampagneBundle/Tests/DataFixtures/CampagneManager/DefaultCampagne.yml',
            ]
        );
        $url = $this->generateUrl(
            'starkerxp_campagne.event.cget',
            [
                "campagne_id" => $this->getCampagneId(),
            ]
        );
        $client = $this->getAuthClient();
        $client->request('GET', $url, ["filter_erreur" => "+h"]);
        $response = $client->getResponse();
        $this->assertEquals(400, $response->getStatusCode());
    }

    /**
     * @group event
     * @group get
     * @group controller
     */
    public function testGetValideAvecResultats()
    {
        $this->loadFixtureFiles(
            [
                '@StarkerxpUtilisateurBundle/Tests/DataFixtures/UtilisateurManager/DefaultUtilisateur.yml',
                '@StarkerxpCampagneBundle/Tests/DataFixtures/CampagneManager/DefaultCampagne.yml',
                '@StarkerxpCampagneBundle/Tests/DataFixtures/EventManager/EventManager.yml',
            ]
        );
        $manager = $this->getContainer()->get('starkerxp_campagne.manager.event');
        $listeEvents = $manager->getRepository()->findAll();
        $this->assertCount(10, $listeEvents);
        $url = $this->generateUrl(
            'starkerxp_campagne.event.get',
            [
                "campagne_id" => $this->getCampagneId(),
                "id"    => $listeEvents[0]->getId(),
            ]
        );
        $client = $this->getAuthClient();
        $client->request('GET', $url, []);
        $response = $client->getResponse();
        $this->assertEquals(200, $response->getStatusCode());
        $body = json_decode($response->getContent(), true);
        $this->assertCount(2, $body);
        $this->assertArrayHasKey("id", $body); // Exemple
        $this->assertArrayHasKey("campagne_id", $body); // Exemple
    }

    /**
     * @group event
     * @group get
     * @group controller
     */
    public function testGetValideSansResultat()

    {
        $this->loadFixtureFiles(
            [
                '@StarkerxpUtilisateurBundle/Tests/DataFixtures/UtilisateurManager/DefaultUtilisateur.yml',
                '@StarkerxpCampagneBundle/Tests/DataFixtures/CampagneManager/DefaultCampagne.yml',
            ]
        );
        $url = $this->generateUrl(
            'starkerxp_campagne.event.get',
            [
                "campagne_id" => $this->getCampagneId(),
                "id"    => 404,
            ]
        );
        $client = $this->getAuthClient();
        $client->request('GET', $url, []);
        $response = $client->getResponse();
        $this->assertEquals(404, $response->getStatusCode());
        $body = json_decode($response->getContent(), true);
        $this->assertNotEmpty($body);
    }

    /**
     * @group event
     * @group get
     * @group controller
     */
    public function testGetInvalide()

    {
        $this->loadFixtureFiles(
            [
                '@StarkerxpUtilisateurBundle/Tests/DataFixtures/UtilisateurManager/DefaultUtilisateur.yml',
                '@StarkerxpCampagneBundle/Tests/DataFixtures/CampagneManager/DefaultCampagne.yml',
            ]
        );
        $url = $this->generateUrl(
            'starkerxp_campagne.event.get',
            [
                "campagne_id" => $this->getCampagneId(),
                "id"    => 500,
            ]
        );
        $client = $this->getAuthClient();
        $client->request('GET', $url, ["filter_erreur" => "+h"]);
        $response = $client->getResponse();
        $this->assertEquals(400, $response->getStatusCode());
    }

    /**
     * @group event
     * @group delete
     * @group controller
     */
    public function testDeleteValide()
    {

        $this->loadFixtureFiles(
            [
                '@StarkerxpUtilisateurBundle/Tests/DataFixtures/UtilisateurManager/DefaultUtilisateur.yml',
                '@StarkerxpCampagneBundle/Tests/DataFixtures/CampagneManager/DefaultCampagne.yml',
                '@StarkerxpCampagneBundle/Tests/DataFixtures/EventManager/DefaultEvent.yml',
            ]
        );
        $manager = $this->getContainer()->get('starkerxp_campagne.manager.event');
        $listeEvents = $manager->getRepository()->findAll();
        $this->assertCount(1, $listeEvents);
        $url = $this->generateUrl(
            'starkerxp_campagne.event.delete',
            [
                "campagne_id" => $this->getCampagneId(),
                "id"    => $listeEvents[0]->getId(),
            ]
        );
        $client = $this->getAuthClient();
        $client->request('DELETE', $url);
        $response = $client->getResponse();
        $this->assertEquals(204, $response->getStatusCode());
        $manager->clear();
        $events = $manager->findAll();
        $this->assertCount(0, $events);
    }

    /**
     * @group event
     * @group delete
     * @group controller
     */
    public function testDeleteSansResultat()

    {
        $this->loadFixtureFiles(
            [
                '@StarkerxpUtilisateurBundle/Tests/DataFixtures/UtilisateurManager/DefaultUtilisateur.yml',
                '@StarkerxpCampagneBundle/Tests/DataFixtures/CampagneManager/DefaultCampagne.yml',
            ]
        );
        $url = $this->generateUrl(
            'starkerxp_campagne.event.delete',
            [
                "campagne_id" => $this->getCampagneId(),
                "id"    => 404,
            ]
        );
        $client = $this->getAuthClient();
        $client->request('DELETE', $url, []);
        $response = $client->getResponse();
        $this->assertEquals(404, $response->getStatusCode());
        $body = json_decode($response->getContent(), true);
        $this->assertNotEmpty($body);
    }
}



1			<?php
2
3			namespace Starkerxp\CampagneBundle\Tests\Controller;
4
5			use Starkerxp\StructureBundle\Tests\WebTest;
6
7			class EventControllerTest extends WebTest
8			{
9
10			/**
11			* @group event
12			* @group post
13			* @group controller
14			*/
15			public function testPostValide()
16			{
17			$this->loadFixtureFiles(
18			[
19			'@StarkerxpUtilisateurBundle/Tests/DataFixtures/UtilisateurManager/DefaultUtilisateur.yml',
20			'@StarkerxpCampagneBundle/Tests/DataFixtures/CampagneManager/DefaultCampagne.yml',
21			]
22			);
23			$data = [
24			//'nom' => "Mon nom", //exemple
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-05-10 00:39 UTC by Report Bug Copy Issue Report `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
25			];
26			$url = $this->generateUrl(
27			'starkerxp_campagne.event.post',
28			[
29			"campagne_id" => $this->getCampagneId(),
30			]
31			);
32			$client = $this->getAuthClient();
33			$client->request('POST', $url, $data);
34			$response = $client->getResponse();
35			$this->assertEquals(201, $response->getStatusCode());
36			$manager = $this->getContainer()->get('starkerxp_campagne.manager.event');
37			$events = $manager->findAll();
38			$this->assertCount(1, $events);
39			}

starker-xp / lapero.net

Push — master ( 8c5aef...11380b )

EventControllerTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

14 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like