TemplateController - Code Metrics - Inspection of "Migration code anglais" - starker-xp/lapero.net - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4bb011...4b99be )

by Guillaume

created 2017-09-06 23:47 UTC

TemplateController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	209
Duplicated Lines	36.36 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

Metric	Value
wmc	16
lcom	1
cbo	8
dl	76
loc	209
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	cgetAction()	21	21	3
A	getAction()	16	16	3
A	postAction()	0	21	3
B	putAction()	22	22	4
A	deleteAction()	16	16	3

How to fix Duplicated Code

<?php

namespace Starkerxp\CampaignBundle\Controller;

use Nelmio\ApiDocBundle\Annotation\ApiDoc;
use Starkerxp\CampaignBundle\Entity\Template;
use Starkerxp\CampaignBundle\Events;
use Starkerxp\CampaignBundle\Form\Type\TemplateType;
use Starkerxp\StructureBundle\Controller\StructureController;
use Symfony\Component\EventDispatcher\GenericEvent;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;


class TemplateController extends StructureController
{
	/**
     * @ApiDoc(
     *      resource=true,
     *      description="List templates.",
     *      section="starkerxp_campaign.template",
     *      parameters={
     *          {
     *              "name"="offset",
     *              "dataType"="integer",
     *              "requirement"="\d+",
     *              "description"="starkerxp_structure.doc.offset.result",
     *              "required"="false"
     *          },
     *          {
     *              "name"="limit",
     *              "dataType"="integer",
     *              "requirement"="\d+",
     *              "description"="starkerxp_structure.doc.limit.result",
     *              "required"="false"
     *          },
     *          {
     *              "name"="fields",
     *              "dataType"="string",
     *              "requirement"="\w+",
     *              "description"="starkerxp_structure.doc.list_field.entity",
     *              "required"="false"
     *          },
     *          {
     *              "name"="sort",
     *              "dataType"="string",
     *              "requirement"="\w+",
     *              "description"="starkerxp_structure.doc.sort.result",
     *              "required"="false"
     *          }
     *      },
     *      views = { "default" }
     * )
     * 
     */
    public function cgetAction(Request $request)

    {
        $manager = $this->get("starkerxp_campaign.manager.template");
        try {
            $options = $this->resolveParams()->resolve($request->query->all());
            $orderBy = $this->getOrderBy($options['sort']);
            $resultSets = $manager->findBy([], $orderBy, $options['limit'], $options['offset']);
        } catch (\Exception $e) {
            return new JsonResponse(["payload" => $e->getMessage()], 400);
        }
        if (empty($resultSets)) {
            return new JsonResponse([]);
        }
        $retour = array_map(
            function ($element) use ($manager, $options) {
                return $manager->toArray($element, $this->getFields($options['fields']));
            },
            $resultSets
        );
        return new JsonResponse($retour);
    }

	
	/**
     * @ApiDoc(
     *      resource=true,
     *      description="Affiche un template.",
     *      section="starkerxp_campaign.template",
	 *      requirements={
     *          {
     *              "name"="template_id",
     *              "dataType"="integer",
     *              "requirement"="\d+",
     *              "description"="Permet d'afficher l'élément choisis"
     *          }
     *      },
     *      parameters={
     *          {
     *              "name"="fields",
     *              "dataType"="string",
     *              "requirement"="\w+",
     *              "description"="starkerxp_structure.doc.list_field.entity",
     *              "required"="false"
     *          }
     *      },
     *      views = { "default" }
     * )
     */
    public function getAction(Request $request)

    {
        $manager = $this->get("starkerxp_campaign.manager.template");
        try {
            $options = $this->resolveParams()->resolve($request->query->all());
			if (!$entite = $manager->findOneBy(['id' => $request->get('template_id')])) {
                return new JsonResponse(["payload" => $this->translate("entity.not_found", "template")], 404);
            }
        } catch (\Exception $e) {
            return new JsonResponse(["payload" => $e->getMessage()], 400);
        }
        
        $retour = $manager->toArray($entite, $this->getFields($options['fields']));

        return new JsonResponse($retour);
    }

	/**
     * @ApiDoc(
     *      resource=true,
     *      description="Ajoute un template.",
     *      section="starkerxp_campaign.template",
     *      views = { "default" }
     * )
     */
    public function postAction(Request $request)
    {
        $manager = $this->get("starkerxp_campaign.manager.template");
        try {
            $entite = new Template();
            $form = $this->createForm(TemplateType::class, $entite, ['method' => 'POST']);
            $form->submit($this->getRequestData($request));
            if ($form->isValid()) {
                $template = $form->getData();
                $template->setUuid($this->getUuid());
                $manager->insert($template);
				$this->dispatch(Events::TEMPLATE_CREATED, new GenericEvent($entite));
                return new JsonResponse(["payload" => $this->translate("template.entity.created", "template")], 201);
            }
        } catch (\Exception $e) {
            $manager->rollback();
            return new JsonResponse(["payload" => $e->getMessage()], 400);
        }

        return new JsonResponse(["payload" => $this->getFormErrors($form)], 400);
    }

	/**
     * @ApiDoc(
     *      resource=true,
     *      description="Modifie un template.",
     *      section="starkerxp_campaign.template",
	 *      requirements={
     *          {
     *              "name"="template_id",
     *              "dataType"="integer",
     *              "requirement"="\d+",
     *              "description"="Permet de modifier l'élément choisi."
     *          }
     *      },
     *      views = { "default" }
     * )
     */
    public function putAction(Request $request)

    {
        $manager = $this->get("starkerxp_campaign.manager.template");
		if (!$entite = $manager->findOneBy(['id' => $request->get('template_id')])) {
			return new JsonResponse(["payload" => $this->translate("entity.not_found", "template")], 404);
		}
        $manager->beginTransaction();
        try {
            $form = $this->createForm(TemplateType::class, $entite, ['method' => 'PUT']);
            $form->submit($this->getRequestData($request));
            if ($form->isValid()) {
                $entite = $form->getData();
                $manager->update($entite);
				$this->dispatch(Events::TEMPLATE_UPDATED, new GenericEvent($entite));
                return new JsonResponse(["payload" => $this->translate("template.entity.updated", "template")], 204);
            }
        } catch (\Exception $e) {
            $manager->rollback();
            return new JsonResponse(["payload" => $e->getMessage()], 400);
        }
        return new JsonResponse(["payload" => $this->getFormErrors($form)], 400);
    }

	/**
     * @ApiDoc(
     *      resource=true,
     *      description="Supprime un template.",
     *      section="starkerxp_campaign.template",
	 *      requirements={
     *          {
     *              "name"="template_id",
     *              "dataType"="integer",
     *              "requirement"="\d+",
     *              "description"="Permet de supprimer l'élément choisi."
     *          }
     *      },
     *      views = { "default" }
     * )
     */
    public function deleteAction(Request $request)

    {
        $manager = $this->get("starkerxp_campaign.manager.template");
        if (!$entite = $manager->findOneBy(['id' => $request->get('template_id')])) {
			return new JsonResponse(["payload" => $this->translate("entity.not_found", "template")], 404);
		}
        try {
            $manager->delete($entite);
        } catch (\Exception $e) {
            $manager->rollback();
            return new JsonResponse(["payload" => $e->getMessage()], 400);
        }
		$this->dispatch(Events::TEMPLATE_DELETED, new GenericEvent($request->get('template_id')));
		
        return new JsonResponse(["payload" => $this->translate("template.entity.deleted", "template")], 204);
    }

} 



1		<?php
2
3		namespace Starkerxp\CampaignBundle\Controller;
4
5		use Nelmio\ApiDocBundle\Annotation\ApiDoc;
6		use Starkerxp\CampaignBundle\Entity\Template;
7		use Starkerxp\CampaignBundle\Events;
8		use Starkerxp\CampaignBundle\Form\Type\TemplateType;
9		use Starkerxp\StructureBundle\Controller\StructureController;
10		use Symfony\Component\EventDispatcher\GenericEvent;
11		use Symfony\Component\HttpFoundation\JsonResponse;
12		use Symfony\Component\HttpFoundation\Request;
13
14
15		class TemplateController extends StructureController
16		{
17		/**
18		* @ApiDoc(
19		* resource=true,
20		* description="List templates.",
21		* section="starkerxp_campaign.template",
22		* parameters={
23		* {
24		* "name"="offset",
25		* "dataType"="integer",
26		* "requirement"="\d+",
27		* "description"="starkerxp_structure.doc.offset.result",
28		* "required"="false"
29		* },
30		* {
31		* "name"="limit",
32		* "dataType"="integer",
33		* "requirement"="\d+",
34		* "description"="starkerxp_structure.doc.limit.result",
35		* "required"="false"
36		* },
37		* {
38		* "name"="fields",
39		* "dataType"="string",
40		* "requirement"="\w+",
41		* "description"="starkerxp_structure.doc.list_field.entity",
42		* "required"="false"
43		* },
44		* {
45		* "name"="sort",
46		* "dataType"="string",
47		* "requirement"="\w+",
48		* "description"="starkerxp_structure.doc.sort.result",
49		* "required"="false"
50		* }
51		* },
52		* views = { "default" }
53		* )
54		*
55		*/
56	View Code Duplication	public function cgetAction(Request $request)
		0 ignored issues – show Duplication introduced 2017-09-07 00:00 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
57		{
58		$manager = $this->get("starkerxp_campaign.manager.template");
59		try {
60		$options = $this->resolveParams()->resolve($request->query->all());
61		$orderBy = $this->getOrderBy($options['sort']);
62		$resultSets = $manager->findBy([], $orderBy, $options['limit'], $options['offset']);
63		} catch (\Exception $e) {
64		return new JsonResponse(["payload" => $e->getMessage()], 400);
65		}
66		if (empty($resultSets)) {
67		return new JsonResponse([]);
68		}
69		$retour = array_map(
70		function ($element) use ($manager, $options) {
71		return $manager->toArray($element, $this->getFields($options['fields']));
72		},
73		$resultSets
74		);
75		return new JsonResponse($retour);
76		}
77
78
79		/**
80		* @ApiDoc(
81		* resource=true,
82		* description="Affiche un template.",
83		* section="starkerxp_campaign.template",
84		* requirements={
85		* {
86		* "name"="template_id",
87		* "dataType"="integer",
88		* "requirement"="\d+",
89		* "description"="Permet d'afficher l'élément choisis"
90		* }
91		* },
92		* parameters={
93		* {
94		* "name"="fields",
95		* "dataType"="string",
96		* "requirement"="\w+",
97		* "description"="starkerxp_structure.doc.list_field.entity",
98		* "required"="false"
99		* }
100		* },
101		* views = { "default" }
102		* )
103		*/
104	View Code Duplication	public function getAction(Request $request)
		0 ignored issues – show Duplication introduced 2017-09-07 00:00 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
105		{
106		$manager = $this->get("starkerxp_campaign.manager.template");
107		try {
108		$options = $this->resolveParams()->resolve($request->query->all());
109		if (!$entite = $manager->findOneBy(['id' => $request->get('template_id')])) {
110		return new JsonResponse(["payload" => $this->translate("entity.not_found", "template")], 404);
111		}
112		} catch (\Exception $e) {
113		return new JsonResponse(["payload" => $e->getMessage()], 400);
114		}
115
116		$retour = $manager->toArray($entite, $this->getFields($options['fields']));
117
118		return new JsonResponse($retour);
119		}
120
121		/**
122		* @ApiDoc(
123		* resource=true,
124		* description="Ajoute un template.",
125		* section="starkerxp_campaign.template",
126		* views = { "default" }
127		* )
128		*/
129		public function postAction(Request $request)
130		{
131		$manager = $this->get("starkerxp_campaign.manager.template");
132		try {
133		$entite = new Template();
134		$form = $this->createForm(TemplateType::class, $entite, ['method' => 'POST']);
135		$form->submit($this->getRequestData($request));
136		if ($form->isValid()) {
137		$template = $form->getData();
138		$template->setUuid($this->getUuid());
139		$manager->insert($template);
140		$this->dispatch(Events::TEMPLATE_CREATED, new GenericEvent($entite));
141		return new JsonResponse(["payload" => $this->translate("template.entity.created", "template")], 201);
142		}
143		} catch (\Exception $e) {
144		$manager->rollback();
145		return new JsonResponse(["payload" => $e->getMessage()], 400);
146		}
147
148		return new JsonResponse(["payload" => $this->getFormErrors($form)], 400);
149		}
150
151		/**
152		* @ApiDoc(
153		* resource=true,
154		* description="Modifie un template.",
155		* section="starkerxp_campaign.template",
156		* requirements={
157		* {
158		* "name"="template_id",
159		* "dataType"="integer",
160		* "requirement"="\d+",
161		* "description"="Permet de modifier l'élément choisi."
162		* }
163		* },
164		* views = { "default" }
165		* )
166		*/
167	View Code Duplication	public function putAction(Request $request)
		0 ignored issues – show Duplication introduced 2017-09-07 00:00 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
168		{
169		$manager = $this->get("starkerxp_campaign.manager.template");
170		if (!$entite = $manager->findOneBy(['id' => $request->get('template_id')])) {
171		return new JsonResponse(["payload" => $this->translate("entity.not_found", "template")], 404);
172		}
173		$manager->beginTransaction();
174		try {
175		$form = $this->createForm(TemplateType::class, $entite, ['method' => 'PUT']);
176		$form->submit($this->getRequestData($request));
177		if ($form->isValid()) {
178		$entite = $form->getData();
179		$manager->update($entite);
180		$this->dispatch(Events::TEMPLATE_UPDATED, new GenericEvent($entite));
181		return new JsonResponse(["payload" => $this->translate("template.entity.updated", "template")], 204);
182		}
183		} catch (\Exception $e) {
184		$manager->rollback();
185		return new JsonResponse(["payload" => $e->getMessage()], 400);
186		}
187		return new JsonResponse(["payload" => $this->getFormErrors($form)], 400);
188		}
189
190		/**
191		* @ApiDoc(
192		* resource=true,
193		* description="Supprime un template.",
194		* section="starkerxp_campaign.template",
195		* requirements={
196		* {
197		* "name"="template_id",
198		* "dataType"="integer",
199		* "requirement"="\d+",
200		* "description"="Permet de supprimer l'élément choisi."
201		* }
202		* },
203		* views = { "default" }
204		* )
205		*/
206	View Code Duplication	public function deleteAction(Request $request)
		0 ignored issues – show Duplication introduced 2017-09-07 00:00 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
207		{
208		$manager = $this->get("starkerxp_campaign.manager.template");
209		if (!$entite = $manager->findOneBy(['id' => $request->get('template_id')])) {
210		return new JsonResponse(["payload" => $this->translate("entity.not_found", "template")], 404);
211		}
212		try {
213		$manager->delete($entite);
214		} catch (\Exception $e) {
215		$manager->rollback();
216		return new JsonResponse(["payload" => $e->getMessage()], 400);
217		}
218		$this->dispatch(Events::TEMPLATE_DELETED, new GenericEvent($request->get('template_id')));
219
220		return new JsonResponse(["payload" => $this->translate("template.entity.deleted", "template")], 204);
221		}
222
223		}
		0 ignored issues – show Coding Style introduced 2017-05-10 00:39 UTC by Report Bug Copy Issue Report As per coding style, files should not end with a newline character. This check marks files that end in a newline character, i.e. an empy line. Loading history...
224

starker-xp / lapero.net

Push — master ( 4bb011...4b99be )

TemplateController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like