AbstractManager::delete() - Code Metrics - Inspection of "Gestion des templates au sein d'une api restful." - starker-xp/lapero.net - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7e9231...419bd7 )

by Guillaume

created 2017-01-26 01:44 UTC

AbstractManager::delete() A

↳ Parent: AbstractManager

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	1

<?php

namespace Starkerxp\StructureBundle\Manager;

use DateTime;
use Doctrine\ORM\EntityManager;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Doctrine\ORM\EntityRepository;
use Starkerxp\StructureBundle\Entity\Entity;
use Starkerxp\StructureBundle\Manager\Exception\ObjectClassNotAllowedException;

abstract class AbstractManager implements ManagerInterface
{
    /** @var EntityManager */
    protected $entityManager;

    /** @var EntityRepository */
    protected $repository;

    /**
     * @param EntityManager $entityManager
     * @param $entity
     */
    public function __construct(EntityManager $entityManager, $entity)
function someFunction(ManagerRegistry $registry) {
    $em = $registry->getManager();
    $em->getConnection()->beginTransaction();
    try {
        // Do something.
        $em->getConnection()->commit();
    } catch (\Exception $ex) {
        $em->getConnection()->rollback();
        $em->close();

        throw $ex;
    }
}
    {
        $this->entityManager = $entityManager;
        $this->repository = $this->entityManager->getRepository($entity);
    }

    /**
     * @param Entity $object
     *
     * @return Entity|boolean
     *
     * @throws ObjectClassNotAllowedException
     */
    public function insert(Entity $object)

    {
        if (!$this->getSupport($object)) {
            throw new ObjectClassNotAllowedException();
        }
        $object->setCreatedAt(new DateTime());
        $this->entityManager->persist($object);
        $this->entityManager->flush();

        return $object;
    }

    /**
     * @param Entity $object
     *
     * @return Entity|boolean
     *
     * @throws ObjectClassNotAllowedException
     */
    public function update(Entity $object)

    {
        if (!$this->getSupport($object)) {
            throw new ObjectClassNotAllowedException();
        }
        $object->setUpdatedAt(new DateTime());
        $this->entityManager->flush();

        return $object;
    }

    /**
     * @param Entity $object
     * @throws ObjectClassNotAllowedException
     */
    public function delete(Entity $object)
    {
        if (!$this->getSupport($object)) {
            throw new ObjectClassNotAllowedException();
        }
        $this->entityManager->remove($object);
        $this->entityManager->flush();
    }

    /**
     * Finds an entity by its primary key / identifier.
     *
     * @param mixed $id The identifier.
     * @param int|null $lockMode One of the \Doctrine\DBAL\LockMode::* constants
     *                              or NULL if no specific lock mode should be used
     *                              during the search.
     * @param int|null $lockVersion The lock version.
     *
     * @return object|null The entity instance or NULL if the entity can not be found.
     */
    public function find($id, $lockMode = null, $lockVersion = null)
    {
        return $this->repository->find($id, $lockMode, $lockVersion);
    }

    /**
     * Finds a single entity by a set of criteria.
     *
     * @param array $criteria
     * @param array|null $orderBy
     *
     * @return object|null The entity instance or NULL if the entity can not be found.
     */
    public function findOneBy(array $criteria, array $orderBy = null)
    {
        return $this->repository->findOneBy($criteria, $orderBy);
    }

    /**
     * Finds entities by a set of criteria.
     *
     * @param array $criteria
     * @param array|null $orderBy
     * @param int|null $limit
     * @param int|null $offset
     *
     * @return array The objects.
     */
    public function findBy(array $criteria, array $orderBy = null, $limit = null, $offset = null)
    {
        return $this->repository->findBy($criteria, $orderBy, $limit, $offset);
    }

    /**
     * Finds all entities in the repository.
     *
     * @return array The entities.
     */
    public function findAll()
    {
        return $this->repository->findAll();
    }

    /**
     * @return EntityRepository
     */
    public function getRepository()
    {
        return $this->repository;
    }


}


1		<?php
2
3		namespace Starkerxp\StructureBundle\Manager;
4
5		use DateTime;
6		use Doctrine\ORM\EntityManager;
		0 ignored issues – show Bug introduced 2016-10-19 22:46 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Starkerxp\StructureBundle\Manager\EntityManager`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
7		use Doctrine\ORM\EntityRepository;
8		use Starkerxp\StructureBundle\Entity\Entity;
9		use Starkerxp\StructureBundle\Manager\Exception\ObjectClassNotAllowedException;
10
11		abstract class AbstractManager implements ManagerInterface
12		{
13		/** @var EntityManager */
14		protected $entityManager;
15
16		/** @var EntityRepository */
17		protected $repository;
18
19		/**
20		* @param EntityManager $entityManager
21		* @param $entity
22		*/
23		public function __construct(EntityManager $entityManager, $entity)
		0 ignored issues – show Bug introduced 2016-10-19 22:46 UTC by Report Bug Copy Issue Report You have injected the EntityManager via parameter `$entityManager`. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via `getManager()` each time you need it. The `EntityManager` might become unusable for example if a transaction is rolled back and it gets closed. Let’s assume that somewhere in your application, or in a third-party library, there is code such as the following: function someFunction(ManagerRegistry $registry) { $em = $registry->getManager(); $em->getConnection()->beginTransaction(); try { // Do something. $em->getConnection()->commit(); } catch (\Exception $ex) { $em->getConnection()->rollback(); $em->close(); throw $ex; } } If that code throws an exception and the `EntityManager` is closed. Any other code which depends on the same instance of the `EntityManager` during this request will fail. On the other hand, if you instead inject the `ManagerRegistry`, the `getManager()` method guarantees that you will always get a usable manager instance. Loading history...
24		{
25		$this->entityManager = $entityManager;
26		$this->repository = $this->entityManager->getRepository($entity);
27		}
28
29		/**
30		* @param Entity $object
31		*
32		* @return Entity\|boolean
33		*
34		* @throws ObjectClassNotAllowedException
35		*/
36	View Code Duplication	public function insert(Entity $object)
		0 ignored issues – show Duplication introduced 2016-10-19 22:46 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
37		{
38		if (!$this->getSupport($object)) {
39		throw new ObjectClassNotAllowedException();
40		}
41		$object->setCreatedAt(new DateTime());
42		$this->entityManager->persist($object);
43		$this->entityManager->flush();
44
45		return $object;
46		}
47
48		/**
49		* @param Entity $object
50		*
51		* @return Entity\|boolean
52		*
53		* @throws ObjectClassNotAllowedException
54		*/
55	View Code Duplication	public function update(Entity $object)
		0 ignored issues – show Duplication introduced 2016-10-19 22:46 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
56		{
57		if (!$this->getSupport($object)) {
58		throw new ObjectClassNotAllowedException();
59		}
60		$object->setUpdatedAt(new DateTime());
61		$this->entityManager->flush();
62
63		return $object;
64		}
65
66		/**
67		* @param Entity $object
68		* @throws ObjectClassNotAllowedException
69		*/
70		public function delete(Entity $object)
71		{
72		if (!$this->getSupport($object)) {
73		throw new ObjectClassNotAllowedException();
74		}
75		$this->entityManager->remove($object);
76		$this->entityManager->flush();
77		}
78
79		/**
80		* Finds an entity by its primary key / identifier.
81		*
82		* @param mixed $id The identifier.
83		* @param int\|null $lockMode One of the \Doctrine\DBAL\LockMode::* constants
84		* or NULL if no specific lock mode should be used
85		* during the search.
86		* @param int\|null $lockVersion The lock version.
87		*
88		* @return object\|null The entity instance or NULL if the entity can not be found.
89		*/
90		public function find($id, $lockMode = null, $lockVersion = null)
91		{
92		return $this->repository->find($id, $lockMode, $lockVersion);
93		}
94
95		/**
96		* Finds a single entity by a set of criteria.
97		*
98		* @param array $criteria
99		* @param array\|null $orderBy
100		*
101		* @return object\|null The entity instance or NULL if the entity can not be found.
102		*/
103		public function findOneBy(array $criteria, array $orderBy = null)
104		{
105		return $this->repository->findOneBy($criteria, $orderBy);
106		}
107
108		/**
109		* Finds entities by a set of criteria.
110		*
111		* @param array $criteria
112		* @param array\|null $orderBy
113		* @param int\|null $limit
114		* @param int\|null $offset
115		*
116		* @return array The objects.
117		*/
118		public function findBy(array $criteria, array $orderBy = null, $limit = null, $offset = null)
119		{
120		return $this->repository->findBy($criteria, $orderBy, $limit, $offset);
121		}
122
123		/**
124		* Finds all entities in the repository.
125		*
126		* @return array The entities.
127		*/
128		public function findAll()
129		{
130		return $this->repository->findAll();
131		}
132
133		/**
134		* @return EntityRepository
135		*/
136		public function getRepository()
137		{
138		return $this->repository;
139		}
140
141
142		}
143

starker-xp / lapero.net

Push — master ( 7e9231...419bd7 )

AbstractManager::delete() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like