Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | class LeadControllerTest extends WebTest |
||
9 | { |
||
10 | |||
11 | /** |
||
12 | * @group lead |
||
13 | * @group post |
||
14 | * @group controller |
||
15 | */ |
||
16 | View Code Duplication | public function testPostValide() |
|
|
|||
17 | { |
||
18 | $this->loadFixtureFiles( |
||
19 | [ |
||
20 | '@StarkerxpUserBundle/Tests/DataFixtures/UserManager/DefaultUser.yml', |
||
21 | |||
22 | ] |
||
23 | ); |
||
24 | $data = [ |
||
25 | 'origin' => "validatemy.com", |
||
26 | 'external_reference' => '12', |
||
27 | 'product' => "form", |
||
28 | 'date_event' => "2017-08-05 00:00:00", |
||
29 | ]; |
||
30 | $url = $this->generateUrl( |
||
31 | 'starkerxp_lead.lead.post', |
||
32 | [] |
||
33 | ); |
||
34 | $client = $this->getAuthClient(); |
||
35 | $client->request('POST', $url, $data); |
||
36 | $response = $client->getResponse(); |
||
37 | $this->assertEquals(201, $response->getStatusCode()); |
||
38 | $manager = $this->getContainer()->get('starkerxp_lead.manager.lead'); |
||
39 | $leads = $manager->findAll(); |
||
40 | $this->assertCount(1, $leads); |
||
41 | } |
||
42 | |||
43 | /** |
||
44 | * @group lead |
||
45 | * @group post |
||
46 | * @group controller |
||
47 | */ |
||
48 | public function testPostInvalide() |
||
49 | { |
||
50 | $this->loadFixtureFiles( |
||
51 | [ |
||
52 | '@StarkerxpUserBundle/Tests/DataFixtures/UserManager/DefaultUser.yml', |
||
53 | |||
54 | ] |
||
55 | ); |
||
56 | $url = $this->generateUrl( |
||
57 | 'starkerxp_lead.lead.post', |
||
58 | [] |
||
59 | ); |
||
60 | $client = $this->getAuthClient(); |
||
61 | $client->request('POST', $url, []); |
||
62 | $response = $client->getResponse(); |
||
63 | $this->assertEquals(400, $response->getStatusCode()); |
||
64 | $body = json_decode($response->getContent(), true)['payload']; |
||
65 | //$this->assertArrayHasKey("nom", $body); // Exemple |
||
66 | } |
||
67 | |||
68 | |||
69 | /** |
||
70 | * @group lead |
||
71 | * @group put |
||
72 | * @group controller |
||
73 | */ |
||
74 | public function testPutValide() |
||
108 | |||
109 | /** |
||
110 | * @group lead |
||
111 | * @group put |
||
112 | * @group controller |
||
113 | */ |
||
114 | View Code Duplication | public function testPutInvalide() |
|
143 | |||
144 | /** |
||
145 | * @group lead |
||
146 | * @group put |
||
147 | * @group controller |
||
148 | */ |
||
149 | View Code Duplication | public function testPutSansResultat() |
|
173 | |||
174 | |||
175 | /** |
||
176 | * @group lead |
||
177 | * @group cget |
||
178 | * @group controller |
||
179 | */ |
||
180 | View Code Duplication | public function testCGetValideAvecResultats() |
|
205 | |||
206 | /** |
||
207 | * @group lead |
||
208 | * @group cget |
||
209 | * @group controller |
||
210 | */ |
||
211 | View Code Duplication | public function testCGetValideSansResultat() |
|
232 | |||
233 | /** |
||
234 | * @group lead |
||
235 | * @group cget |
||
236 | * @group controller |
||
237 | */ |
||
238 | View Code Duplication | public function testCGetInvalide() |
|
257 | |||
258 | /** |
||
259 | * @group lead |
||
260 | * @group get |
||
261 | * @group controller |
||
262 | */ |
||
263 | View Code Duplication | public function testGetValideAvecResultats() |
|
290 | |||
291 | /** |
||
292 | * @group lead |
||
293 | * @group get |
||
294 | * @group controller |
||
295 | */ |
||
296 | View Code Duplication | public function testGetValideSansResultat() |
|
317 | |||
318 | /** |
||
319 | * @group lead |
||
320 | * @group get |
||
321 | * @group controller |
||
322 | */ |
||
323 | View Code Duplication | public function testGetInvalide() |
|
342 | |||
343 | |||
344 | } |
||
345 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.