JsonDatabaseFactory::resolve() - Code Metrics - Inspection of "patch column collate export" - starker-xp/database-checker - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 81f2b1...625aec )

by Guillaume

created 2018-02-26 23:29 UTC

JsonDatabaseFactory::resolve() B

↳ Parent: JsonDatabaseFactory

Complexity

Conditions	5
Paths	7

Size

Total Lines	51
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	51
rs	8.6588
c	0
b	0
f	0
cc	5
eloc	31
nc	7
nop	0

How to fix Long Method

<?php

namespace Starkerxp\DatabaseChecker\Factory;

use Starkerxp\DatabaseChecker\Structure\MysqlDatabaseColumn;
use Starkerxp\DatabaseChecker\Structure\MysqlDatabaseTable;
use Symfony\Component\OptionsResolver\OptionsResolver;

/**
 * Convert json data to array object.
 *
 * @package Starkerxp\DatabaseChecker\Factory
 */
class JsonDatabaseFactory
{

    /**
     * @var string
     */
    private $json;

    /**
     * JsonDatabaseFactory constructor.
     *
     * @param string $json
     */
    public function __construct($json)
    {
        $this->json = $json;
    }

    /**
     * @return MysqlDatabaseTable[]
     *
     * @throws \Symfony\Component\OptionsResolver\Exception\UndefinedOptionsException
     * @throws \Symfony\Component\OptionsResolver\Exception\OptionDefinitionException
     * @throws \Symfony\Component\OptionsResolver\Exception\NoSuchOptionException
     * @throws \Symfony\Component\OptionsResolver\Exception\MissingOptionsException
     * @throws \Symfony\Component\OptionsResolver\Exception\InvalidOptionsException
     * @throws \Symfony\Component\OptionsResolver\Exception\AccessException
     * @throws \LogicException
     * @throws \RuntimeException
     */
    public function generate()
    {
        $tables = [];
        $dataTables = $this->resolve();
        foreach ($dataTables as $tableName => $dataTable) {
            try {
                $table = new MysqlDatabaseTable($tableName);
            } catch (\Exception $e) {
                continue;
            }
            if (isset($row['collate'])) {
                $table->setCollate($dataTable['collate']);
            }
            foreach ((array)$dataTable['columns'] as $columnName => $row) {
                $column = new MysqlDatabaseColumn($columnName, $row['type'], $row['length'], $row['nullable'], $row['defaultValue'], $row['extra']);
                if (isset($row['collate'])) {
                    $column->setCollate($row['collate']);
                }
                $table->addColumn($column);

            }
            foreach ((array)$dataTable['indexes'] as $row) {
                $table->addIndex($row['columns'], $row['name']);
            }
            if (isset($dataTable['primary'])) {
                $table->addPrimary((array)$dataTable['primary']);
            }
            foreach ((array)$dataTable['uniques'] as $row) {
                $table->addUnique($row['columns'], $row['name']);
            }
            $tables[] = $table;
        }

        return $tables;
    }

    /**
     * Check syntax of array.
     *
     * @return array
     *
     * @throws \Symfony\Component\OptionsResolver\Exception\UndefinedOptionsException
     * @throws \Symfony\Component\OptionsResolver\Exception\OptionDefinitionException
     * @throws \Symfony\Component\OptionsResolver\Exception\MissingOptionsException
     * @throws \Symfony\Component\OptionsResolver\Exception\InvalidOptionsException
     * @throws \Symfony\Component\OptionsResolver\Exception\AccessException
     * @throws \Symfony\Component\OptionsResolver\Exception\NoSuchOptionException
     */
    protected function resolve()
    {
        $data = $this->generateJsonData();

        // On force les valeurs par d�faut.
        $resolverTable = new OptionsResolver();
        $resolverTable->setRequired(['columns']);
        $resolverTable->setDefaults(
            [
                'columns' => [],
                'indexes' => [],
                'primary' => null,
                'uniques' => [],
                'collate' => null,
            ]
        );

        $resolverColumns = new OptionsResolver();
        $resolverColumns->setRequired(['type']);
        $resolverColumns->setDefaults(
            [
                'length' => null,
                'nullable' => false,
                'defaultValue' => null,
                'extra' => null,
                'collate' => null,
            ]
        );

        $resolverIndex = new OptionsResolver();
        $resolverIndex->setDefaults(
            [
                'name' => '',
                'columns' => [],
            ]
        );
        $export = [];
        foreach ($data as $nomTable => $table) {
            $dataTable = $resolverTable->resolve($table);
            foreach ((array)$dataTable['columns'] as $columnName => $column) {
                $dataTable['columns'][$columnName] = $resolverColumns->resolve($column);
            }
            foreach (['indexes', 'uniques'] as $indexKey) {
                foreach ((array)$dataTable[$indexKey] as $keyIndex => $index) {
                    $dataTable[$indexKey][$keyIndex] = $resolverIndex->resolve($index);
                }
            }
            $export[$nomTable] = $dataTable;
        }

        return $export;
    }

    private function generateJsonData()
    {
        if (empty($this->json)) {
            return [];
        }
        if (!$data = json_decode($this->json, true)) {
            $data = [];
        }
        return $data;
    }
}



1			<?php
2
3			namespace Starkerxp\DatabaseChecker\Factory;
4
5			use Starkerxp\DatabaseChecker\Structure\MysqlDatabaseColumn;
6			use Starkerxp\DatabaseChecker\Structure\MysqlDatabaseTable;
7			use Symfony\Component\OptionsResolver\OptionsResolver;
8
9			/**
10			* Convert json data to array object.
11			*
12			* @package Starkerxp\DatabaseChecker\Factory
13			*/
14			class JsonDatabaseFactory
15			{
16
17			/**
18			* @var string
19			*/
20			private $json;
21
22			/**
23			* JsonDatabaseFactory constructor.
24			*
25			* @param string $json
26			*/
27			public function __construct($json)
28			{
29			$this->json = $json;
30			}
31
32			/**
33			* @return MysqlDatabaseTable[]
34			*
35			* @throws \Symfony\Component\OptionsResolver\Exception\UndefinedOptionsException
36			* @throws \Symfony\Component\OptionsResolver\Exception\OptionDefinitionException
37			* @throws \Symfony\Component\OptionsResolver\Exception\NoSuchOptionException
38			* @throws \Symfony\Component\OptionsResolver\Exception\MissingOptionsException
39			* @throws \Symfony\Component\OptionsResolver\Exception\InvalidOptionsException
40			* @throws \Symfony\Component\OptionsResolver\Exception\AccessException
41			* @throws \LogicException
42			* @throws \RuntimeException
43			*/
44			public function generate()
45			{
46			$tables = [];
47			$dataTables = $this->resolve();
48			foreach ($dataTables as $tableName => $dataTable) {
49			try {
50			$table = new MysqlDatabaseTable($tableName);
51			} catch (\Exception $e) {
52			continue;
53			}
54			if (isset($row['collate'])) {
55			$table->setCollate($dataTable['collate']);
56			}
57			foreach ((array)$dataTable['columns'] as $columnName => $row) {
58			$column = new MysqlDatabaseColumn($columnName, $row['type'], $row['length'], $row['nullable'], $row['defaultValue'], $row['extra']);
59			if (isset($row['collate'])) {
60			$column->setCollate($row['collate']);
61			}
62			$table->addColumn($column);
63
64			}
65			foreach ((array)$dataTable['indexes'] as $row) {
66			$table->addIndex($row['columns'], $row['name']);
67			}
68			if (isset($dataTable['primary'])) {
69			$table->addPrimary((array)$dataTable['primary']);
70			}
71			foreach ((array)$dataTable['uniques'] as $row) {
72			$table->addUnique($row['columns'], $row['name']);
73			}
74			$tables[] = $table;
75			}
76
77			return $tables;
78			}
79
80			/**
81			* Check syntax of array.
82			*
83			* @return array
84			*
85			* @throws \Symfony\Component\OptionsResolver\Exception\UndefinedOptionsException
86			* @throws \Symfony\Component\OptionsResolver\Exception\OptionDefinitionException
87			* @throws \Symfony\Component\OptionsResolver\Exception\MissingOptionsException
88			* @throws \Symfony\Component\OptionsResolver\Exception\InvalidOptionsException
89			* @throws \Symfony\Component\OptionsResolver\Exception\AccessException
90			* @throws \Symfony\Component\OptionsResolver\Exception\NoSuchOptionException
91			*/
92			protected function resolve()
93			{
94			$data = $this->generateJsonData();
95
96			// On force les valeurs par d�faut.
97			$resolverTable = new OptionsResolver();
98			$resolverTable->setRequired(['columns']);
99			$resolverTable->setDefaults(
100			[
101			'columns' => [],
102			'indexes' => [],
103			'primary' => null,
104			'uniques' => [],
105			'collate' => null,
106			]
107			);
108
109			$resolverColumns = new OptionsResolver();
110			$resolverColumns->setRequired(['type']);
111			$resolverColumns->setDefaults(
112			[
113			'length' => null,
114			'nullable' => false,
115			'defaultValue' => null,
116			'extra' => null,
117			'collate' => null,
118			]
119			);
120
121			$resolverIndex = new OptionsResolver();
122			$resolverIndex->setDefaults(
123			[
124			'name' => '',
125			'columns' => [],
126			]
127			);
128			$export = [];
129			foreach ($data as $nomTable => $table) {
130			$dataTable = $resolverTable->resolve($table);
131			foreach ((array)$dataTable['columns'] as $columnName => $column) {
132			$dataTable['columns'][$columnName] = $resolverColumns->resolve($column);
133			}
134			foreach (['indexes', 'uniques'] as $indexKey) {
135			foreach ((array)$dataTable[$indexKey] as $keyIndex => $index) {
136			$dataTable[$indexKey][$keyIndex] = $resolverIndex->resolve($index);
137			}
138			}
139			$export[$nomTable] = $dataTable;
140			}
141
142			return $export;
143			}
144
145			private function generateJsonData()
146			{
147			if (empty($this->json)) {
148			return [];
149			}
150			if (!$data = json_decode($this->json, true)) {
151			$data = [];
152			}
153			return $data;
154			}
155			}
			0 ignored issues – show Coding Style introduced 2018-02-26 23:31 UTC by Report Bug Copy Issue Report As per coding style, files should not end with a newline character. This check marks files that end in a newline character, i.e. an empy line. Loading history...
156

starker-xp / database-checker

Push — master ( 81f2b1...625aec )

JsonDatabaseFactory::resolve() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like