allejo\stakx\Utilities\ArrayUtilities

Complexity

Total Complexity

13

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

80%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	is_multidimensional()	0	12	3
D	array_merge_defaults()	0	46	10

<?php

/**
 * @copyright 2017 Vladimir Jimenez
 * @license   https://github.com/allejo/stakx/blob/master/LICENSE.md MIT
 */

namespace allejo\stakx\Utilities;

abstract class ArrayUtilities

ArrayUtilities does not seem to conform to the naming convention (Utils?$).

{
    public static function is_multidimensional(array &$array)

This method is not in camel caps format.

function is_multidimensional() does not seem to conform to the naming convention (^(?:[a-z]|__)[a-zA-Z0-9]*$).

    {
        foreach ($array as $element)
        {
            if (is_array($element))
            {
                return true;
            }
        }

        return false;
    }

    public static function array_merge_defaults(array &$array1, array &$array2, $keyField)

This method is not in camel caps format.

function array_merge_defaults() does not seem to conform to the naming convention (^(?:[a-z]|__)[a-zA-Z0-9]*$).

    {
        $merged = $array1;

        foreach ($array2 as $key => &$value)
        {
            $valueMerged = false;

            foreach ($merged as $mergedKey => &$item)
            {
                if (is_array($item) && array_key_exists($keyField, $item) && $item[$keyField] == $value[$keyField])
                {
                    $item = array_merge($item, $value);

Equals sign not aligned with surrounding assignments; expected 8 spaces but found 1 space

                    $valueMerged = true;

                    break;
                }
                elseif ($mergedKey == $key)
                {
                    if (is_numeric($mergedKey))
                    {
                        $merged[] = $value;
                    }
                    elseif (is_array($item))
                    {
                        $item = array_unique(array_merge($item, $value));
                    }
                    else
                    {
                        $item = $value;
                    }

                    $valueMerged = true;

                    break;
                }
            }

            if (!$valueMerged)
            {
                $merged[$key] = $value;
            }
        }

        return $merged;
    }
}