Complex classes like PageManager often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use PageManager, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
25 | class PageManager extends TrackingManager |
||
26 | { |
||
27 | /** |
||
28 | * The relative (to the stakx project) file path to the redirect template |
||
29 | * |
||
30 | * @var string|bool |
||
31 | */ |
||
32 | private $redirectTemplate; |
||
33 | |||
34 | /** |
||
35 | * @var PageView[] |
||
36 | */ |
||
37 | private $twigExtendsDeps; |
||
38 | |||
39 | /** |
||
40 | * @var ContentItem[][] |
||
41 | */ |
||
42 | private $collections; |
||
43 | |||
44 | /** |
||
45 | * @var Folder |
||
46 | */ |
||
47 | private $targetDir; |
||
48 | |||
49 | /** |
||
50 | * @var PageView[] |
||
51 | */ |
||
52 | private $flatPages; |
||
53 | |||
54 | private $siteMenu; |
||
55 | |||
56 | private $twigOpts; |
||
57 | |||
58 | /** |
||
59 | * @var \Twig_Environment |
||
60 | */ |
||
61 | private $twig; |
||
62 | |||
63 | /** |
||
64 | * PageManager constructor |
||
65 | */ |
||
66 | 1 | public function __construct() |
|
72 | |||
73 | 1 | public function setCollections (&$collections) |
|
79 | |||
80 | public function setRedirectTemplate ($filePath) |
||
84 | |||
85 | /** |
||
86 | * @param Folder $folder The relative target directory as specified from the configuration file |
||
87 | */ |
||
88 | 1 | public function setTargetFolder (&$folder) |
|
92 | |||
93 | 1 | public function configureTwig ($configuration, $options) |
|
100 | |||
101 | 1 | public function createTwigManager () |
|
111 | |||
112 | public function getFlatPages () |
||
116 | |||
117 | /** |
||
118 | * An array representing the website's menu structure with children and grandchildren made from static PageViews |
||
119 | * |
||
120 | * @return array |
||
121 | */ |
||
122 | public function getSiteMenu () |
||
137 | |||
138 | /** |
||
139 | * Go through all of the PageView directories and create a respective PageView for each and classify them as a |
||
140 | * dynamic or static PageView. |
||
141 | * |
||
142 | * @param $pageViewFolders |
||
143 | */ |
||
144 | 1 | public function parsePageViews ($pageViewFolders) |
|
170 | |||
171 | /** |
||
172 | * Compile dynamic and static PageViews |
||
173 | */ |
||
174 | 1 | public function compileAll () |
|
181 | |||
182 | public function compileSome ($filter = array()) |
||
193 | |||
194 | /** |
||
195 | * @param ContentItem $contentItem |
||
196 | */ |
||
197 | public function compileContentItem (&$contentItem) |
||
218 | |||
219 | /** |
||
220 | * Add a new ContentItem to the respective parent PageView of the ContentItem |
||
221 | * |
||
222 | * @param ContentItem $contentItem |
||
223 | */ |
||
224 | public function updatePageView ($contentItem) |
||
237 | |||
238 | /** |
||
239 | * Update an existing Twig variable that's injected globally |
||
240 | * |
||
241 | * @param string $variable |
||
242 | * @param string $value |
||
243 | */ |
||
244 | public function updateTwigVariable ($variable, $value) |
||
248 | |||
249 | /** |
||
250 | * {@inheritdoc} |
||
251 | */ |
||
252 | 1 | public function isTracked($filePath) |
|
256 | |||
257 | /** |
||
258 | * {@inheritdoc} |
||
259 | */ |
||
260 | public function refreshItem($filePath) |
||
276 | |||
277 | /** |
||
278 | * {@inheritdoc} |
||
279 | */ |
||
280 | 1 | protected function handleTrackableItem($filePath, $options = array()) |
|
311 | |||
312 | /** |
||
313 | * Compile a given PageView |
||
314 | * |
||
315 | * @param string $filePath The file path to the PageView to compile |
||
316 | * @param bool $refresh When set to true, the PageView will reread its contents |
||
317 | * |
||
318 | * @throws \Exception |
||
319 | */ |
||
320 | 1 | private function compileFromFilePath ($filePath, $refresh = false) |
|
332 | |||
333 | /** |
||
334 | * @param DynamicPageView|PageView|RepeaterPageView $pageView |
||
335 | * @param bool $refresh |
||
336 | */ |
||
337 | 1 | private function compilePageView ($pageView, $refresh = false) |
|
362 | |||
363 | /** |
||
364 | * @param RepeaterPageView $pageView |
||
365 | */ |
||
366 | 1 | private function compileRepeaterPageView (&$pageView) |
|
387 | |||
388 | /** |
||
389 | * @param PageView $pageView |
||
390 | */ |
||
391 | private function compileDynamicPageView (&$pageView) |
||
409 | |||
410 | /** |
||
411 | * @param PageView $pageView |
||
412 | */ |
||
413 | private function compileStaticPageView (&$pageView) |
||
425 | |||
426 | /** |
||
427 | * @param DynamicPageView|PageView $pageView |
||
428 | */ |
||
429 | private function compileNormalRedirects (&$pageView) |
||
442 | |||
443 | /** |
||
444 | * @param RepeaterPageView $pageView |
||
445 | */ |
||
446 | 1 | private function compileExpandedRedirects (&$pageView) |
|
469 | |||
470 | /** |
||
471 | * Add a static PageView to the menu array. Dynamic PageViews are not added to the menu |
||
472 | * |
||
473 | * @param PageView $pageView |
||
474 | */ |
||
475 | 1 | private function addToSiteMenu (&$pageView) |
|
519 | |||
520 | /** |
||
521 | * @param PageView $pageView |
||
522 | * |
||
523 | * @return Twig_Template |
||
524 | * @throws Twig_Error_Syntax |
||
525 | */ |
||
526 | 1 | private function createTemplate (&$pageView) |
|
544 | |||
545 | /** |
||
546 | * Find the parent Twig templates of the given template and keep a list of it |
||
547 | * |
||
548 | * @param Twig_Template $template The template created from the PageView's content |
||
549 | * @param PageView $pageView The PageView that has this content. Used to keep a reference of PageViews |
||
550 | */ |
||
551 | 1 | private function trackParentTwigTemplate ($template, &$pageView) |
|
566 | } |