Completed
Push — master ( c2b5cc...89bfcf )
by Vladimir
03:33
created

FrontMatterDocument   B

Complexity

Total Complexity 49

Size/Duplication

Total Lines 416
Duplicated Lines 2.64 %

Coupling/Cohesion

Components 1
Dependencies 8

Test Coverage

Coverage 79.46%

Importance

Changes 0
Metric Value
wmc 49
lcom 1
cbo 8
dl 11
loc 416
ccs 89
cts 112
cp 0.7946
rs 8.5454
c 0
b 0
f 0

19 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 7 1
getContent() 0 1 ?
A getLineOffset() 0 4 1
A getName() 0 4 1
A hasTwigDependency() 0 6 3
A findTwigDataDependencies() 0 9 1
A hasExpandedFrontMatter() 0 4 2
A offsetUnset() 0 4 1
B refreshFileContent() 0 52 7
C buildPermalink() 11 27 7
A evaluateFrontMatter() 0 8 2
A getFrontMatter() 0 13 4
A appendFrontMatter() 0 7 2
A deleteFrontMatter() 0 9 2
A setFrontMatter() 0 9 2
A evaluateYaml() 0 15 2
A offsetSet() 0 9 2
A offsetExists() 0 11 4
B offsetGet() 0 21 5

How to fix   Duplicated Code    Complexity   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

Complex Class

 Tip:   Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like FrontMatterDocument often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use FrontMatterDocument, and based on these observations, apply Extract Interface, too.

1
<?php
2
3
/**
4
 * @copyright 2017 Vladimir Jimenez
5
 * @license   https://github.com/allejo/stakx/blob/master/LICENSE.md MIT
6
 */
7
8
namespace allejo\stakx\FrontMatter;
9
10
use allejo\stakx\Document\JailedDocumentInterface;
11
use allejo\stakx\Document\PermalinkDocument;
12
use allejo\stakx\Exception\FileAwareException;
13
use allejo\stakx\Exception\InvalidSyntaxException;
14
use allejo\stakx\FrontMatter\Exception\YamlVariableUndefinedException;
15
use Symfony\Component\Filesystem\Exception\FileNotFoundException;
16
use Symfony\Component\Filesystem\Exception\IOException;
17
use Symfony\Component\Yaml\Exception\ParseException;
18
use Symfony\Component\Yaml\Yaml;
19
20
abstract class FrontMatterDocument extends PermalinkDocument implements
21
    \ArrayAccess,
22
    JailedDocumentInterface,
23
    WritableDocumentInterface
24
{
25
    const TEMPLATE = "---\n%s\n---\n\n%s";
26
27
    /**
28
     * The names of FrontMatter keys that are specially defined for all Documents
29
     *
30
     * @var array
31
     */
32
    public static $specialFrontMatterKeys = array(
0 ignored issues
show
Comprehensibility Naming introduced by
The variable name $specialFrontMatterKeys exceeds the maximum configured length of 20.

Very long variable names usually make code harder to read. It is therefore recommended not to make variable names too verbose.

Loading history...
33
        'filename', 'basename'
34
    );
35
36
    protected static $whiteListFunctions = array(
37
        'getPermalink', 'getRedirects', 'getTargetFile', 'getName', 'getFilePath', 'getRelativeFilePath', 'getContent',
38
        'getExtension', 'getFrontMatter'
39
    );
40
41
    /**
42
     * An array to keep track of collection or data dependencies used inside of a Twig template.
43
     *
44
     * $dataDependencies['collections'] = array()
45
     * $dataDependencies['data'] = array()
46
     *
47
     * @var array
48
     */
49
    protected $dataDependencies;
50
51
    /**
52
     * FrontMatter values that can be injected or set after the file has been parsed. Values in this array will take
53
     * precedence over values in $frontMatter.
54
     *
55
     * @var array
56
     */
57
    protected $writableFrontMatter;
58
59
    /**
60
     * A list of Front Matter values that should not be returned directly from the $frontMatter array. Values listed
61
     * here have dedicated functions that handle those Front Matter values and the respective functions should be called
62
     * instead.
63
     *
64
     * @var string[]
65
     */
66
    protected $frontMatterBlacklist;
67
68
    /**
69
     * Set to true if the front matter has already been evaluated with variable interpolation.
70
     *
71
     * @var bool
72
     */
73
    protected $frontMatterEvaluated;
74
75
    /**
76
     * @var Parser
77
     */
78
    protected $frontMatterParser;
79
80
    /**
81
     * An array containing the Yaml of the file.
82
     *
83
     * @var array
84
     */
85
    protected $frontMatter;
86
87
    /**
88
     * Set to true if the body has already been parsed as markdown or any other format.
89
     *
90
     * @var bool
91
     */
92
    protected $bodyContentEvaluated;
93
94
    /**
95
     * Only the body of the file, i.e. the content.
96
     *
97
     * @var string
98
     */
99
    protected $bodyContent;
100
101
    /**
102
     * The number of lines that Twig template errors should offset.
103
     *
104
     * @var int
105
     */
106
    private $lineOffset;
107
108
    /**
109
     * ContentItem constructor.
110
     *
111
     * @param string $filePath The path to the file that will be parsed into a ContentItem
112
     *
113
     * @throws FileNotFoundException The given file path does not exist
114
     * @throws IOException           The file was not a valid ContentItem. This would meam there was no front matter or
115
     *                               no body
116
     */
117 137
    public function __construct($filePath)
118
    {
119 137
        $this->frontMatterBlacklist = array('permalink', 'redirects');
120 137
        $this->writableFrontMatter = array();
121
122 137
        parent::__construct($filePath);
123 125
    }
124
125
    /**
126
     * Return the body of the Content Item.
127
     *
128
     * @return string
129
     */
130
    abstract public function getContent();
131
132
    /**
133
     * The number of lines that are taken up by FrontMatter and white space.
134
     *
135
     * @return int
136
     */
137
    final public function getLineOffset()
138
    {
139
        return $this->lineOffset;
140
    }
141
142
    /**
143
     * Get the name of the item, which is just the filename without the extension.
144
     *
145
     * @return string
146
     */
147 62
    final public function getName()
148
    {
149 62
        return $this->getBaseName();
150
    }
151
152
    /**
153
     * Check whether this object has a reference to a collection or data item.
154
     *
155
     * @param string $namespace 'collections' or 'data'
156
     * @param string $needle
157
     *
158
     * @return bool
159
     */
160 17
    final public function hasTwigDependency($namespace, $needle)
161
    {
162
        return
163 17
            in_array($needle, $this->dataDependencies[$namespace]) ||
164 17
            (is_null($needle) && !empty($this->dataDependencies[$namespace]));
165
    }
166
167
    /**
168
     * Read the file, and parse its contents.
169
     */
170 137
    final public function refreshFileContent()
171
    {
172
        // This function can be called after the initial object was created and the file may have been deleted since the
173
        // creation of the object.
174 137
        if (!$this->fs->exists($this->filePath))
175
        {
176 2
            throw new FileNotFoundException(null, 0, null, $this->filePath);
177
        }
178
179
        // $fileStructure[1] is the YAML
0 ignored issues
show
Unused Code Comprehensibility introduced by
37% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
180
        // $fileStructure[2] is the amount of new lines after the closing `---` and the beginning of content
181
        // $fileStructure[3] is the body of the document
182 136
        $fileStructure = array();
183
184 136
        $rawFileContents = file_get_contents($this->filePath);
185 136
        preg_match('/---\R(.*?\R)?---(\s+)(.*)/s', $rawFileContents, $fileStructure);
186
187 136
        if (count($fileStructure) != 4)
188
        {
189 9
            throw new InvalidSyntaxException('Invalid FrontMatter file', 0, null, $this->getRelativeFilePath());
190
        }
191
192 127
        if (empty(trim($fileStructure[3])))
193
        {
194 1
            throw new InvalidSyntaxException('FrontMatter files must have a body to render', 0, null, $this->getRelativeFilePath());
195
        }
196
197
        // The hard coded 1 is the offset used to count the new line used after the first `---` that is not caught in the regex
198 126
        $this->lineOffset = substr_count($fileStructure[1], "\n") + substr_count($fileStructure[2], "\n") + 1;
199 126
        $this->bodyContent = $fileStructure[3];
200
201 126
        if (!empty(trim($fileStructure[1])))
202
        {
203 92
            $this->frontMatter = Yaml::parse($fileStructure[1], Yaml::PARSE_DATETIME);
0 ignored issues
show
Documentation Bug introduced by
It seems like \Symfony\Component\Yaml\...l\Yaml::PARSE_DATETIME) can also be of type string or object<stdClass>. However, the property $frontMatter is declared as type array. Maybe add an additional type check?

Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly.

For example, imagine you have a variable $accountId that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the id property of an instance of the Account class. This class holds a proper account, so the id value must no longer be false.

Either this assignment is in error or a type check should be added for that assignment.

class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
Loading history...
204
205 92
            if (!empty($this->frontMatter) && !is_array($this->frontMatter))
206
            {
207 92
                throw new ParseException('The evaluated FrontMatter should be an array');
208
            }
209
        }
210
        else
211
        {
212 37
            $this->frontMatter = array();
213
        }
214
215 125
        $this->frontMatterEvaluated = false;
216 125
        $this->bodyContentEvaluated = false;
217 125
        $this->permalink = null;
0 ignored issues
show
Documentation Bug introduced by
It seems like null of type null is incompatible with the declared type array of property $permalink.

Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.

Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..

Loading history...
218
219 125
        $this->findTwigDataDependencies('collections');
220 125
        $this->findTwigDataDependencies('data');
221 125
    }
222
223
    /**
224
     * Get all of the references to either DataItems or ContentItems inside of given string.
225
     *
226
     * @param string $filter 'collections' or 'data'
227
     */
228 125
    private function findTwigDataDependencies($filter)
229
    {
230 125
        $regex = "/{[{%].*?(?:$filter)(?:\.|\[')?([^_\W]+)?(?:\.|'\])?[^_=]*?[%}]}/";
231 125
        $results = array();
232
233 125
        preg_match_all($regex, $this->bodyContent, $results);
234
235 125
        $this->dataDependencies[$filter] = array_unique($results[1]);
236 125
    }
237
238
    //
239
    // Permalink and redirect functionality
240
    //
241
242 39
    final protected function buildPermalink()
243
    {
244 39
        if (!is_null($this->permalink))
245
        {
246 8
            return;
247
        }
248
249 37
        if (!is_null($this->frontMatterParser) && $this->frontMatterParser->hasExpansion())
250
        {
251
            throw new \Exception('The permalink for this item has not been set');
252
        }
253
254 37
        $permalink = (is_array($this->frontMatter) && isset($this->frontMatter['permalink'])) ?
255 37
            $this->frontMatter['permalink'] : $this->getPathPermalink();
256
257 37 View Code Duplication
        if (is_array($permalink))
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
258
        {
259 19
            $this->permalink = $permalink[0];
260 19
            array_shift($permalink);
261 19
            $this->redirects = $permalink;
262
        }
263
        else
264
        {
265 24
            $this->permalink = $permalink;
266 24
            $this->redirects = array();
267
        }
268 37
    }
269
270
    //
271
    // WritableFrontMatter Implementation
272
    //
273
274
    /**
275
     * {@inheritdoc}
276
     */
277 7
    final public function evaluateFrontMatter($variables = null)
278
    {
279 7
        if (!is_null($variables))
280
        {
281 7
            $this->frontMatter = array_merge($this->frontMatter, $variables);
282 7
            $this->evaluateYaml($this->frontMatter);
283
        }
284 7
    }
285
286
    /**
287
     * {@inheritdoc}
288
     */
289 29
    final public function getFrontMatter($evaluateYaml = true)
290
    {
291 29
        if (is_null($this->frontMatter))
292
        {
293
            $this->frontMatter = array();
294
        }
295 29
        elseif (!$this->frontMatterEvaluated && $evaluateYaml)
296
        {
297 23
            $this->evaluateYaml($this->frontMatter);
298
        }
299
300 28
        return $this->frontMatter;
301
    }
302
303
    /**
304
     * {@inheritdoc}
305
     */
306 2
    final public function hasExpandedFrontMatter()
307
    {
308 2
        return !is_null($this->frontMatterParser) && $this->frontMatterParser->hasExpansion();
309
    }
310
311
    /**
312
     * {@inheritdoc.
313
     */
314
    final public function appendFrontMatter(array $frontMatter)
315
    {
316
        foreach ($frontMatter as $key => $value)
317
        {
318
            $this->writableFrontMatter[$key] = $value;
319
        }
320
    }
321
322
    /**
323
     * {@inheritdoc.
324
     */
325
    final public function deleteFrontMatter($key)
326
    {
327
        if (!isset($this->writableFrontMatter[$key]))
328
        {
329
            return;
330
        }
331
332
        unset($this->writableFrontMatter[$key]);
333
    }
334
335
    /**
336
     * {@inheritdoc.
337
     */
338 2
    final public function setFrontMatter(array $frontMatter)
339
    {
340 2
        if (!is_array($frontMatter))
341
        {
342
            throw new \InvalidArgumentException('An array is required for setting the writable FrontMatter');
343
        }
344
345 2
        $this->writableFrontMatter = $frontMatter;
346 2
    }
347
348
    /**
349
     * Evaluate an array of data for FrontMatter variables. This function will modify the array in place.
350
     *
351
     * @param array $yaml An array of data containing FrontMatter variables
352
     *
353
     * @throws YamlVariableUndefinedException A FrontMatter variable used does not exist
354
     */
355 30
    private function evaluateYaml(&$yaml)
356
    {
357
        try
358
        {
359 30
            $this->frontMatterParser = new Parser($yaml, array(
360 30
                'filename' => $this->getFileName(),
361 30
                'basename' => $this->getName(),
362
            ));
363 29
            $this->frontMatterEvaluated = true;
364
        }
365 1
        catch (\Exception $e)
366
        {
367 1
            throw FileAwareException::castException($e, $this->getRelativeFilePath());
368
        }
369 29
    }
370
371
    //
372
    // ArrayAccess Implementation
373
    //
374
375
    /**
376
     * {@inheritdoc}
377
     */
378
    public function offsetSet($offset, $value)
379
    {
380
        if (is_null($offset))
381
        {
382
            throw new \InvalidArgumentException('$offset cannot be null');
383
        }
384
385
        $this->writableFrontMatter[$offset] = $value;
386
    }
387
388
    /**
389
     * {@inheritdoc}
390
     */
391 34
    public function offsetExists($offset)
392
    {
393 34
        if (isset($this->writableFrontMatter[$offset]) || isset($this->frontMatter[$offset]))
394
        {
395 33
            return true;
396
        }
397
398 14
        $fxnCall = 'get' . ucfirst($offset);
399
400 14
        return method_exists($this, $fxnCall) && in_array($fxnCall, static::$whiteListFunctions);
401
    }
402
403
    /**
404
     * {@inheritdoc}
405
     */
406
    public function offsetUnset($offset)
407
    {
408
        unset($this->writableFrontMatter[$offset]);
409
    }
410
411
    /**
412
     * {@inheritdoc}
413
     */
414 51
    public function offsetGet($offset)
415
    {
416 51
        $fxnCall = 'get' . ucfirst($offset);
417
418 51
        if (in_array($fxnCall, self::$whiteListFunctions) && method_exists($this, $fxnCall))
419
        {
420 6
            return call_user_func_array(array($this, $fxnCall), array());
421
        }
422
423 45
        if (isset($this->writableFrontMatter[$offset]))
424
        {
425
            return $this->writableFrontMatter[$offset];
426
        }
427
428 45
        if (isset($this->frontMatter[$offset]))
429
        {
430 44
            return $this->frontMatter[$offset];
431
        }
432
433 5
        return null;
434
    }
435
}
436