allejo\stakx\Manager\MenuManager

Complexity

Total Complexity

19

Size/Duplication

Total Lines	103
Duplicated Lines	12.62 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	buildFromPageViews()	0	7	2
C	addToSiteMenu()	13	53	13
A	getSiteMenu()	0	17	3

<?php

/**
 * @copyright 2017 Vladimir Jimenez
 * @license   https://github.com/allejo/stakx/blob/master/LICENSE.md MIT
 */

namespace allejo\stakx\Manager;

use allejo\stakx\Object\JailObject;
use allejo\stakx\Object\PageView;

class MenuManager extends BaseManager
{
    /** @var PageView */
    private $siteMenu;

    public function __construct()
    {
        parent::__construct();

        $this->siteMenu = array();

It seems like array() of type array is incompatible with the declared type object<allejo\stakx\Object\PageView> of property $siteMenu.

    }

    /**
     * An array representing the website's menu structure with children and grandchildren made from static PageViews
     *
     * @return JailObject[]
     */
    public function getSiteMenu ()
    {
        $jailedMenu = array();

        foreach ($this->siteMenu as $key => $value)

The expression $this->siteMenu of type object<allejo\stakx\Object\PageView> is not traversable.

        {
            // If it's an array, it means the parent is hidden from the site menu therefore its children should be too
            if (is_array($this->siteMenu[$key]))
            {
                continue;
            }

            $jailedMenu[$key] = $value->createJail();
        }

        return $jailedMenu;
    }

    /**
     * @param PageView[] $pageViews
     */
    public function buildFromPageViews ($pageViews)
    {
        foreach ($pageViews as &$pageView)
        {
            $this->addToSiteMenu($pageView);
        }
    }

    /**
     * @param PageView $pageView
     */
    public function addToSiteMenu (&$pageView)
    {
        $frontMatter = $pageView->getFrontMatter();

        if (isset($frontMatter['menu']) && !$frontMatter['menu'])
        {
            return;
        }

        $url = trim($pageView->getPermalink(), '/');

        // @TODO in the next breaking release, remove this check and allow the homepage to be indexed as '.'

Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker.

        if (empty($url))
        {
            return;
        }

        $root = &$this->siteMenu;
        $dirs = explode('/', $url);

        while (count($dirs) > 0)
        {
            $name = array_shift($dirs);
            $name = (!empty($name)) ? $name : '.';

            if (!is_null($name) && count($dirs) == 0)
            {
                if (isset($root[$name]) && is_array($root[$name]))

This code seems to be duplicated across your project.

                {
                    $children = &$pageView->getChildren();
                    $children = $root[$name]['children'];
                }

                $root[$name] = &$pageView;
            }
            else
            {
                if (!isset($root[$name]))
                {
                    $root[$name]['children'] = array();
                    $root = &$root[$name]['children'];
                }
                else if (isset($root[$name]) && is_array($root[$name]))

This code seems to be duplicated across your project.

                {
                    $root = &$root[$name]['children'];
                }
                else
                {
                    $root = &$root[$name]->getChildren();
                }
            }
        }
    }
}