Compiler - Code Metrics - Inspection of "Split up the PageManager class" - stakx-io/stakx - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#41)

by Vladimir

created 2017-03-22 07:21 UTC

Compiler A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	310
Duplicated Lines	10 %

Coupling/Cohesion

Components	1
Dependencies	13

Test Coverage

Coverage

66.67%

Importance

Changes

Metric	Value
dl	31
loc	310
ccs	38
cts	57
cp	0.6667
rs	10
c	0
b	0
f	0
wmc	25
lcom	1
cbo	13

15 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	setTargetFolder()	0	4	1
A	setPageViews()	0	4	1
A	setRedirectTemplate()	0	4	1
A	compileDynamicPageViews()	14	14	2
A	compileRepeaterPageViews()	17	17	2
A	compileExpandedRedirects()	0	22	3
A	renderRepeaterPageView()	0	14	1
A	renderDynamicPageView()	0	9	1
A	compileAll()	0	7	2
A	compilePageView()	0	20	4
A	compileStaticPageView()	0	8	1
A	compileStandardRedirects()	0	15	2
A	renderStaticPageView()	0	10	1
A	createTwigTemplate()	0	18	2

How to fix Duplicated Code

<?php

/**
 * @copyright 2017 Vladimir Jimenez
 * @license   https://github.com/allejo/stakx/blob/master/LICENSE.md MIT
 */

namespace allejo\stakx;

use allejo\stakx\FrontMatter\ExpandedValue;
use allejo\stakx\Manager\BaseManager;
use allejo\stakx\Manager\TwigManager;
use allejo\stakx\Object\ContentItem;
use allejo\stakx\Object\DynamicPageView;
use allejo\stakx\Object\PageView;
use allejo\stakx\Object\RepeaterPageView;
use allejo\stakx\System\Folder;
use Twig_Environment;
use Twig_Error_Syntax;
use Twig_Source;
use Twig_Template;

/**
 * This class takes care of rendering the Twig body of PageViews with the respective information and it also takes care
 * of writing the rendered Twig to the filesystem.
 *
 * @internal
 * @since 0.1.1
 */
class Compiler extends BaseManager
{
    /** @var string|false */
    private $redirectTemplate;

    /** @var PageView[] */
    private $pageViews;

    /** @var Folder */
    private $folder;

    /** @var Twig_Environment */
    private $twig;

    public function __construct()
    {
        parent::__construct();

        $this->twig = TwigManager::getInstance();
    }

    /**
     * @param string|false $template
     */
    public function setRedirectTemplate ($template)
    {
        $this->redirectTemplate = $template;
    }

    /**
     * @param Folder $folder
     */
    public function setTargetFolder (Folder $folder)
    {
        $this->folder = $folder;
    }

    /**
     * @param PageView[] $pageViews
     */
    public function setPageViews (array $pageViews)
    {
        $this->pageViews = $pageViews;
    }

    ///
    // IO Functionality
    ///

    /**
     * Compile all of the PageViews registered with the compiler
     *
     * @since 0.1.0
     */
    public function compileAll ()
    {
        foreach ($this->pageViews as &$pageView)
        {
            $this->compilePageView($pageView);
        }
    }

    /**
     * Compile an individual PageView item
     *
     * This function will take care of determining *how* to treat the PageView and write the compiled output to a the
     * respective target file.
     *
     * @param DynamicPageView|RepeaterPageView|PageView $pageView The PageView that needs to be compiled
     * @since 0.1.1
     */
    private function compilePageView (&$pageView)
    {
        switch ($pageView->getType())
        {
            case PageView::STATIC_TYPE:
                $this->compileStaticPageView($pageView);
                $this->compileStandardRedirects($pageView);
                break;

            case PageView::DYNAMIC_TYPE:
                $this->compileDynamicPageViews($pageView);

                $this->compileStandardRedirects($pageView);
                break;

            case PageView::REPEATER_TYPE:
                $this->compileRepeaterPageViews($pageView);

                $this->compileExpandedRedirects($pageView);
                break;
        }
    }

    /**
     * Write the compiled output for a static PageView
     *
     * @param PageView $pageView
     * @since 0.1.1
     */
    private function compileStaticPageView (&$pageView)
    {
        $targetFile = $pageView->getTargetFile();
        $output = $this->renderStaticPageView($pageView);

        $this->output->notice("Writing file: {file}", array('file' => $targetFile));
        $this->folder->writeFile($targetFile, $output);
    }

    /**
     * Write the compiled output for a dynamic PageView
     *
     * @param DynamicPageView $pageView
     * @since 0.1.1
     */
    private function compileDynamicPageViews (&$pageView)

    {
        $contentItems = $pageView->getContentItems();
        $template = $this->createTwigTemplate($pageView);

        foreach ($contentItems as $contentItem)
        {
            $targetFile = $contentItem->getTargetFile();
            $output = $this->renderDynamicPageView($template, $pageView, $contentItem);

            $this->output->notice("Writing file: {file}", array('file' => $targetFile));
            $this->folder->writeFile($targetFile, $output);
        }
    }

    /**
     * Write the compiled output for a repeater PageView
     *
     * @param RepeaterPageView $pageView
     * @since 0.1.1
     */
    private function compileRepeaterPageViews (&$pageView)

    {
        $pageView->rewindPermalink();

        $template = $this->createTwigTemplate($pageView);
        $permalinks = $pageView->getRepeaterPermalinks();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        foreach ($permalinks as $permalink)
        {
            $pageView->bumpPermalink();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $targetFile = $pageView->getTargetFile();
            $output = $this->renderRepeaterPageView($template, $pageView, $permalink);

            $this->output->notice("Writing repeater file: {file}", array('file' => $targetFile));
            $this->folder->writeFile($targetFile, $output);
        }
    }

    ///
    // Redirect handling
    ///

    /**
     * Write redirects for standard redirects
     *
     * @param PageView $pageView
     * @since 0.1.1
     */
    private function compileStandardRedirects (&$pageView)
    {
        $redirects = $pageView->getRedirects();

        foreach ($redirects as $redirect)
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
        {
            $redirectPageView = PageView::createRedirect(
                $redirect,
                $pageView->getPermalink(),
                $this->redirectTemplate
            );

            $this->compilePageView($redirectPageView);
        }
    }

    /**
     * Write redirects for expanded redirects
     *
     * @param RepeaterPageView $pageView
     * @since 0.1.1
     */
    private function compileExpandedRedirects (&$pageView)
    {
        $permalinks = $pageView->getRepeaterPermalinks();

        /** @var ExpandedValue[] $repeaterRedirect */
        foreach ($pageView->getRepeaterRedirects() as $repeaterRedirect)
        {
            /**
             * @var int           $index
             * @var ExpandedValue $redirect
             */
            foreach ($repeaterRedirect as $index => $redirect)
            {
                $redirectPageView = PageView::createRedirect(
                    $redirect->getEvaluated(),
                    $permalinks[$index]->getEvaluated(),
                    $this->redirectTemplate
                );
                $this->compilePageView($redirectPageView);
            }
        }
    }

    ///
    // Twig Functionality
    ///

    /**
     * Get the compiled HTML for a specific iteration of a repeater PageView
     *
     * @param Twig_Template $template
     * @param PageView      $pageView
     * @param ExpandedValue $expandedValue
     *
     * @since  0.1.1
     * @return string
     */
    private function renderRepeaterPageView (&$template, &$pageView, &$expandedValue)
    {
        $this->twig->addGlobal('__currentTemplate', $pageView->getFilePath());

        $pageView->setFrontMatter(array(
            'permalink' => $expandedValue->getEvaluated(),
            'iterators' => $expandedValue->getIterators()
        ));

        return $template
            ->render(array(
                'this' => $pageView->createJail()
            ));
    }

    /**
     * Get the compiled HTML for a specific ContentItem
     *
     * @param  Twig_Template $template
     * @param  PageView      $pageView
     * @param  ContentItem   $contentItem
     *
     * @since  0.1.1
     * @return string
     */
    private function renderDynamicPageView (&$template, &$pageView, &$contentItem)
    {
        $this->twig->addGlobal('__currentTemplate', $pageView->getFilePath());

        return $template
            ->render(array(
                'this' => $contentItem->createJail()
            ));
    }

    /**
     * Get the compiled HTML for a static PageView
     *
     * @param  PageView $pageView
     *
     * @since  0.1.1
     * @return string
     *
     * @throws \Exception
     * @throws \Throwable
     * @throws Twig_Error_Syntax
     */
    private function renderStaticPageView (&$pageView)
    {
        $this->twig->addGlobal('__currentTemplate', $pageView->getFilePath());

        return $this
            ->createTwigTemplate($pageView)
            ->render(array(
                'this' => $pageView->createJail()
            ));
    }

    /**
     * Create a Twig template that just needs an array to render
     *
     * @param  PageView $pageView The PageView whose body will be used for Twig compilation
     * @since  0.1.1
     *
     * @return Twig_Template
     *
     * @throws \Exception
     * @throws \Throwable
     * @throws Twig_Error_Syntax
     */
    private function createTwigTemplate (&$pageView)
    {
        try
        {
            return $this->twig->createTemplate($pageView->getContent());
        }
        catch (Twig_Error_Syntax $e)
        {
            $e->setTemplateLine($e->getTemplateLine() + $pageView->getLineOffset());
            $e->setSourceContext(new Twig_Source(
                $pageView->getContent(),
                $pageView->getName(),
                $pageView->getRelativeFilePath()
            ));

            throw $e;
        }
    }
}


Pull Request — master (#41)

Compiler A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

15 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

1			<?php
2
3			/**
4			* @copyright 2017 Vladimir Jimenez
5			* @license https://github.com/allejo/stakx/blob/master/LICENSE.md MIT
6			*/
7
8			namespace allejo\stakx;
9
10			use allejo\stakx\FrontMatter\ExpandedValue;
11			use allejo\stakx\Manager\BaseManager;
12			use allejo\stakx\Manager\TwigManager;
13			use allejo\stakx\Object\ContentItem;
14			use allejo\stakx\Object\DynamicPageView;
15			use allejo\stakx\Object\PageView;
16			use allejo\stakx\Object\RepeaterPageView;
17			use allejo\stakx\System\Folder;
18			use Twig_Environment;
19			use Twig_Error_Syntax;
20			use Twig_Source;
21			use Twig_Template;
22
23			/**
24			* This class takes care of rendering the Twig body of PageViews with the respective information and it also takes care
25			* of writing the rendered Twig to the filesystem.
26			*
27			* @internal
28			* @since 0.1.1
29			*/
30			class Compiler extends BaseManager
31			{
32			/** @var string\|false */
33			private $redirectTemplate;
34
35			/** @var PageView[] */
36			private $pageViews;
37
38			/** @var Folder */
39			private $folder;
40
41			/** @var Twig_Environment */
42			private $twig;
43
44	5		public function __construct()
45			{
46	5		parent::__construct();
47
48	5		$this->twig = TwigManager::getInstance();
49	5		}
50
51			/**
52			* @param string\|false $template
53			*/
54			public function setRedirectTemplate ($template)
55			{
56			$this->redirectTemplate = $template;
57			}
58
59			/**
60			* @param Folder $folder
61			*/
62	5		public function setTargetFolder (Folder $folder)
63			{
64	5		$this->folder = $folder;
65	5		}
66
67			/**
68			* @param PageView[] $pageViews
69			*/
70	5		public function setPageViews (array $pageViews)
71			{
72	5		$this->pageViews = $pageViews;
73	5		}
74
75			///
76			// IO Functionality
77			///
78
79			/**
80			* Compile all of the PageViews registered with the compiler
81			*
82			* @since 0.1.0
83			*/
84	5		public function compileAll ()
85			{
86	5		foreach ($this->pageViews as &$pageView)
87			{
88	5		$this->compilePageView($pageView);
89			}
90	5		}
91
92			/**
93			* Compile an individual PageView item
94			*
95			* This function will take care of determining how to treat the PageView and write the compiled output to a the
96			* respective target file.
97			*
98			* @param DynamicPageView\|RepeaterPageView\|PageView $pageView The PageView that needs to be compiled
99			* @since 0.1.1
100			*/
101	5		private function compilePageView (&$pageView)
102			{
103	5		switch ($pageView->getType())
104			{
105	5		case PageView::STATIC_TYPE:
106	5		$this->compileStaticPageView($pageView);
107	5		$this->compileStandardRedirects($pageView);
108	5		break;
109
110			case PageView::DYNAMIC_TYPE:
111			$this->compileDynamicPageViews($pageView);
			0 ignored issues – show Compatibility introduced 2017-03-17 07:45 UTC by Report Bug Copy Issue Report `$pageView` of type `object<allejo\stakx\Object\PageView>` is not a sub-type of `object<allejo\stakx\Object\DynamicPageView>`. It seems like you assume a child class of the class `allejo\stakx\Object\PageView` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
112			$this->compileStandardRedirects($pageView);
113			break;
114
115			case PageView::REPEATER_TYPE:
116			$this->compileRepeaterPageViews($pageView);
			0 ignored issues – show Compatibility introduced 2017-03-17 07:45 UTC by Report Bug Copy Issue Report `$pageView` of type `object<allejo\stakx\Object\PageView>` is not a sub-type of `object<allejo\stakx\Object\RepeaterPageView>`. It seems like you assume a child class of the class `allejo\stakx\Object\PageView` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
117			$this->compileExpandedRedirects($pageView);
118			break;
119			}
120	5		}
121
122			/**
123			* Write the compiled output for a static PageView
124			*
125			* @param PageView $pageView
126			* @since 0.1.1
127			*/
128	5		private function compileStaticPageView (&$pageView)
129			{
130	5		$targetFile = $pageView->getTargetFile();
131	5		$output = $this->renderStaticPageView($pageView);
132
133	5		$this->output->notice("Writing file: {file}", array('file' => $targetFile));
134	5		$this->folder->writeFile($targetFile, $output);
135	5		}
136
137			/**
138			* Write the compiled output for a dynamic PageView
139			*
140			* @param DynamicPageView $pageView
141			* @since 0.1.1
142			*/
143		View Code Duplication	private function compileDynamicPageViews (&$pageView)
			0 ignored issues – show Duplication introduced 2017-03-17 07:45 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
144			{
145			$contentItems = $pageView->getContentItems();
146			$template = $this->createTwigTemplate($pageView);
147
148			foreach ($contentItems as $contentItem)
149			{
150			$targetFile = $contentItem->getTargetFile();
151			$output = $this->renderDynamicPageView($template, $pageView, $contentItem);
152
153			$this->output->notice("Writing file: {file}", array('file' => $targetFile));
154			$this->folder->writeFile($targetFile, $output);
155			}
156			}
157
158			/**
159			* Write the compiled output for a repeater PageView
160			*
161			* @param RepeaterPageView $pageView
162			* @since 0.1.1
163			*/
164		View Code Duplication	private function compileRepeaterPageViews (&$pageView)
			0 ignored issues – show Duplication introduced 2017-03-17 07:45 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
165			{
166			$pageView->rewindPermalink();
167
168			$template = $this->createTwigTemplate($pageView);
169			$permalinks = $pageView->getRepeaterPermalinks();
			0 ignored issues – show Bug introduced 2017-03-17 07:45 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `allejo\stakx\Object\PageView` as the method `getRepeaterPermalinks()` does only exist in the following sub-classes of `allejo\stakx\Object\PageView`: `allejo\stakx\Object\RepeaterPageView`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
170
171			foreach ($permalinks as $permalink)
172			{
173			$pageView->bumpPermalink();
			0 ignored issues – show Bug introduced 2017-03-17 07:45 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `allejo\stakx\Object\PageView` as the method `bumpPermalink()` does only exist in the following sub-classes of `allejo\stakx\Object\PageView`: `allejo\stakx\Object\RepeaterPageView`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
174			$targetFile = $pageView->getTargetFile();
175			$output = $this->renderRepeaterPageView($template, $pageView, $permalink);
176
177			$this->output->notice("Writing repeater file: {file}", array('file' => $targetFile));
178			$this->folder->writeFile($targetFile, $output);
179			}
180			}
181
182			///
183			// Redirect handling
184			///
185
186			/**
187			* Write redirects for standard redirects
188			*
189			* @param PageView $pageView
190			* @since 0.1.1
191			*/
192	5		private function compileStandardRedirects (&$pageView)
193			{
194	5		$redirects = $pageView->getRedirects();
195
196	5		foreach ($redirects as $redirect)
			0 ignored issues – show Bug introduced 2017-03-21 01:32 UTC by Report Bug Copy Issue Report The expression `$redirects` of type `null\|array<integer,string>` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
197			{
198			$redirectPageView = PageView::createRedirect(
199			$redirect,
200			$pageView->getPermalink(),
201			$this->redirectTemplate
202			);
203
204			$this->compilePageView($redirectPageView);
205			}
206	5		}
207
208			/**
209			* Write redirects for expanded redirects
210			*
211			* @param RepeaterPageView $pageView
212			* @since 0.1.1
213			*/
214			private function compileExpandedRedirects (&$pageView)
215			{
216			$permalinks = $pageView->getRepeaterPermalinks();
217
218			/** @var ExpandedValue[] $repeaterRedirect */
219			foreach ($pageView->getRepeaterRedirects() as $repeaterRedirect)
220			{
221			/**
222			* @var int $index
223			* @var ExpandedValue $redirect
224			*/
225			foreach ($repeaterRedirect as $index => $redirect)
226			{
227			$redirectPageView = PageView::createRedirect(
228			$redirect->getEvaluated(),
229			$permalinks[$index]->getEvaluated(),
230			$this->redirectTemplate
231			);
232			$this->compilePageView($redirectPageView);
233			}
234			}
235			}
236
237			///
238			// Twig Functionality
239			///
240
241			/**
242			* Get the compiled HTML for a specific iteration of a repeater PageView
243			*
244			* @param Twig_Template $template
245			* @param PageView $pageView
246			* @param ExpandedValue $expandedValue
247			*
248			* @since 0.1.1
249			* @return string
250			*/
251			private function renderRepeaterPageView (&$template, &$pageView, &$expandedValue)
252			{
253			$this->twig->addGlobal('__currentTemplate', $pageView->getFilePath());
254
255			$pageView->setFrontMatter(array(
256			'permalink' => $expandedValue->getEvaluated(),
257			'iterators' => $expandedValue->getIterators()
258			));
259
260			return $template
261			->render(array(
262			'this' => $pageView->createJail()
263			));
264			}
265
266			/**
267			* Get the compiled HTML for a specific ContentItem
268			*
269			* @param Twig_Template $template
270			* @param PageView $pageView
271			* @param ContentItem $contentItem
272			*
273			* @since 0.1.1
274			* @return string
275			*/
276			private function renderDynamicPageView (&$template, &$pageView, &$contentItem)
277			{
278			$this->twig->addGlobal('__currentTemplate', $pageView->getFilePath());
279
280			return $template
281			->render(array(
282			'this' => $contentItem->createJail()
283			));
284			}
285
286			/**
287			* Get the compiled HTML for a static PageView
288			*
289			* @param PageView $pageView
290			*
291			* @since 0.1.1
292			* @return string
293			*
294			* @throws \Exception
295			* @throws \Throwable
296			* @throws Twig_Error_Syntax
297			*/
298	5		private function renderStaticPageView (&$pageView)
299			{
300	5		$this->twig->addGlobal('__currentTemplate', $pageView->getFilePath());
301
302			return $this
303	5		->createTwigTemplate($pageView)
304	5		->render(array(
305	5		'this' => $pageView->createJail()
306			));
307			}
308
309			/**
310			* Create a Twig template that just needs an array to render
311			*
312			* @param PageView $pageView The PageView whose body will be used for Twig compilation
313			* @since 0.1.1
314			*
315			* @return Twig_Template
316			*
317			* @throws \Exception
318			* @throws \Throwable
319			* @throws Twig_Error_Syntax
320			*/
321	5		private function createTwigTemplate (&$pageView)
322			{
323			try
324			{
325	5		return $this->twig->createTemplate($pageView->getContent());
326			}
327			catch (Twig_Error_Syntax $e)
328			{
329			$e->setTemplateLine($e->getTemplateLine() + $pageView->getLineOffset());
330			$e->setSourceContext(new Twig_Source(
331			$pageView->getContent(),
332			$pageView->getName(),
333			$pageView->getRelativeFilePath()
334			));
335
336			throw $e;
337			}
338			}
339			}
340

stakx-io / stakx

Pull Request — master (#41)

Compiler A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

15 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like