allejo\stakx\Manager\BaseManager

Complexity

Total Complexity

3

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

66.67%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	setLogger()	0	4	1
A	setContainer()	0	4	1

<?php

/**
 * @copyright 2017 Vladimir Jimenez
 * @license   https://github.com/allejo/stakx/blob/master/LICENSE.md MIT
 */

namespace allejo\stakx\Manager;

use allejo\stakx\System\Filesystem;
use Psr\Log\LoggerAwareInterface;
use Psr\Log\LoggerInterface;
use Symfony\Component\DependencyInjection\Container;
use Symfony\Component\DependencyInjection\ContainerAwareInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;

abstract class BaseManager implements LoggerAwareInterface, ContainerAwareInterface
{
    protected static $documentIgnoreList = array('/\.example$/');

    /** @var Container */
    protected $container;
    /** @var LoggerInterface */
    protected $output;

    /**
     * @var Filesystem
     */
    protected $fs;

Avoid variables with short names like $fs. Configured minimum length is 3.

    public function __construct()
    {
        $this->fs = new Filesystem();
    }

    /**
     * {@inheritdoc}
     */
    public function setLogger(LoggerInterface $logger)
    {
        $this->output = $logger;
    }

    /**
     * {@inheritdoc}
     */
    public function setContainer(ContainerInterface $container = null)
    {
        $this->container = $container;

It seems like $container can also be of type object<Symfony\Component\DependencyInjection\ContainerInterface>. However, the property $container is declared as type object<Symfony\Component\DependencyInjection\Container>. Maybe add an additional type check?

    }
}