MenuManager::addToSiteMenu() - Code Metrics - Inspection of "Split up the PageManager class" - stakx-io/stakx - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#41)

by Vladimir

created 2017-03-17 07:42 UTC

MenuManager::addToSiteMenu() C

↳ Parent: MenuManager

Complexity

Conditions	13
Paths	13

Size

Total Lines	53
Code Lines	25

Duplication

Lines	13
Ratio	24.53 %

Importance

Changes

Metric	Value
cc	13
eloc	25
nc	13
nop	1
dl	13
loc	53
rs	6.3327
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

/**
 * @copyright 2017 Vladimir Jimenez
 * @license   https://github.com/allejo/stakx/blob/master/LICENSE.md MIT
 */

namespace allejo\stakx\Manager;

use allejo\stakx\Object\JailObject;
use allejo\stakx\Object\PageView;

class MenuManager extends BaseManager
{
    /** @var PageView */
    private $siteMenu;

    public function __construct()
    {
        parent::__construct();

        $this->siteMenu = array();

    }

    /**
     * An array representing the website's menu structure with children and grandchildren made from static PageViews
     *
     * @return JailObject[]
     */
    public function getSiteMenu ()

    {
        $jailedMenu = array();

        foreach ($this->siteMenu as $key => $value)

        {
            // If it's an array, it means the parent is hidden from the site menu therefore its children should be too
            if (is_array($this->siteMenu[$key]))
            {
                continue;
            }

            $jailedMenu[$key] = $value->createJail();
        }

        return $jailedMenu;
    }

    /**
     * @param PageView[] $pageViews
     */
    public function buildFromPageViews ($pageViews)
    {
        foreach ($pageViews as &$pageView)
        {
            $this->addToSiteMenu($pageView);
        }
    }

    /**
     * @param PageView $pageView
     */
    public function addToSiteMenu (&$pageView)
    {
        $frontMatter = $pageView->getFrontMatter();

        if (isset($frontMatter['menu']) && !$frontMatter['menu'])
        {
            return;
        }

        $url = trim($pageView->getPermalink(), '/');

        // @TODO in the next breaking release, remove this check and allow the homepage to be indexed as '.'

        if (empty($url))
        {
            return;
        }

        $root = &$this->siteMenu;
        $dirs = explode('/', $url);

        while (count($dirs) > 0)
        {
            $name = array_shift($dirs);
            $name = (!empty($name)) ? $name : '.';

            if (!is_null($name) && count($dirs) == 0)
            {
                if (isset($root[$name]) && is_array($root[$name]))

                {
                    $children = &$pageView->getChildren();
                    $children = $root[$name]['children'];
                }

                $root[$name] = &$pageView;
            }
            else
            {
                if (!isset($root[$name]))
                {
                    $root[$name]['children'] = array();
                    $root = &$root[$name]['children'];
                }
                else if (isset($root[$name]) && is_array($root[$name]))

                {
                    $root = &$root[$name]['children'];
                }
                else
                {
                    $root = &$root[$name]->getChildren();
                }
            }
        }
    }
}


1		<?php
2
3		/**
4		* @copyright 2017 Vladimir Jimenez
5		* @license https://github.com/allejo/stakx/blob/master/LICENSE.md MIT
6		*/
7
8		namespace allejo\stakx\Manager;
9
10		use allejo\stakx\Object\JailObject;
11		use allejo\stakx\Object\PageView;
12
13		class MenuManager extends BaseManager
14		{
15		/** @var PageView */
16		private $siteMenu;
17
18		public function __construct()
19		{
20		parent::__construct();
21
22		$this->siteMenu = array();
		0 ignored issues – show Documentation Bug introduced 2017-03-08 20:56 UTC by Report Bug Copy Issue Report It seems like `array()` of type `array` is incompatible with the declared type `object<allejo\stakx\Object\PageView>` of property `$siteMenu`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
23		}
24
25		/**
26		* An array representing the website's menu structure with children and grandchildren made from static PageViews
27		*
28		* @return JailObject[]
29		*/
30	View Code Duplication	public function getSiteMenu ()
		0 ignored issues – show Duplication introduced 2017-03-08 20:56 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
31		{
32		$jailedMenu = array();
33
34		foreach ($this->siteMenu as $key => $value)
		0 ignored issues – show Bug introduced 2017-03-08 20:56 UTC by Report Bug Copy Issue Report The expression `$this->siteMenu` of type `object<allejo\stakx\Object\PageView>` is not traversable. Loading history...
35		{
36		// If it's an array, it means the parent is hidden from the site menu therefore its children should be too
37		if (is_array($this->siteMenu[$key]))
38		{
39		continue;
40		}
41
42		$jailedMenu[$key] = $value->createJail();
43		}
44
45		return $jailedMenu;
46		}
47
48		/**
49		* @param PageView[] $pageViews
50		*/
51		public function buildFromPageViews ($pageViews)
52		{
53		foreach ($pageViews as &$pageView)
54		{
55		$this->addToSiteMenu($pageView);
56		}
57		}
58
59		/**
60		* @param PageView $pageView
61		*/
62		public function addToSiteMenu (&$pageView)
63		{
64		$frontMatter = $pageView->getFrontMatter();
65
66		if (isset($frontMatter['menu']) && !$frontMatter['menu'])
67		{
68		return;
69		}
70
71		$url = trim($pageView->getPermalink(), '/');
72
73		// @TODO in the next breaking release, remove this check and allow the homepage to be indexed as '.'
		0 ignored issues – show Coding Style Best Practice introduced 2017-03-08 20:56 UTC by Report Bug Copy Issue Report Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker. Loading history...
74		if (empty($url))
75		{
76		return;
77		}
78
79		$root = &$this->siteMenu;
80		$dirs = explode('/', $url);
81
82		while (count($dirs) > 0)
83		{
84		$name = array_shift($dirs);
85		$name = (!empty($name)) ? $name : '.';
86
87		if (!is_null($name) && count($dirs) == 0)
88		{
89	View Code Duplication	if (isset($root[$name]) && is_array($root[$name]))
		0 ignored issues – show Duplication introduced 2017-03-08 20:56 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
90		{
91		$children = &$pageView->getChildren();
92		$children = $root[$name]['children'];
93		}
94
95		$root[$name] = &$pageView;
96		}
97		else
98		{
99		if (!isset($root[$name]))
100		{
101		$root[$name]['children'] = array();
102		$root = &$root[$name]['children'];
103		}
104	View Code Duplication	else if (isset($root[$name]) && is_array($root[$name]))
		0 ignored issues – show Duplication introduced 2017-03-08 20:56 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
105		{
106		$root = &$root[$name]['children'];
107		}
108		else
109		{
110		$root = &$root[$name]->getChildren();
111		}
112		}
113		}
114		}
115		}
116

stakx-io / stakx

Pull Request — master (#41)

MenuManager::addToSiteMenu() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like